jverbraeken/doodlejump

A Doodle Jump clone in Java with several new features

doodlejump's Issues

Breaking platforms

Enemies

Testing the Platform.class

Test JUnit SpriteFactory

SpriteFactory methods like getPlatformSprite1,2,3,4,5,6,... should be combined into a single method

Add more logging

Switch case in cucumber tests

Ik snap dat het handig is om switch case statements te gebruiken hier,
maar het kan gevaarlijk zijn ivm testen die getest moeten worden...
Mijn advies is een default te bouwen die een error genereerd.

Create more powerups

UML

The servicelocator should be a singleton (or enum singleton)

Test JUnit ServiceLocator

Documentation for the difference between ordinary and resource files

Add a new feature which the normal Doodle Jump doesn't have

Should we make a background class?

Should we make a background class, instead of every scene having its own background sprite ?

Add Doodle to startscreen

Add an animation of a bouncing Doodle to the start screen.

Test JUnit AudioManager

The player has a certain amount of coins

At least a spring should be able to spawn on moving platforms

Missing JavaDoc in Camere class

There is no JavaDoc in the Camera and ICamera class while there should be...

It is currently always possible to click the pause button once a World has been created

Even when it is no longer visible...

Singletons

Fix all PMD, Findbugs and CheckStyle errors/warnings

JSON Parser

Double locked singleton

Currently the class Calc uses a double locked singleton.
This is an unsafe implementation.
(despite the fact that it was suggested in the lectures)

Sources:
http://www.javaworld.com/article/2074979/java-concurrency/double-checked-locking--clever--but-broken.html
https://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html

Test JUnit Res

Testing Spring and Trampoline

Multiple doodle themes

PauseScreen should not be a scene

It should be part of the scene World as it was before

Highscore should display upon death

Currently you can not see your score upon dying. It would be nice to see it (plus perhaps if you made it into the highscores)

Create a lot of tests

Create new tests for behaviors with multiplayer

Powerups can spawn on moving platforms

This should either not be the case, or they should move along with the moving platform (the same goes for breaking platforms)

Should the getBoost() method in powerups only return the boost

Some added a TODO to the spring class noting that performing other tasks in a getter is unexpected behaviour. Should we remove it? If yes, how?

Implement high scores

• Save a list of high scores.
• Add a high score scene.
• Save and load high scores.

should powerup thresholds and offset be static attributes on the class itself ?

Platform Decorator Pattern

High score is drawn at menu

Unused variables in World.java

We should get rid of the unused variables in the World.java file 😄

Horizontal moving platforms

Remove the active variable in scenes

Completely unnecessary variable and it can cause bugs because the function setScene MUST be used instead of this variable to switch between scenes correctly

Create cucumber tests for the ScoreScreen

Is +1 necessary ?

Is the + 1 in RANDOM.nextInt(upper - lower) + lower + 1; in the Calc.java class really necessary? See code

PauseScreen should not be a Scene

It should be part of the scene World as it was before

Include cobertura report in maven site

Renderer rotate

We should implement a feature in the renderer to easily rotate image so that:

• The Jetpack can rotate when falling away from the Doodle.
• The Propeller can rotate when falling away from the Doodle.

Trampolines have 3 stages: Trampoline, Circus Cannon and Rocket Launcher

Correct the FIndBugs mistakes

Missing JavaDoc and unused attributes in Doodle class

We should clean up the Doodle class a bit, it is missing some JavaDoc. It has some unnused attributes and it is unclear to me what the purpose of the method w/o implementationpublic void collidesWith(IDoodle doodle) should do...

Also collide is not a good name for this method

public void collide(IJumpable jumpable) {
        this.vSpeed = jumpable.getBoost();
}

Should we remove the Constants interface

Onze TA had verzocht om minder interfaces te gebruiken, en de interface van constants is denk ik wel overbodig aangezien deze methods aanbied die veel te specifiek zijn voor een interface...

Test Junit Constants