jyhsu2000/bannermaker

Use GUI to design any kind of banner

bannermaker's Issues

Feature to bypass pattern limitation.

Feature Request

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

BannerMaker stop to work

on my 1.8.9 server with viaversion, using BM 1.4.5
i crete a letter M with pink background, after i create it, i can't bak to menu and it trow this error:
http://pastebin.com/kvibUdkX

my language file (translated in italian) http://pastebin.com/3wKY3DXj

Is 1.14.2 support?

1.14.2 is supported?

BannerMaker GUI needs to be updated with Black Dye instead of Ink Sac.

Paper dev (Spigot 1.14.4)
BannerMaker dev 224

The BannerMaker GUI is showing ink sacs instead of black dye in 1.14 for the recipe. This is no longer a thing in 1.14 and people should be using black dye instead.

Missing banner pattern

Would it be possible to add the 'Snout' banner pattern?

German Translation added

hey i added a german translation for you bannermaker. feel free to add it in a future update if you want
de.zip

1.18

Can you update plugin to support 1.18?

Cant use plugin to bypass crafting limitation on banner pattern count

Bug Report

Environment

• OS: Windows 10
• Server version: paper 1.20
• Minecraft version: <1.20.1
• BannerMaker version: v2.3.2

Expected Behaviour

• Banner Maker should allow you to fake craft using the GUI and display all of the required materials even if over banner pattern limit

Actual Behaviour

• Banner Maker doesnt list all the required materials if the banner is over pattern count, making it impossible to bypass the vanilla limitation unless free banners is enabled

Steps to reproduce

1. Make a banner with more than 6 patterns in the GUI
2. Try to craft it using the GUI

Creeper Head Banners not working

Every time I try and make a banner featuring a creeper head or my players do, this doesn't work and the craft recipe won't even come up or anything.

• OS: I use a mac? But i have my server via McProHosting
• Java version: Latest
• Server version: Latest
• Minecraft version: 1.13
• BannerMaker version: Latest

I expected to be able to create a banner.

Actual Behaviour

Every time I try and make a banner featuring a creeper head or my players do, this doesn't work and the craft recipe won't even come up or anything.

Steps to reproduce

Simply create a creeper banner.

Feature to bypass pattern limitation.

Feature Request

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

BannerMaker is missing the patterns Globe & Snout

BannerMaker/src/main/java/club/kid7/bannermaker/util/BannerUtil.java

Line 175 in 94968c1

case MOJANG:

@jyhsu2000 BannerMaker is missing the patterns Globe globe_banner_pattern & Snout piglin_banner_pattern.
https://minecraft.fandom.com/wiki/Banner_Pattern

Jenkins fails to compile the newer builds - missing dependencies.

@jyhsu2000 Jenkins fails to compile the newer builds.

[ERROR] Failed to execute goal on project BannerMaker: Could not resolve dependencies for project tw.kid7:BannerMaker:jar:1.5.0: Failed to collect dependencies for [org.bukkit:bukkit:jar:1.11.2-R0.1-SNAPSHOT (provided), net.milkbowl.vault:VaultAPI:jar:1.6 (provided), org.bstats:bstats-bukkit:jar:1.1 (compile)]: Failed to read artifact descriptor for org.bukkit:bukkit:jar:1.11.2-R0.1-SNAPSHOT: Could not transfer artifact org.bukkit:bukkit:pom:1.11.2-R0.1-SNAPSHOT from/to spigot-repo (https://hub.spigotmc.org/nexus/content/repositories/snapshots/): peer not authenticated -> [Help 1]

Feature to bypass pattern limitation. A way to craft

Feature Request

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

RGB message support

Hello, I would like to ask, if rgb colours are supported in plugins messages.
For example, I tryed prefix: #6a0958&lF#73084f&lé#7b0746&ln#84063e&li#8d0535&lx#96052c&lC#9e0423&lr#a7031a&la#b00212&lf#b80109&lt

But in this format, it couldnt take the colour.

Thank you.

Creating an API

Hi!
I have started creating the API. The basic structure is done. By now the only feature is to open the BannerMaker menu. I want to add more functions, like bypassing the paying.

Don't know why but the fork button is not working at the moment so I can't upload the code. In the pastebin you have the class where al the API voids are stored. The current code is tested and it works OK. To add new functions you just have to add voids there.

I will upload the other classes as soon as I can.

API class: http://pastebin.com/e9pGcXCh

Fatal error trying to convert BannerMaker v1.9.0:club/kid7/bannermaker/command/SeeCommand

BannerMaker dev 201
Paper 1.13.1 (Spigot) dev 284

[17:43:12] [Server thread/INFO]: [BannerMaker] Enabling BannerMaker v1.9.0*
[17:43:12] [Server thread/ERROR]: Fatal error trying to convert BannerMaker v1.9.0:club/kid7/bannermaker/command/SeeCommand.class
org.bukkit.plugin.AuthorNagException: No legacy enum constant for LEGACY_BANNER. Did you forget to define api-version: 1.13 in your plugin.yml?
	at org.bukkit.craftbukkit.v1_13_R2.util.Commodore$1$1.visitFieldInsn(Commodore.java:154) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.objectweb.asm.ClassReader.readCode(ClassReader.java:2207) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1274) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.objectweb.asm.ClassReader.accept(ClassReader.java:679) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.objectweb.asm.ClassReader.accept(ClassReader.java:391) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.craftbukkit.v1_13_R2.util.Commodore.convert(Commodore.java:130) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.craftbukkit.v1_13_R2.util.CraftMagicNumbers.processClass(CraftMagicNumbers.java:221) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:131) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.java.JavaPluginLoader.getClassByName(JavaPluginLoader.java:191) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:115) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:104) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
	at club.kid7.bannermaker.BannerMaker.registerCommands(BannerMaker.java:119) ~[?:?]
	at club.kid7.bannermaker.BannerMaker.onEnable(BannerMaker.java:48) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:325) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugin(CraftServer.java:435) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugins(CraftServer.java:349) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.l(MinecraftServer.java:613) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:575) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:435) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at net.minecraft.server.v1_13_R2.DedicatedServer.init(DedicatedServer.java:311) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:791) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]
[17:43:12] [Server thread/ERROR]: Fatal error trying to convert BannerMaker v1.9.0:club/kid7/bannermaker/command/HandCommand.class
org.bukkit.plugin.AuthorNagException: No legacy enum constant for LEGACY_BANNER. Did you forget to define api-version: 1.13 in your plugin.yml?
	at org.bukkit.craftbukkit.v1_13_R2.util.Commodore$1$1.visitFieldInsn(Commodore.java:154) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.objectweb.asm.ClassReader.readCode(ClassReader.java:2207) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1274) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.objectweb.asm.ClassReader.accept(ClassReader.java:679) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.objectweb.asm.ClassReader.accept(ClassReader.java:391) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.craftbukkit.v1_13_R2.util.Commodore.convert(Commodore.java:130) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.craftbukkit.v1_13_R2.util.CraftMagicNumbers.processClass(CraftMagicNumbers.java:221) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:131) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.java.JavaPluginLoader.getClassByName(JavaPluginLoader.java:191) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:115) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:104) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
	at club.kid7.bannermaker.BannerMaker.registerCommands(BannerMaker.java:119) ~[?:?]
	at club.kid7.bannermaker.BannerMaker.onEnable(BannerMaker.java:48) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:325) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugin(CraftServer.java:435) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at org.bukkit.craftbukkit.v1_13_R2.CraftServer.enablePlugins(CraftServer.java:349) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.l(MinecraftServer.java:613) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:575) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:435) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at net.minecraft.server.v1_13_R2.DedicatedServer.init(DedicatedServer.java:311) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:791) ~[patched_1.13.1.jar:git-Paper-"81f163d6"]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]

update of german translation(used wrong bm-version)

im sorry but i maked an mistake. i used bannermaker 1.3.2.
updated my bannermaker to 1.4.1 and made a new translation with translations of the 1.4+ features and also corrected a small mistake i made in the last translation
here the updated file:
de.zip

Money

Bug Report

Environment

• OS: Linux
• Java version: 17
• Server version: paper 1.18.1
• Minecraft version: 1.18.1
• BannerMaker version: 2.3.2

Expected Behaviour

I expect the plugin to take players money when making a banner.

Actual Behaviour

It gives the player the banner without taking their money.

Steps to reproduce

/bm opens the GUI make a banner you have the materials, it makes it but does not take any money from you.

Title cannot be longer than 32 characters

3 server owners got Title cannot be longer than 32 characters once someone click Alphabet & Number button,
but none of they upload his config.yml and language file he use.
And I tested on several versions of Spigot and it didn't happen.
So I cannot easily fix it if there is no more information.

What I need to know to fix it is the following

• config.yml
• language file
• server type (CraftBukkit, Spigot, PaperSpigot ... or what)
• server version

http://www.mcbbs.net/forum.php?mod=redirect&goto=findpost&ptid=415289&pid=10337426

https://www.spigotmc.org/threads/bannermaker.51892/page-5#post-1668702

https://www.spigotmc.org/threads/bannermaker.51892/page-5#post-1671336

Delete button missing from "Banner Info" page.

Hello, my version of Bannermaker does not have the delete button on the "Banner Info" page.

Can you fix this, or am I using an old version and it was fixed in the new version?

Thanks,
-Dark.

Image of issue:
https://media.discordapp.net/attachments/588674557242638347/790371001250086932/unknown.png

1.13.1 API Compatibility

Any plans on updating to support Spigot 1.13 API? :)