jzempel/stamps

Stamps.com API for Python

stamps's Issues

Floats are being used for money

It appears that postage amounts are represented with floats instead of decimals.

This might be a suds problem, but I figured it was important to at least mention this. Float results in rounding errors and should not be used for money.

Here is an example I just encountered -- Amount is 5.42, but it is shown as 5.4199999999999999 under the hood.

I discovered this because the decimal class raised a TypeError when it was fed the float.

If it is possible to use the decimal class, that would be prudent.

pass proxy information to suds

Suds does not pull proxy information from environment variables. Per https://bitbucket.org/jurko/suds/issues/26/doesnt-work-behind-proxy it requires explicit proxy configuration.

As such, the BaseService should expose this here https://github.com/jzempel/stamps/blob/master/stamps/services.py#L87

adjust wsdl file path url to work with windows drive letters

The formatting for the wsdl file:// url produces invalid url for me causing

URLError: <urlopen error [Error 3] The system cannot find the path specified: ''

See https://github.com/jzempel/stamps/blob/master/stamps/config.py#L71

self.wsdl = "file://{0}".format(wsdl)

This works for me: thenewguy@ea5f161

Python 3

Have you done any testing using suds-jurko master codebase? Would allow for python 3 compatibility.

Per https://bitbucket.org/jurko/suds/issues/117/please-release-new-version Debian Sid and Fedora 24 used it for their release version of the package

• https://fedoraproject.org/wiki/Changes/Suds_Jurko_Fork
• https://bugzilla.redhat.com/show_bug.cgi?id=1301535

Accept kwargs on convenience methods

It would be nice to be to pass through kwargs supplied to the convenience methods. It is probably too much work to keep all of the kwargs up to date, but if kwargs are passed through as is then it doesn't require creating a subclass of the service to allow get_label to specify the image type or other less commonly used options.

Or something like this could be used to convert stamps camelcase to underscore notation with a map function for the option keys

import re

first_cap_re = re.compile('(.)([A-Z][a-z]+)')
all_cap_re = re.compile('([a-z0-9])([A-Z])')

def pythonify_stamps_key(key):
    """
        THIS FUNCTION CONVERTS STAMPS.COM API CAMEL CASED
        FIELD NAMES INTO PYTHONIC UNDERSCORED FIELD NAMES
    """
    s1 = first_cap_re.sub(r'\1_\2', key)
    return all_cap_re.sub(r'\1_\2', s1).lower()

Doc improvement

A minor example that logs in, gets account info and creates a shipping label would be helpful.

Using python3, getting "name 'basestring' is not defined" because basestring is no longer in python, needs to be replaced with str

'basestring' is no longer in python 3.0 and up.

Need to replace 'basestring' instances with 'str'.

Hidden postage and memo in the label call

Hello Jonathan,

I am trying to figure out how to get these work and hopefully you can shed some light on these.

• Hidden Postage
  I appended the addon but the postage still appeared on the label
  ....
  addOn = service.create_add_on()
  addOn.AddOnType = 'SC-A-HP'
  ret_val.AddOns.AddOnV7.append(addOn)
  ....
• memo:
  I added memo in the call to see if it would work, but it didn't appear on the label

def get_label(self, from_address, to_address, rate, transaction_id, sample=False):
return self.call("CreateIndicium", IntegratorTxID=transaction_id,
Rate=rate, From=from_address, To=to_address, SampleOnly=sample, memo='test order')