kaaveh / composenews Goto Github PK

A playground about best practices, using updated libraries and solutions in the Android world!

License: Apache License 2.0

Kotlin 99.00% Ruby 0.24% Shell 0.76%

android architecture best-practices hacktoberfest jetpack-compose

composenews's Introduction

🤔 Philosophus
💻 Android engineer
🍀 Life coach
🚴🏻 Cyclict
🧘🏻‍♂️ Meditator
🥋 Martial artist
🏔 Mountaineer
📻 Podcaster: WonderLand, Journal club, The voice of my books, Kapsoul
🎥 Youtuber: Code with Kaaveh, With Kaaveh, Cycling with Kaaveh

You can find me on androiddev.social, Twitter, LinkedIn, CodeForces and Telegram

Find my CV here

composenews's People

Contributors

Stargazers

Watchers

Forkers

alibahaaa nookeh amin-asvadi ganeshvl virendersran01 glovebx fziraki jurext raoakhan rezafaraji93 neerav006 sergeyalecky rfrench2 shahbazzafar mohammadsianaki mohammadrezaei92 mhmd-android smmousavi8872 raminabbasiiii tinat2 baharudin78 sajjad-dehnavi hossein69ameri mwgrin07 dekan yashsongara101 beradeep manelcc rubenquadros maryammohamedi codroid-ir theklcd hadi-norouzi sagar19raorane nhattq98 mohammadazadbar1995 temples-dev parkduksung mahdiabbasian vahidgarousi chandrakantomn

composenews's Issues

[replace] gson with kotlin serialization

Skeleton for Detail screen

[refactor] gradle compose metrics setup

[feature] Add mono-chromic version of app icon

[refactor] update readme

Syncing favorite state across screens

[R/D] redesign the app

[Discussion] Coupling codes when using base classes

I think we shouldn't use base classes like: BaseContract, BaseScreen and BaseViewModel.
Just keep it separated like in the medium article.
Maybe those base classes all work in the current codebase but when it is expanded, we will be confused to use they or not and use for what.

[refactor] migrate room to SQDlight

[feature] dynamic color and replace material 2 instead material 3

I closed the previous pull request because of Mohammad Rezaei's update. After changing the rest of the components completely to Material 3, I will make a pull request again.

[refactor] update dependencies

[bugfix] `danger` on PR from forks

[version] increase version number

[Feature Suggestion] Sort Markets

Description

I suggest the addition of a sorting feature, allowing users to arrange markets either by price or by name, in both ascending and descending order. This enhancement would greatly improve the user experience.

Technical Considerations:

Strategy Design Pattern: We can utilize the Strategy design pattern, where each sorting strategy (e.g., by price, by name) is encapsulated in its own class. These sorting strategy classes should adhere to a common interface, allowing easy integration into the sorting system.
Pluggable Architecture: Design the sorting system to be pluggable, allowing new sorting strategies to be added as separate modules without touching the core sorting logic. This promotes the idea of extending the system without modifying existing code.
Unit Testing: Ensure that each sorting strategy is independently testable. Write unit tests for each strategy to validate their correctness. This will prevent regressions when new strategies are added.

@OptIn(ExperimentalMaterial3WindowSizeClassApi::class)
@Preview(showBackground = true, widthDp = 700, heightDp = 500)
@Composable
fun ComposeNewsAppPreviewTablet() {
    ComposeNewsTheme {
        ComposeNewsApp(
            windowSize = WindowSizeClass.calculateFromSize(DpSize(700.dp, 500.dp)),
            displayFeatures = emptyList(),
            uiState = MainContract.State(),
            closeDetailScreen = {},
        )
    }
}

@OptIn(ExperimentalMaterial3WindowSizeClassApi::class)
@Preview(showBackground = true, widthDp = 500, heightDp = 700)
@Composable
fun ComposeNewsAppPreviewTabletPortrait() {
    ComposeNewsTheme {
        ComposeNewsApp(
            windowSize = WindowSizeClass.calculateFromSize(DpSize(500.dp, 700.dp)),
            displayFeatures = emptyList(),
            uiState = MainContract.State(),
            closeDetailScreen = {},
        )
    }
}

@OptIn(ExperimentalMaterial3WindowSizeClassApi::class)
@Preview(showBackground = true, widthDp = 1100, heightDp = 600)
@Composable
fun ComposeNewsAppPreviewDesktop() {
    ComposeNewsTheme {
        ComposeNewsApp(
            windowSize = WindowSizeClass.calculateFromSize(DpSize(1100.dp, 600.dp)),
            displayFeatures = emptyList(),
            uiState = MainContract.State(),
            closeDetailScreen = {},
        )
    }
}

@OptIn(ExperimentalMaterial3WindowSizeClassApi::class)
@Preview(showBackground = true, widthDp = 600, heightDp = 1100)
@Composable
fun ComposeNewsAppPreviewDesktopPortrait() {
    ComposeNewsTheme {
        ComposeNewsApp(
            windowSize = WindowSizeClass.calculateFromSize(DpSize(600.dp, 1100.dp)),
            displayFeatures = emptyList(),
            uiState = MainContract.State(),
            closeDetailScreen = {},
        )
    }
}

Replace it with DevicesPreviews defined in designsystem module