Giter Site home page Giter Site logo

kabisa / books Goto Github PK

View Code? Open in Web Editor NEW
3.0 3.0 0.0 3.26 MB

At Kabisa we read books. And we read a lot of books. Get inspired by finding out which books we read and like the best...

Home Page: https://books.kabisa.nl

Ruby 75.14% JavaScript 5.82% CSS 0.15% HTML 1.12% Gherkin 9.55% Slim 5.70% SCSS 2.51%
hotwire rails stimulus-js

books's People

Contributors

ariejan avatar bazzel avatar dependabot[bot] avatar joostsaanen avatar pascalw avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

books's Issues

User cannot log in

A user is not able to login. When trying to log in, a 500 error occurs.

Steps to reproduce:

  • Navigate to books.kabisa.nl
  • Click Sign in in the top right corner of the page
  • Fill in your Kabisa email address and click Sign In

Expected behaviour:
A confirmation page should show up and the user receives an email with a URL to continue the process.

Actual behaviour:
The following page occurs:

Screenshot 2023-06-21 at 06 58 36

This is caused by a missing setting in Sendgrid - when trying to send a mail, sendgrid raises an exception which results in a 500 error:

Net::SMTPFatalError (550 The from address does not match a verified Sender Identity. Mail cannot be sent until this error is resolved. Visit https://sendgrid.com/docs/for-developers/sending-email/sender-identity/ to see the Sender Identity requirements

This error can be resolved by following the instructions in the URL mentioned in the error log.

Mail from sendgrid is detected as a potentially malicious email

When a Kabisaan signs in, the mail that's being sent is detected as a potentially malicious email by gmail.

Steps to reproduce:

  • Navigate to books.kabisa.nl
  • In the top right, click "Sign in"
  • Enter your Kabisa email address and click "Sign in"
  • In a new tab, open mail.kabisa.nl

Expected behaviour:
A unsuspicious mail is delivered and can be found in your inbox.

Actual behaviour:
Gmail shows a warning that the mail could not be verified.

Screenshot_2022-04-21_at_15_00_02

Dropdown with years when adding books is not scrollable.

I just tried adding a book from 2009, but couldn't select it straight away (only goes down to 2010 initially). I tried selecting 2010 and then opening it again, now it shows a few years before / after 2010.

Can this dropdown be made scrollable?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.