kae7in/perfview

PerfView is a performance-analysis tool that helps isolate CPU- and memory-related performance issues.

perfview's Issues

numNodes restriction needs to be changeable

In stackDelegate.js there is a property called numNodes (self.numNodes at the top of the StackDelegate class) that specifies an upper bound for the number of nodes that can be returned for any given request. There should be a text input (maybe next to the filter inputs) to specify this. However, an issue with this is that, once you specify numNodes in a request, the service seems to stick with that, even if you specify different values for numNodes in subsequent requests. Note: numNodes must be appended to the url as a query string (&numNodes=1000)

Add ROOT node as parent in CallTree view (use 'node' endpoint)

Use jQuery get and post requests instead of raw AJAX

According to a lot of online resources, I'm apparently trying to reinvent the wheel. Using XMLHttp requests can be dangerous across different browsers and versions.

Implement When clause

Make source node parent of tree in each tab (the source node is the node the user clicked on in the By Name tab)

BasicContext context menu (node) library not working in Electron.

Right clicking on the Tree View (as a test) results in the following error being emitted in the console:

C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:63 Uncaught TypeError: Cannot read property 'name' of undefinedvalueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:63valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70valueToMeta @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:70wrapArgs @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:92remoteMemberFunction @ C:\Users\t-kahoop\AppData\Roaming\npm\node_modules\electron-prebuilt\dist\resources\electron.asar\r…:111(anonymous function) @ index.html:215

Error Line

Best commit to replicate error from

To run project:
Navigate to {user path}\perfview\src\HtmlJs\perfview in Windows PowerShell (or other) and simply type 'electron .'

To replicate error:
Right-click (contextmenu event) anywhere on the Tree View. The menu is, right now, designed to trigger if a contextmenu triggers on that tree view div. Error is visible in electron console output.

Use Directory class instead of dealing with directories myself (in Extensibility.cs)

Consider adding filter defaults like PerfView does

Add origin property to Delegate in Delegate.js

In by-name-list double click event, deep copy of node is not working correctly

I've commented the logic out for now, but around line 517, in the by-name-list double click event listener, we are grabbing the node that was double clicked on and making it the new focus node. This focus node is then used as the root node in the Callers and Callees tab. However, before it's used in those tabs, we need to switch its Exc% and Exc columns with the Inc% and Inc columns, since they are in reverse order in all other tabs (look at the table headers/names or the real PerfView for reference). The ISSUE with this is that when you switch those values, they get switched in the by-name-list tree table as well. This is because I'm undesirably holding a pointer to that node instead of a true clone.

Fill out Help section

Make navbar, filters, and tabs fixed to top of stackview (refer to footer css)

Remove items that are not yet working

Clicking 'next' button to navigate to found nodes that were collapsed (after searching) does not work

Allow for resizable table columns

Move all references to target URL to an internal settings class

Separate index.html into reusable parts (e.g. navbar and footer/status bar)

https://github.com/Kae7in/perfview/blob/ui/src/HtmlJs/perfview/index.html

Collapse all nodes when user closes the top node

Better indicate when the application is working/fetching

Make tabs remember find query between requests on different tabs

Route "stackviewer/node" (GetNode) is not including Exc%, Exc, or Fold in the node data returned

This results in the ROOT node in CallTree showing 0 for the Exc%, Exc, and Fold columns. By focusing on the ROOT node (double click on ROOT in By Name tab), you'll see that the ROOT node actually has non-zero values for these properties.

The request takes the following path:
(DataController.cs) GetNode() --> (StackViewerController.cs) Node() --> (CallTreeDataProvider.cs) GetNode()

It's in this last GetNode() call in CallTreeDataProvider.cs that the implementation for actually getting a single node begins.

Disable search on node open

Add 'find' search query to cache key

Get rid of log.flush() in Extensibility.cs; use "using {}" instead!

Auto load nodes when there is only one child

Look into creating .exe for Electron app

In onNodeExpand, split node id on first occurrence of '/' instead of iterating

Exceptions are still occurring when looking up symbols for modules in CallTreeDataProviderFactory.cs (lines 175 and 220)

Create exception to catch "index.html:94 Uncaught ReferenceError: resizeWelcomeDiv is not defined"