kalanadananjaya/distributed-content-search

This repository contains the source code for a Distributed Peer to Peer Content Searching system built with unstructured overlay routing protocols

distributed-content-search's Issues

Change the signature of download file

distributed-content-search/src/main/java/com/distributed/p2pFileTransfer/FileHandler.java

Line 31 in 511c9f3

protected Future<FileDownloadResult> downloadFile(Node source, String fileName, String destination) {

Since paths for both normal download (= downloads by the user) (I assume this is local dir, otherwise let's add another parameter to the constructor called download dir) and the cache is already given in the constructor this public function which can be used to download files where needed is redundant. Instead, add two new protected functions one to download to the download dir (will be called when the user asks to download a file) and another to cache a file (will be called by the thread handling search requests received from other nodes), and remove this function from the protected interface.
I think the easiest way will be to make this function private and create two protected functions which will call this with the correct values for the destination

Node don't correctly reconnet if already registered with the boostrap server

@LahiruOshara Implement this line:

distributed-content-search/src/main/java/com/distributed/p2pFileTransfer/Network.java

Line 159 in e55b105

// unregister from BS: implement method ?????????????????????????????????????????

Multiple files being added to cache filelist

Tested with 2 nodes, 10 nodes and still has the issue of multiple files being cached in cache filelist.txt

Required outputs for performance analysis

@heshanpadmasiri
These details are required for each node

1. The following query message count

• SER - the number of query messages received
• FWD - the number of query messages forwarded
• ANS - the number of query messages answered
  (better if it accumulates after every query)

2. Latency and no of hops per query

The required format for latency and no of hops would be as follow after every query execution
"latency-4ms hops-5"

And a CLI command to get SER, FWD, ANS as follow
"SER-20 FWD-10 ANS-5"

Handle cases where no file matches the search

@KalanaDananjaya If the search result is empty show it in the terminal. Currently silently ignored.

distributed-content-search/src/main/java/com/distributed/p2pClient/Main.java

Line 47 in 04c18ed

for(String name : queryResult) {

Change the executor service

distributed-content-search/src/main/java/com/distributed/p2pFileTransfer/FileHandler.java

Line 35 in 511c9f3

ExecutorService executorService = Executors.newSingleThreadScheduledExecutor();

It would be better if we don't create separate executor services for each function calls because it is expensive to create them. If possible move it to the constructor. (If we do this change the single thread executor to something like fixedThreadPool (if we have a reason to control the maximum number of parallel file download threads) or cachedThreadPool)

Create a print routing table function

@LahiruOshara

Replace all prints with loggers

distributed-content-search/src/main/java/com/distributed/p2pFileTransfer/FileHandler.java

Line 39 in 511c9f3

System.out.println(result.get());

I think it will be better if we can replace all the print statements with loggers (nothing fancy just use the java.util.logging.Logger) so all the outputs user sees are from the client application (Thameera's part). Otherwise, when we want to change the outputs we will have to check the entire project to find where the output came from.

Better if you can follow the same process I have used so we can easily find from where the log came from
https://github.com/heshanpadmasiri/distributed-content-search/blob/beb3d476c0d7f2c970d3232695dcca642b355057/src/main/java/com/distributed/p2pFileTransfer/Executor.java#L25

This is will not add new neighbours if they are not already in the table

@LahiruOshara Add logic to add completely new nodes

distributed-content-search/src/main/java/com/distributed/p2pFileTransfer/Network.java

Line 105 in b317650

if (node.getPort() == entity.getPort() && node.getIpAddress() == entity.getIpAddress()) {