kalininalab/rinminer

RINminer is a frequent subgraph mining tool based on the gSpan algorithm with additional features and optimizations for residue interaction networks (RINs).

rinminer's Issues

A protential bug in Jenkins hash function

Hi,

Thanks for releasing such nice toolkit for frequent subgraph mining. I find something that may cause unexpected bugs in the ash function between Line 494 and 534 in rinminer/rinminer.c.
In Jenkins hash function, the wikipedia says it is
hash += key; hash += (hash << 10); hash ^= (hash >> 6);
But the code mistakenly uses
hash ^= (hash << 6);
From my view, it is easy to drop the digits at the highest position.
Because there are six numbers and we need to shift (10 + 6) * 6 = 96 times, which is larger than 32 bits of one integer.

I believe it is a bug but I do not know whether it causes something unforeseeing.

Best regards,
Sean