kalkin/ddt

Distribution Development Tool for the Perl 6 Programming Language

ddt's Issues

Integrate GitHubActions for running tests

Can't install because test fails

On Arch Linux linuxboxhome 5.9.11-arch2-1 #1 SMP PREEMPT Sat, 28 Nov 2020 02:07:22 +0000 x86_64 GNU/Linux
with Raku "This is Rakudo version 2020.09 built on MoarVM version 2020.09
implementing Raku 6.d."

I get this when trying to install Ddt:

zef install Ddt
===> Searching for: Ddt
===> Searching for missing dependencies: License::Software:ver<0.2.0>
===> Searching for missing dependencies: Pluggable
===> Testing: Pluggable:ver<0.5>:auth<zef:tony-o>
===> Testing [OK] for Pluggable:ver<0.5>:auth<zef:tony-o>
===> Testing: License::Software:ver<0.2.0>:auth<kalkin>
[License::Software]     # github source https://github.com/kalkin/License-Software needs to end in .git
===> Testing [OK] for License::Software:ver<0.2.0>:auth<kalkin>
===> Testing: Ddt:ver<0.5.9>:auth<kalkin>
[Ddt] ===SORRY!=== Error while compiling /home/wolf/.zef/store/Ddt.git/ae536d4d374c9c2b7d834e8692074fe635729eca/t/01-basic.t
[Ddt] ===SORRY!=== Error while compiling /home/wolf/.zef/store/Ddt.git/ae536d4d374c9c2b7d834e8692074fe635729eca/lib/Ddt/Distribution.pm6 (Ddt::Distribution)
[Ddt] Could not find License::Software:ver<0.3.*> in:
[Ddt]     file#/home/wolf/.zef/store/Ddt.git/ae536d4d374c9c2b7d834e8692074fe635729eca
[Ddt]     inst#/home/wolf/.raku
[Ddt]     inst#/home/wolf/.rakubrew/versions/moar-2020.09/install/share/perl6/site
[Ddt]     inst#/home/wolf/.rakubrew/versions/moar-2020.09/install/share/perl6/vendor
[Ddt]     inst#/home/wolf/.rakubrew/versions/moar-2020.09/install/share/perl6/core
[Ddt]     ap#
[Ddt]     nqp#
[Ddt]     perl5#
[Ddt] Please note that a 'META6.json' file was found in '.', of which the 'provides' section was used to determine if a dependency is available or not.  Perhaps you need to add 'License::Software:ver<0.3.*>' in the <provides> section of that file?  Or need to specify a directory that does *not* have a 'META6.json' file?
[Ddt] at /home/wolf/.zef/store/Ddt.git/ae536d4d374c9c2b7d834e8692074fe635729eca/lib/Ddt/Distribution.pm6 (Ddt::Distribution):5
[Ddt] at /home/wolf/.zef/store/Ddt.git/ae536d4d374c9c2b7d834e8692074fe635729eca/t/01-basic.t:4
[Ddt] Failed to change the working directory to '/tmp/sZV1dOhjU2/Foo-Bar': does not exist
[Ddt]   in block <unit> at t/02-generate-test.t line 12
[Ddt] Failed to change the working directory to '/tmp/FJvTTHIj5C/Foo-Bar': does not exist
[Ddt]   in block <unit> at t/03-absent-dirs.t line 12
[Ddt] ===SORRY!=== Error while compiling /home/wolf/.zef/store/Ddt.git/ae536d4d374c9c2b7d834e8692074fe635729eca/t/03-distribution.t
[Ddt] ===SORRY!=== Error while compiling /home/wolf/.zef/store/Ddt.git/ae536d4d374c9c2b7d834e8692074fe635729eca/lib/Ddt/Distribution.pm6 (Ddt::Distribution)
[Ddt] Could not find License::Software:ver<0.3.*> in:
[Ddt]     file#/home/wolf/.zef/store/Ddt.git/ae536d4d374c9c2b7d834e8692074fe635729eca
[Ddt]     inst#/home/wolf/.raku
[Ddt]     inst#/home/wolf/.rakubrew/versions/moar-2020.09/install/share/perl6/site
[Ddt]     inst#/home/wolf/.rakubrew/versions/moar-2020.09/install/share/perl6/vendor
[Ddt]     inst#/home/wolf/.rakubrew/versions/moar-2020.09/install/share/perl6/core
[Ddt]     ap#
[Ddt]     nqp#
[Ddt]     perl5#
[Ddt] Please note that a 'META6.json' file was found in '.', of which the 'provides' section was used to determine if a dependency is available or not.  Perhaps you need to add 'License::Software:ver<0.3.*>' in the <provides> section of that file?  Or need to specify a directory that does *not* have a 'META6.json' file?
[Ddt] at /home/wolf/.zef/store/Ddt.git/ae536d4d374c9c2b7d834e8692074fe635729eca/lib/Ddt/Distribution.pm6 (Ddt::Distribution):5
[Ddt] at /home/wolf/.zef/store/Ddt.git/ae536d4d374c9c2b7d834e8692074fe635729eca/t/03-distribution.t:3
===> Testing [FAIL]: Ddt:ver<0.5.9>:auth<kalkin>
Aborting due to test failure: Ddt:ver<0.5.9>:auth<kalkin> (use --force-test to override)

Replace Travis CI with GitHub Actions

AFAIK Travis CI is free tier is gone, so we can remove the generation of travis config. Instead we should use GitHub Actions like implemented in #14.

Fix running tests on windows

During implementation of #14 I noticed that zef test . fails when running it with windows-latest os on GitHubActions.

This fails now due to Pod::To::Markdown

===> Testing: Pod::To::Markdown:ver<v.0.1.4>
[Pod::To::Markdown] # Failed test 'Basic table with explicit separators'
[Pod::To::Markdown] # at t/table.t line 22
[Pod::To::Markdown] # expected: "<table class=\"pod-table\">\n<caption>Table 1</caption>\n<thead><tr>\n<th>H 1</th> <th>H 2</th> <th>H 3</th>\n</tr></thead>\n<tbody>\n<tr> <td>A A</td> <td>B B</td> <td>C C</td> </tr> <tr> <td>1 1</td> <td>2 2</td> <td>3 3</td> </tr>\n</tbody>\n</table>\n"
[Pod::To::Markdown] #      got: "<table class=\"pod-table\"><caption>Table 1</caption>\t<thead>\n\t\t<tr><th>H 1</th><th>H 2</th><th>H 3</th></tr>\n\t</thead>\t<tbody>\n\t\t<tr><td>A A</td><td>B B</td><td>C C</td></tr>\n\t\t<tr><td>1 1</td><td>2 2</td><td>3 3</td></tr>\n\t</tbody>\n</table>\n"
[Pod::To::Markdown] # Failed test 'Whitespace delim, no header'
[Pod::To::Markdown] # at t/table.t line 39
[Pod::To::Markdown] # expected: "<table class=\"pod-table\">\n<tbody>\n<tr> <td>A A</td> <td>B B</td> <td>C C</td> </tr> <tr> <td>1 1</td> <td>2 2</td> <td>3 3</td> </tr>\n</tbody>\n</table>\n"
[Pod::To::Markdown] #      got: "<table class=\"pod-table\">\t<tbody>\n\t\t<tr><td>A A</td><td>B B</td><td>C C</td></tr>\n\t\t<tr><td>1 1</td><td>2 2</td><td>3 3</td></tr>\n\t</tbody>\n</table>\n"
[Pod::To::Markdown] # Failed test 'Multi-line line table with space-separated rows'
[Pod::To::Markdown] # at t/table.t line 63
[Pod::To::Markdown] # expected: "asdf\n\n<table class=\"pod-table\">\n<caption>Table 3</caption>\n<thead><tr>\n<th>H11</th> <th>HHH 222</th> <th>H 3</th>\n</tr></thead>\n<tbody>\n<tr> <td>AAA</td> <td>BB</td> <td>C C C C</td> </tr> <tr> <td>1 1</td> <td>2 2 2 2</td> <td>3 3</td> </tr>\n</tbody>\n</table>\n\nasdf\n"
[Pod::To::Markdown] #      got: "asdf\n\n<table class=\"pod-table\"><caption>Table 3</caption>\t<thead>\n\t\t<tr><th>H11</th><th>HHH 222</th><th>H 3</th></tr>\n\t</thead>\t<tbody>\n\t\t<tr><td>AAA</td><td>BB</td><td>C C C C</td></tr>\n\t\t<tr><td>1 1</td><td>2 2 2 2</td><td>3 3</td></tr>\n\t</tbody>\n</table>\n\nasdf\n"
===> Testing [FAIL]: Pod::To::Markdown:ver<v.0.1.4>
Aborting due to test failure: Pod::To::Markdown:ver<v.0.1.4> (use --force-test to override)

Also, it's installing Gtk::Simple?

Shell injection through main-dir

Ddt/lib/Ddt/Distribution.pm6

Lines 190 to 194 in c611e9c

	method !init-vcs-repo {
	my $git-dir = $.main-dir.absolute;
	shell("cd $git-dir && git init", :out).out.slurp-rest;
	shell("cd $git-dir && git add .", :out).out.slurp-rest;
	}

↑ I don't know how dangerous that is, but I'd much rather not see shell being used there…

Change Description

The META description states this distribution is a "replacement for mi6". However, you're neither the author of mi6 nor is mi6 abandoned.

IMO such description is hostile and it's actively causing confusion for users of mi6.

Ddt is uninstallable because of dep on License::Software:ver<0.2.0>

Latest Ddt depends on License::Software:ver<0.2.0>. But License::Software does not have versioned entries in the ecosystem. So only the latest version (0.3.0) is available. This makes it impossible to install Ddt currently.

Test is failing

I am not sure, it is likely that this is a result of IO work, but however. Latest rakudo for today:

This is Rakudo version 2017.04.2-22-g9ed89d9 built on MoarVM version 2017.04
implementing Perl 6.c.

and my attempt to install goes like:

===> Searching for: Ddt
===> Searching for missing dependencies: JSON::Pretty, License::Software
===> Testing: JSON::Pretty:ver('0.1.0'):auth('github:FROGGS')
t/04-roundtrip.t .. ok   
All tests successful.
Files=1, Tests=17,  3 wallclock secs
Result: PASS
===> Testing [OK] for JSON::Pretty:ver('0.1.0'):auth('github:FROGGS')
===> Testing: License::Software:ver('0.1.0'):auth('kalkin')
t/01-basic.t ...... ok 
t/10-gplv3.t ...... ok  
t/11-Apache2.t .... ok  
t/12-LGPLv3.t ..... ok 
t/13-AGPLv3.t ..... ok  
t/14-Artistic2.t .. ok 
All tests successful.
Files=6, Tests=50,  10 wallclock secs
Result: PASS
===> Testing [OK] for License::Software:ver('0.1.0'):auth('kalkin')
===> Testing: Ddt:ver('0.4.0'):auth('kalkin')
t/01-basic.t .......... ok 
Failed to change the working directory to '/tmp/TYeBjKF5fD/Foo-Bar': does not exist
  in block <unit> at t/02-generate-test.t line 12

Actually thrown at:
  in block <unit> at t/02-generate-test.t line 12

t/02-generate-test.t .. All 1 subtests passed 
t/030-my-meta.t ....... ok 
All tests successful.

Test Summary Report
-------------------
t/02-generate-test.t (Wstat: 0 Tests: 0 Failed: 0)
  Parse errors: Bad plan.  You planned 1 tests but ran 0.
Files=3, Tests=2,  21 wallclock secs
Result: FAILED
===> Testing [FAIL]: Ddt:ver('0.4.0'):auth('kalkin')