kalpan-jasani/fetch

Bookmarking on steroids, you can save your own articles for a personally curated collection of articles that you can read later

fetch's Issues

images not being loaded in users

When users is clicked, only some of the profiles have images. Others, which are known to have images, don't have images.

boards don't allow marking as private

Personal boards have a unlock icon but that is not clickable.

extension displays added

Extension displays "Added!" even when no board is selected, where did it add?

this is a demo task

homepage activity bar not on right side

If user doesn't have enough content to fill main home screen, the ActivityBar is not at the right hand side

homepage resets dialogue

In homepage, clicking on a board that is not the recent most board closes the dialogue and moves the board to the first position in the recent boards.

Probably need to add key attribute to all the boards.

blocked article still displays hollow card

When a community article is blocked, the article won't display but the card containing the article will still display, making it seem like an empty card.
Can change it later

user access in firebase

Only allow logged in user's data to be seen by the logged in user. Need to set up rules in Firebase Cloud Firestor here: https://console.firebase.google.com/project/fetch-c97bc/database/firestore/rules

error in clicking on personal board

When clicking on a personal board from the boards list. This is because boards are not unsubscribed in compoentDidUnmount

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in PersonalBoards (at App.js:84)
console.<computed> @ index.js:1
r @ react_devtools_backend.js:6
warningWithoutStack @ react-dom.development.js:530
warnAboutUpdateOnUnmountedFiberInDEV @ react-dom.development.js:25738
scheduleUpdateOnFiber @ react-dom.development.js:23679
enqueueSetState @ react-dom.development.js:13994
push../node_modules/react/cjs/react.development.js.Component.setState @ react.development.js:325
(anonymous) @ PersonalBoards.js:70
next @ index.cjs.js:22426
(anonymous) @ index.cjs.js:20155
setTimeout (async)
AsyncObserver.scheduleEvent @ index.cjs.js:20153
AsyncObserver.next @ index.cjs.js:20142
QueryListener.onViewSnapshot @ index.cjs.js:17038
EventManager.onWatchChange @ index.cjs.js:16935
(anonymous) @ index.cjs.js:18408
step @ tslib.es6.js:99
(anonymous) @ tslib.es6.js:80
fulfilled @ tslib.es6.js:70
Promise.then (async)
step @ tslib.es6.js:72
(anonymous) @ tslib.es6.js:73
__awaiter @ tslib.es6.js:69
SyncEngine.emitNewSnapsAndNotifyLocalStore @ index.cjs.js:18364
(anonymous) @ index.cjs.js:17940
step @ tslib.es6.js:99
(anonymous) @ tslib.es6.js:80
fulfilled @ tslib.es6.js:70
Promise.then (async)
step @ tslib.es6.js:72
(anonymous) @ tslib.es6.js:73
__awaiter @ tslib.es6.js:69
SyncEngine.write @ index.cjs.js:17929
(anonymous) @ index.cjs.js:20065
(anonymous) @ index.cjs.js:1698
Promise.then (async)
AsyncQueue.enqueueInternal @ index.cjs.js:1696
AsyncQueue.enqueue @ index.cjs.js:1692
AsyncQueue.enqueueAndForget @ index.cjs.js:1639
FirestoreClient.write @ index.cjs.js:20064
DocumentReference.update @ index.cjs.js:21855
(anonymous) @ personalBoard.js:92
commitHookEffectList @ react-dom.development.js:22030
commitPassiveHookEffects @ react-dom.development.js:22064
callCallback @ react-dom.development.js:336
invokeGuardedCallbackDev @ react-dom.development.js:385
invokeGuardedCallback @ react-dom.development.js:440
flushPassiveEffectsImpl @ react-dom.development.js:25392
unstable_runWithPriority @ scheduler.development.js:697
runWithPriority$2 @ react-dom.development.js:12149
flushPassiveEffects @ react-dom.development.js:25361
(anonymous) @ react-dom.development.js:25240
workLoop @ scheduler.development.js:641
flushWork @ scheduler.development.js:596
performWorkUntilDeadline @ scheduler.development.js:203

comments fail for some users

go to this board and click on efe article:
http://localhost:3000/#/community-boards/0rCXTnmo4x3RmtQ0Pb6o

TypeError: Cannot read property 'split' of null
CommentSection.getFirstName
src/CommentSection.js:73
  70 | }
  71 | 
  72 | getFirstName = (string) => {
> 73 |     var split = string.split(' ');
     | ^  74 |     if (split.length > 1) {
  75 |         return split[0];
  76 |     }
View compiled
(anonymous function)
src/CommentSection.js:101
   98 |     ? <Avatar>{this.getInitials(data.name)}</Avatar>
   99 |     : <Avatar src={data.photoURL} alt=""/>}
  100 | <div style={{width: 5}} />
> 101 | <Typography
      | ^  102 |     style={{fontWeight: 500}}
  103 | >
  104 |     {`${this.getFirstName(data.name)}: `}
View compiled
CommentSection.render
src/CommentSection.js:91
  88 |     Comments
  89 | </Typography>
  90 | <div style={{height: 10}}/>
> 91 | <div style={{flexGrow: 1}}>
     | ^  92 | {this.state.documents.map((comment) => {
  93 |     var data = comment.data();
  94 |     return (

chrome extension shows more boards

Chrome extension displays more boards because older stale boards do not have timestamp field and are not showin web app, but would be shown in the dropdown for Chrome extension

check github deployment

Inside GitHub, a particular branch can be chosen to be deployed whenever changes are pushed to it. Then, the website can be deployed and new changes can be seen by everybody, including the TA