kalvinpearce/seorsum

Lightweight state management, designed to be used in conjunction with react but more separate than react-redux.

Hey! I'm Kalvin

I am a software developer working at @SpatialMedia on high detail interactive applications.

For work I mainly use Unity but in my spare time I am always trying out new things and experimenting with various technologies. I am currently really enjoying playing with Rust 😄

What I usually use

seorsum's Issues

Typescript update breaks useStateValue typings

I am trying to update deps to fix audit issues.

When updating with npm audit fix --force it updated jest which resulted in a bunce of new errors. tsc was checking files inside node_modules so I found a potential solution was to use skipLibChecks: true in the tsconfig.json. However this fix needed typescript to be upgraded to >=3.7.3. When upgrading typescript to anything over 3.7.2 it breaks the following code, specifically line 100: statePath

seorsum/src/index.ts

Lines 93 to 103 in 6c8ce7c

	const useStateValue = <PPath extends Path<S, PPath>, S extends State = State>(
	statePath: PPath,
	) => {
	const [value, setValue] = React.useState(
	getFromPath<S, PPath>(state as S, statePath),
	);
	React.useEffect(() => {
	return subscribe(statePath, setValue);
	}, []);
	return value;
	};

Rework subscribe function to add more typesafety

Need to look into if theres a better way of subscribing to state pieces. At the moment there is little safety around what gets put in the stateValue param. Would be good to rework to make it more typesafe if possible?

This would remove the need for branching statement and broken subscribes.

seorsum/src/index.ts

Lines 44 to 60 in 446d28f

	const subscribe = <T>(
	stateValue: (state: State) => T,
	callback: (state: T) => void,
	) => {
	// Little messy way of grabbing the state path from the params
	const res = stateValue.toString().match(/\.(.*);/);
	// This should always pass but is needed for intellisense
	if (res && res.length > 1) {
	const key = res[1];
	const fn = () => callback(stateValue(state));
	// Add to event bus
	bus.addListener(key, fn);
	// Return function to remove from event bus
	return () => {
	bus.removeListener(key, fn);
	};
	}