kamil-bednarek/errsy

ERRSY - Symfony3 error catcher application

errsy's Issues

[Insight] User specific files should not appear in .gitignore - in .gitignore, line 22

in .gitignore, line 22

.idea/ is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

!var/SymfonyRequirements.php
/vendor/
/web/bundles/
/bower_components/
/node_modules/
.idea/
/web/assets-dev/vendor/*
!/web/assets-dev/vendor/.gitkeep
/web/assets-built/*
!/web/assets-built/.gitkeep
.DS_Store

---

Posted from SensioLabsInsight

[Insight] Default favicon should be changed - in web/favicon.ico, line 0

in web/favicon.ico

Default default HiDPI Symfony favicon found.
This reveals the backend engine of the application and makes it more vulnerable to attackers. Consider using a custom favicon instead - plus, your users will memorize your application more easily.

---

Posted from SensioLabsInsight

[Insight] Text files should end with a newline character - in app/config/parameters.yml.dist, line 23

in app/config/parameters.yml.dist, line 23

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

    # A secret key that's used to generate certain security-related tokens
    secret:            ThisTokenIsNotSoSecretChangeIt
    elasticsearch.connections:
        - '172.20.0.11:9200'
        - '172.20.0.10:9200'
    elasticsearch.index: error_retention

---

Posted from SensioLabsInsight

[Insight] Twig templates should not contain business logic - in app/Resources/…/default/detail.html.twig, line 0

in app/Resources/views/default/detail.html.twig

Template too complex, depth of 15 is reached but only 5 is allowed.

---

Posted from SensioLabsInsight

[Insight] Text files should end with a newline character - in app/config/routing.yml, line 9

in app/config/routing.yml, line 9

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

    type:     annotation

# Api endpoint routing
ongr_api_routing:
    resource: "@ONGRApiBundle/Resources/config/routing.yml"
    prefix: /api

---

Posted from SensioLabsInsight

[Insight] The composer.json file should not raise warnings - in composer.json, line 0

in composer.json

Defining autoload.psr-4 with an empty namespace prefix is a bad idea for performance

---

Posted from SensioLabsInsight

[Insight] Text files should end with a newline character - in app/config/services.yml, line 27

in app/config/services.yml, line 27

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

#    ongr_filter_manager:
#        cache:
#            engine: 'es.cache_engine' # cache engine, set null to disable caching
#            life_time: 1080 # cache life time in seconds, 3 hours default
#            exclude:
#                - search

---

Posted from SensioLabsInsight

[Insight] Commented code should not be committed - in web/app.php, line 13

in web/app.php, line 13

Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.

$loader = require __DIR__.'/../app/autoload.php';
include_once __DIR__.'/../var/bootstrap.php.cache';

$kernel = new AppKernel('prod', false);
$kernel->loadClassCache();
//$kernel = new AppCache($kernel);

// When using the HttpCache, you need to call the method in your front controller instead of relying on the configuration parameter
//Request::enableHttpMethodParameterOverride();
$request = Request::createFromGlobals();
$response = $kernel->handle($request);

---

Posted from SensioLabsInsight

[Insight] Commented code should not be committed - in web/app.php, line 16

in web/app.php, line 16

Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.

$kernel = new AppKernel('prod', false);
$kernel->loadClassCache();
//$kernel = new AppCache($kernel);

// When using the HttpCache, you need to call the method in your front controller instead of relying on the configuration parameter
//Request::enableHttpMethodParameterOverride();
$request = Request::createFromGlobals();
$response = $kernel->handle($request);
$response->send();
$kernel->terminate($request, $response);

---

Posted from SensioLabsInsight

[Insight] Default favicon should be changed - in web/apple-touch-icon.png, line 0

in web/apple-touch-icon.png

Default Apple touch Symfony favicon found.
This reveals the backend engine of the application and makes it more vulnerable to attackers. Consider using a custom favicon instead - plus, your users will memorize your application more easily.

---

Posted from SensioLabsInsight

[Insight] The composer.json file should be valid - in composer.json, line 1

in composer.json, line 1

description : The property description is required

{
    "name": "kbednarek/error",
    "license": "proprietary",
    "type": "project",
    "autoload": {
        "psr-4": {

---

Posted from SensioLabsInsight

[Insight] A route should always have a valid HTTP method

The route "details" should have a routing method (GET/POST/PUT). It is mandatory.

---

Posted from SensioLabsInsight

[Insight] User specific files should not appear in .gitignore - in .gitignore, line 27

in .gitignore, line 27

.DS_Store is user-specific and should not appear in a project .gitignore. Consider adding it to the user global .gitignore instead.

.idea/
/web/assets-dev/vendor/*
!/web/assets-dev/vendor/.gitkeep
/web/assets-built/*
!/web/assets-built/.gitkeep
.DS_Store
web/uploads/google/feeds
web/uploads/avatars
web/uploads/banners
!web/uploads/banners/.gitkeep
web/media/cache

---

Posted from SensioLabsInsight

[Insight] .htaccess should be avoided - in web/.htaccess, line 0

in web/.htaccess

A .htaccess file has been spotted. You should consider moving it to the server configuration to improve global performances.

---

Posted from SensioLabsInsight

[Insight] Symfony applications should not contain a config.php file - in web, line 0

in web

This config.php file should only be used to bootstrap a Symfony application. Before releasing to production, you should remove it, otherwise attackers could get valuable insight about your application.

web/
├── app.php
├── app_dev.php
├── apple-touch-icon.png
├── config.php
├── favicon.ico
└── robots.txt

---

Posted from SensioLabsInsight

[Insight] .htaccess should be avoided - in src/.htaccess, line 0

in src/.htaccess

A .htaccess file has been spotted. You should consider moving it to the server configuration to improve global performances.

---

Posted from SensioLabsInsight

[Insight] .htaccess should be avoided - in app/.htaccess, line 0

in app/.htaccess

A .htaccess file has been spotted. You should consider moving it to the server configuration to improve global performances.

---

Posted from SensioLabsInsight

[Insight] Default session cookie's name should be changed.

The session cookie name is the default one, PHPSESSID. You should consider overwriting it thanks to session.name parameter (see the official documentation).

---

Posted from SensioLabsInsight

[Insight] Symfony secret should be changed

The secret is the default one from the Symfony Standard Edition

---

Posted from SensioLabsInsight

[Insight] A route should always have a valid HTTP method

The route "homepage" should have a routing method (GET/POST/PUT). It is mandatory.

---

Posted from SensioLabsInsight