kamilaalv/gardenofeden

:blossom: :rose: Java Flower Shop with Management features

gardenofeden's Issues

Is expired

DO NOT IMPLEMENT THIS

Items would need a boolean expired
Getter isExpired

It will be set automatically according to the date from the database

For now, we just need to add it

Do not add it to parameter lists of constructors

Renaming Stuff according to conventions

https://cdn.ttgtmedia.com/rms/onlineimages/naming_conventions_in_java-f.png

pay attention to package and finals namings

Assign Item Ids automatically

We need a method in some common interface(which needs to be created) to assign ids.

Ids for flowers, jewelry, and bouquets must be differentiable somehow (for example flower 0 - 100, bouquet 100 - 200, jewelry 200 - 300)
This is just an example in reality we would need more ids for flowers than for bouquets cuz bouquets consist of flowers.

U can add some constants in the options class for max num of ids for each type.
Also, u would need to keep track of the last id for each type

Ids should be reusable if u reached max, start from zero.

Constructors should be changed:

1. Ids in parameter lists should be deleted.
2. Call the method to assign id

Ps. Bouquets do not have ids in our implementation but I think we might need them for orders in the future. This is debatable. But we definitely need to assign ids for all items.

Suggestions

//THESE ARE JUST SUGGESTIONS

Bouquet
1.No need to keep track of wrapping paper colors in the bouquet (I have them in ItemOptions)
2. No need for separate prices for each color
3. What is BouquetsCreated (Is its purpose keeping track of the same bouquets in one cart or?)(same questions for the similar fields)

Suugestion 2

fakeorReal() method in flower jewelry is meaningless

Future

Item System should be used as a class for the Cart