kanake10/cocktails

Mobile App to show various cocktails🍸 🍷 🍹 from the CockTailDB .Written using Kotlin, Clean Architecture ,MVVM, Room ,Koin for DI and other jetpack libraries.

cocktails's Issues

create Spotless Pre-Commit hook

//rough example

task createSpotlessPreCommitHook() {
def gitHooksDirectory = new File("$project.rootDir/.git/hooks/")
if (!gitHooksDirectory.exists()) gitHooksDirectory.mkdirs()
new File("$project.rootDir/.git/hooks", "pre-commit").text = """
#!/bin/bash
echo "Running spotless check"
./gradlew spotlessApply
"""
"chmod +x .git/hooks/pre-commit".execute()
}

Fix cocktail item uneven spacing

Fix item uneven spacing for all devices

Migrate to use the splash screen API

Currently the app shows a white screen on loading, for general aestethics let's move to the new SplashScreen API!

Resources:
https://developer.android.com/guide/topics/ui/splash-screen

Fix lingering collapsing app bar layout

The collapsing appbar layout still leaves a purple space at the top

Migrate from RecyclerViewAdapter to ListAdapter

Migrate the following class from recycleview adapter to list adapter.

Resources:
https://developer.android.com/reference/kotlin/androidx/recyclerview/widget/ListAdapter

Fix App crash if the user's network is off and no cached cocktails.

The app will crash if the user's network is off and if there are no cached cocktails. In this case, it will be on first start.

Enable a user to save some of their favorite cocktails

This is for future references

Convert to real offline first

Data should only be fetched from the cache. if the network/internet is available, the cached data should be deleted and updated with data from the api call.