Comments (3)
@Arcainne while I do agree that your modifies suppress the problem at hand, I wonder how much of the code of aura.js shoud actually be executed playerside. From what I can understand of the actual code CollateAuras/MainAura are the core methods that compute everything both are bound to be executed only on the gm machine (line 321 and 405).
The code hooked on updateToken, for example, relies on what has been computed gmside in CollateAuras but will execute playerside against an empty AuraMap, thus the error.
Is it possible that all hooks should be gm only?
Are the current gm-only guards a bit too deep in the execution and could be moved up at hooks level?
I'm not nearly familiar enough with Foundry+ActiveAuras inner working so please take my suggestion with a grain of salt
from active-auras.
Yeah this is a good note, will be fixed soon
from active-auras.
I resolved this locally by adding optional chaining to a few places in aura.js
to make sure nothing is being called on an undefined
object,
Before
aura.js:311: if (!MapObject.effects) return;
aura.js:383: MapObject.effects.forEach(i => EffectsArray.push(i.data.origin))
aura.js:502: let checkEffects = MapObject.effects;
After
aura.js:311: if (!MapObject?.effects) return false;
aura.js:383: MapObject?.effects.forEach(i => EffectsArray.push(i.data.origin))
aura.js:502: let checkEffects = MapObject?.effects ?? [];
from active-auras.
Related Issues (20)
- AA on items aren't applied to other characters HOT 2
- Console error on token movement HOT 1
- [Feature Request] Aura only applies if certain conditions or status effects are present HOT 5
- Space vs hyphen in name in FVTT package directory HOT 1
- script attempts to change the value of a getter HOT 3
- Effect that ignore self does not work HOT 2
- [SWADE] Weird aura display issues HOT 1
- Aura effects aren't applied HOT 5
- [BUG] When token is updated that exists on a different scene, module throws error HOT 4
- "Auras in combat" setting has wrong default value
- Condition Check Improvement: Origininating Actor data HOT 1
- Aura applies to tokens multiple times
- Auras are not propagated HOT 1
- Where is the Apply while inactive option? HOT 2
- [BUG] Ignore Self Applying to Self HOT 6
- [Suggestion] Adding an option to display a faint ring on the edge of an aura. HOT 1
- Add creature subtypes to the type of creature option HOT 3
- ERROR CAUGHT in RemoveActiveEffects Error: Undefined id does not exist in embeddedCollection collection HOT 2
- Adding a placeholder token in the combat tracker can lead to TypeError Undefined when reading document in AAHooks.mjs:51
- Minor Incompatibility with Effect Macro and Active Token Effects HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from active-auras.