kashishkhullar/pos-blockchain

Hi 👋, I'm Kashish Khullar

• 🌱 I’m currently looking for full time roles.

• 👨‍💻 Read more about me on LinkedIn: https://www.linkedin.com/in/kashishkh/

• 📝 I publish articles on Medium: https://medium.com/@kashishkhullar

• 💬 Ask me about 42

• 📫 How to reach me [email protected]

Blogs posts

• Implementing Merkle Tree and Patricia Trie
• Implementing PBFT in Blockchain
• Insolar Blockchain Use Cases
• Implementing Proof of Stake Part — 5

Connect with me:

pos-blockchain's Issues

Missing call to executeTransactions()

pos-blockchain/blockchain/blockchain.js

Line 22 in 2e7ee09

console.log("NEW BLOCK ADDED");

Before this function returns, it should call this.executeTransactions(block);. This way the accounts are updated.

Btw, you wrote an excellent tutorial! It's really appreciated.

Cheers!

Fixed wallet amount

Thanks for great sample.
Small question, when I follow instruction, for some reason amount after transaction don't change. Seems like don't call any wallet method. Any suggestion?
Thanks

How to initiate the system?

please could provide more steps in details ? I didn't know what to do after running the nodes?

False Transactions Checking

Is there any checking for false transactions?

i.e. if a user generated a legitimate key pair, then signs a fraudulent transactions transferring 10,000 currency to a secondary address (controlled by the attacker) what stops this being mined to the blockchain as legitimate given the signature and balance outputs for this transaction can be verified as correct

Transactions and balance

Thanks for the medium tutorial. I've been searching through this project for awhile but can't seem to find the issue. Starting the nodes results in "Recieved chain is not longer than the current chain", and sending transactions appear to go through on the console but balances are never updated, nor are new blocks created. @kashishkhullar

Weird blockchain, no more then 1 block..

Hi!

The Blockchain is very weird..

I dropped the Threshold at 2
I've sent twice 11 coins to 2 nodes

The block is rewritten into its data, so each block has 2 hashes and last hash, the same validator twice and 2 signatures..

Yes I know, see file joined : Results.txt

Balances of accounts arent incremented/decremented as well..

Twying to find out where the bug is from, it looks like it's during the block is pushed into the chain, before this the chain and the block look legit..

Also, can't send another transaction after that, all nodes crashes..

Found first the totorial, then corrected with the files, got the issues so I cloned the folder : same thing!

Any hint?

Thanks!

Stake.getMax() might be missing something

pos-blockchain/blockchain/stake.js

Line 47 in 2e7ee09

if (this.getBalance(address) > balance) {

I think this:

 getMax(addresses) {
    let balance = -1;
    let leader = undefined;
    addresses.forEach(address => {
      if (this.getBalance(address) > balance) {
        leader = address;
      }
    });
    return leader;
  }

Should actually be:

 getMax(addresses) {
    let balance = -1;
    let leader = undefined;
    addresses.forEach(address => {
      let address_balance = this.getBalance(address);
      if (address_balance > balance) {
        leader = address;
        balance = address_balance;
      }
    });
    return leader;
  }

Otherwise getMax will just return the last address that has a balance greater than -1.