Giter Site home page Giter Site logo

animatoraccess's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

animatoraccess's Issues

Animator Access namespace

Currently the generate AnimatorAccess has a default namespace which generates warning if the file isn't in the corresponding directory. I think you could very easily determine the correct namespace by the directory the user chose to save the generate file.
Also it has an unused "using System.Collections;".

calling AnyState (0) without adding onChange event would cause exception

Unlike transition handlers, state's onChange handler is not null checked.
Because of this, calling AnyState (0) without adding onChange event causes null reference exception.
It might look trivial, but this also happens when removing the registered onChange handler.
I made a small pull request - hope you like it this time too :)

Inconsistent line endings in generated code (windows)

I use Windows and get an inconsistent line endings on my generated AnimatorAccess class.
I checked the template for windows (DefaultTemplate-Win.txt) and it also contains inconsistent line endings, so I think it's the cause.

If anyState->otherState exists, AbstractTransitionHandler.GetTransitionInfo returns null

If anyState->otherState exists, AbstractTransitionHandler.GetTransitionInfo returns null with "No transition info found for transition" warning message. Thats because generated "InitialiseEventManager" method does not add anyState based transitions.
To handle these transitions, we need to handle this case separately.

I created a pull request, hope you like it. :)

Anyway its really an interesting idea and works well. I think its essential until unity5 is up.

Support for substates

Hey,
I realized now that there is no support for states that are substates.
How difficult would it be to support them?

Example:
AnimatorAccess.State(AnimatorAccess.stateIdSomSubState); //Cannot find such stateId.

Constantly using memory in the update iterations

Hi, its been a while since I last reported little issues.
Due to your help and many authors nice libraries' big help, my project is progressing daily.

Today I found a memory related problem. In animator access generated code, it looks like CheckForAnimatorStateChanges routine is constantly allocating memories. It might look trivial, but its done per frame - which need to be avoided if possible... As you know this can lead to frequent GC call..;

I don't know if you are still managing this project, but as a duty of users, reporting this issue :D
I attached an image for you, so you can easily identify the issue.

screen shot 2015-01-10 at 10 57 39 pm

Let me know if you can handle this problem. Thank you !!

Animation Duration Feature

It would be nice to have access to the animation duration and current time in the animator state. e.g:
anim.state(anim.stateIdIdle).Duration
anim.state(anim.stateIdIdle).CurrentTime //not sure about the name, but what I mean is the time passed since the animation started (CurrentTime <= Duration).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.