kb1dds/pysheaf

Python Cellular Sheaf Library

pysheaf's Issues

For `Sheaf.FuseAssignment()`, assignments can only be numpy vectors

Arrays that are numpy.ndarrays are fine elsewhere, but when you run Sheaf.FuseAssignment() with the default optimizer, it crashes. The default optimizer's wrapper should probably resolve this internally by flattening all arrays into vectors (and rebuilding restriction maps accordingly) before passing to the optimizer.

Please include links to videos and papers in the README

It would be very helpful. For example:

Robinson, Michael. "Sheaves are the canonical data structure for sensor integration." Information Fusion 36 (2017): 208-224.

Documentation is wildly out of date

(name says it all!)

analysisTools.LocallyFuseAssignment() gives bogus results

The Problem is that cells outside of the open set can still flow values into the open set (on its boundary) that make the various problems not independent.

This should actually be a phantom problem if a value is specified with optimization=False on the boundary, because then we don't actually have a choice for a different value there.

I tried to resolve this using Views of the Sheaf, but that seems to give strange results.

• Worst case is to deep copy the sheaf on the open set, and run it on its own
• Best case is to fix the Views... because cells outside the View should not get referenced -- and therefore not flow any values forward
• Might be able to add another knob on how the consistency radius gets computed

No (obvious) licensing information for PySheaf

I can't immediately find licensing information for PySheaf.

I recommend adding a LICENSE or LICENSE.txt file to the root directory. If you're feeling extra motivated, you can also mention the license in the README.rst and in docs/index.rst.

Do you have a specific license in mind? If not, you can peruse the "main" open source licensing options here: https://opensource.org/licenses (or a more comprehensive list here: https://opensource.org/licenses/alphabetical ).

Coface attribute in Cell causing duplicates

I replaced the Cell class constructor with:

    def __init__(self,dimension,compactClosure=True,cofaces=None, name=None):
        self.dimension=dimension
        self.compactClosure=compactClosure
        if cofaces != None:
            self.cofaces = cofaces
        else:
            self.cofaces = []
        self.name = name

The empty list in the original constructor linked the coface list of all the cells together if the cofaces were added after the cells were instantiated.

Module analysisTools imports local module dataTools incorrectly

We're having issues importing the pysheaf.analysisTools module because the module imports pysheaf.dataTools by simply saying import dataTools:

pysheaf/pysheaf/analysisTools.py

Line 25 in 23002b2

import dataTools

That works within the module since the file is local, but external programs that try to import pysheaf.analysisTools can't resolve this import of dataTools, since they don't know where the module lives.

The fix should be just replacing import dataTools with from . import dataTools in analysisTools.py.

We tested this fix locally and that resolved the issue -- import pysheaf.analysisTools worked as expected in our external program.