kbranigan/simple-opengl-image-library

Simple image uploader primarily for OpenGL

simple-opengl-image-library's Issues

Usage of deprecated glGetString( GL_EXTENSIONS )

http://stackoverflow.com/questions/17923782/simple-opengl-image-library-soil-uses-deprecated-functionality

https://www.opengl.org/sdk/docs/man3/xhtml/glGetString.xml

GL_EXTENSIONS has been deprecated as a paremeter to glGetString. All calls to glGetString( GL_EXTENSIONS ) fail under OpenGL 3+ with error GL_INVALID_ENUM. This breaks all query_x_capability functions... which breaks most of SOIL.

Apparently, the correct approach is now to iterate over and compare each extension substring using glGetStringi( GL_EXTENSIONS, i ).

SOIL uses const char* instead of const wchar_t*

SOIL only supports narrow strings when loading images, but it should accept wide strings to allow for filenames with different characters than just English. Thanks.

Android support

It looks like archSeer has added Android support in these commits:
0ecd166
d64998d
9ff5f11

Would you be interested in merging those changes in? I'll do a pull request if that's easier.

Load image from disk to pre-allocated buffer

Hi, I am using SOIL(great lib by the way, big thumb up) to load images into memory, but from that point on I handle all my stuff manually. I am also doing memory handling myself with stack allocators etc. At this point I would love to be able to tell SOIL to read memory in my given pre-allocated cpu buffer.
This is due to avoid an extra copy from "SOIL memory" to my preallocated memory.
Of course I don't think this is particularly simple task, mainly because I might not know upfront the size of the image so my questions are the following:
I don't know much about image storage format, but do images have their size in the header? that can be queried fairly cheaply, to let me allocate the buffer and then have SOIL write in my memory?

Would you be up for a discussion about that? If so I would like to help on the matter.
Just bear in mind I am here mainly for a discussion of the topic, is not a feature request, loading texture happens async and doesn't happen on a frame bases so is not really a critical path of the code, and I can totally live with the extra copy, that s why I would like to see if you think is something that might be useful, and if so how much work you think it can be.

Cheers

M.

stb_image might not be thread safe

I am currently hitting what it looks like some kind of race condition inside stbi_load. basically at random a deep assertion gets fired inside stbi_load, I bypassed soil and used the latest stb_image.h file and the problem looks like is gone. might be worth to update the implementation? also right now it is just an header file, should not be much of an issue?

M.

Do not use CXX

In

Simple-OpenGL-Image-Library/Makefile

Line 16 in 4fff135

CXX = gcc

and in Makefile:

Simple-OpenGL-Image-Library/Makefile

Line 42 in 4fff135

$(CXX) $(CXXFLAGS) -o $@ -c $<

CXX is for g++ should be CC and CFLAGS and better to use ?=

This can conflict when doing make CXX=g++