kdavies4/fcsys

Modelica fuel cell library

fcsys's Issues

Library does not parse using the Modelica grammar

I forked the library, trying to fix some minor issues with the parsing, but when doing so I found some bigger problems.
The library uses the structure {1,2,3}[i] a lot. But this is not allowed in the Modelica grammar. You have to write code like index({1,2,3},i) (with a new index function for each type). Or restructure the code (probably preferred).

Missing file WorkInProgress.mo

WorkInProgress.mo is missing from the package, or possibly has been left in the package.order even though it should not:

[/var/lib/hudson/slave/workspace/OpenModelica_UPDATE_LIBRARIES/build/FCSys 0.1/package.mo:2:1-1299:10:writable] Error: WorkInProgress was referenced in the package.order file, but was not found in package.mo, WorkInProgress/package.mo or WorkInProgress.mo.

Modelica class links not correct in HTML documentation

It looks like that the generated HTML files contain erroneous class links which are specific to your machine of generation rather than relative and universal.

Example:
"Modelica media library" on http://kdavies4.github.io/FCSys/ points to file:///C:/Program%20Files%20(x86)/Dymola%202014/Modelica/Library/Modelica%203.2.1/help/Modelica_Media.html#Modelica.Media

Solution:
a. use OpenModelica instead of Dymola to generate the help
b. figure out what to tweak in order to get Dymola to generate the links correctly.

HTML errors in documentation.

There are still loads of issues with the HTML documentation (most likely introduced by earlier Dymola versions). See https://build.openmodelica.org/Documentation/tidy.filtered and search for FCSys

As a tip (if you must use Dymola for editing HTML), starting from Dymola2014 FD01 the HTML editor has been fixed. Not sure if that would rewrite existing non valid HTML code when editing it.

Update sample plots

version number and folder name don't match

I noticed that the version annotation is at 0.2.3 but the folder is still called "FCSys 0.2". This should be corrected to "FCSys 0.2.3" and upwards for the future in order to be according to the specification.

Broken symbolic links

There are broken symlinks in the library (and symlinks are bad if Windows users want to use the library anyway)

$ find git/FCSys -type l -xtype l
git/FCSys/FCSys/Resources/Source/Python/doc/py-modindex.html
git/FCSys/FCSys/Resources/Source/Python/doc/objects.inv
git/FCSys/FCSys/Resources/Source/Python/doc/_images
git/FCSys/FCSys/Resources/Source/Python/doc/search.html
git/FCSys/FCSys/Resources/Source/Python/doc/.modelica.pws
git/FCSys/FCSys/Resources/Source/Python/doc/index.html
git/FCSys/FCSys/Resources/Source/Python/doc/searchindex.js
git/FCSys/FCSys/Resources/Source/Python/doc/genindex.html

Items marked with "TODO" in the *.mo files

Address these. They can be listed using "00-list-WIP.sh".

FCSys on Openmodelica

Hi, i'am yahia, i'am working on openmodelica and i need the virtual FCS, so i would like to know in which version this library work in openmodelica ? actually i use the 1.18 version;
Thanks for your needs
have a good day.