keddelzz/hidden-args

Hide your accumulators from the public API

hidden-args's Issues

Change organization-name

Change it from com.github.keddelzz.hidden-args to com.github.keddelzz.

This change will also affect future releases of hidden-args. (Because we should also change the organization-name of the project on jcenter to be consistent with the changes in repo.)

Test moving annotations

In the scope of issue #15 the moving of annotations from the outer to the inner function was introduced, however I'm not sure how to unit-test this feature.

source code position for the test

Use maven project structure

Publish stable version of hidden-args somewhere accessible via sbt

We came across the following problem during our release process: morganey-lang/Morganey#271

We suspect that publishing a stable version of hidden-args somewhere could help us to resolve it easily. Is it possible to do that? Thanks!

Write README

Implement replacement of function call

Add examples

• Add example-subproject
• Build examples

Setup CI

Make name of nested function configurable

@hiddenargs("loop")
def sum(xs: List[Int], @hidden acc: Int = 0): Int = 
  xs match {
    case Nil => acc
    case hd :: tl => sum(tl, acc + hd)
  }

The annotation @hiddenargs could get an optional parameter, which represents the name of the inner function, thus the code snipped above would expand to

def sum(xs: List[Int], @hidden acc: Int = 0): Int = {
  def loop(xs: List[Int], acc: Int): Int = 
    xs match {
      case Nil => acc
      case hd :: tl => sum(tl, acc + hd)
    }

  loop(xs, 0)
}

.. instead of using the (synthetic) name sum_impl.

Migrate personal repo to JCenter

See PR #26 for a discussion about migrating.

Move 'tailrec' annotations to inner function

If a function is defined to be tailrec, the inner function should receive the tailrec annotation instead of the outer one, because after macro expansion the wrapper function isn't tailrec anymore.

For example:

@hiddenarg
@tailrec
def factorial(n: Int, @hidden acc: BigInt = BigInt(1)): BigInt = 
  if (n <= 0) acc
  else factorial(n - 1, BigInt(n) * acc)

Add "How to use" section in README

• macroparadise

Build project using SBT

Add tests

Support for multiple parameter lists and implicit arguments

I want to be able to write something like:

@hiddenargs
  def sum2[T: Numeric](xs: List[T], @hidden acc: T = implicitly[Numeric[T]].zero): T =
    xs match {
      case Nil      => acc
      case hd :: tl => sum(tl, implicitly[Numeric[T]].plus(acc, hd))
    }

Or maybe use the implicit parameter explicitly. For example:

@hiddenargs
  def sum[T](xs: List[T], @hidden acc: T = ev.zero)(implicit ev: Numeric[T]): T =
    xs match {
      case Nil      => acc
      case hd :: tl => sum(tl, ev.plus(hd, acc))
    }