Giter Site home page Giter Site logo

keepassxreboot / keepassxc Goto Github PK

View Code? Open in Web Editor NEW
19.3K 261.0 1.4K 64.93 MB

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.

Home Page: https://keepassxc.org/

License: Other

CMake 1.21% Shell 0.80% C++ 96.63% Python 0.06% Objective-C++ 0.24% C 0.68% JavaScript 0.01% Go 0.05% PowerShell 0.33%
keepassxc keepass password-manager linux windows cross-platform yubikey macos password security

keepassxc's People

Contributors

adolfogc avatar aetf avatar angelsl avatar ba32107 avatar blueice avatar c4rlo avatar colfenor avatar debfx avatar denk-mal avatar droidmonkey avatar francoisferrand avatar frostasm avatar hifi avatar jsoref avatar keithbennett avatar kylemanna avatar libklein avatar louib avatar phoerious avatar schlimmchen avatar seatedscribe avatar sorairolake avatar testpersonal avatar thez3ro avatar transifex-integration[bot] avatar varjolintu avatar vsvyatski avatar weslly avatar wolframroesler avatar xvallspl avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

keepassxc's Issues

Make password generator a standalone generator like KeePass

In KeePass you can generate passwords without creating a new password entry by going to the generator and generating one. This can even be done when the database is not unlocked (since no entry is being saved). I have found this to be a very useful feature

KeePass IOProtocolExt

Since there have support for HTTP (WebDAV?), would be a good addition to also have support for SFTP.

There is a plug-in for KeePass called IOProtocolExt what bring support to SCP (Secure CoPy) protocol, SFTP (SSH File Transfer Protocol) and FTPS (FTP over SSH).

Support for strong encryption is always desirable too.

Please, consider importing that plug-in.

Thank you.

The way currently the favicon downloading works, doesn't work with some websites.

Currently, for downloading the favicon of a website we are relying on Google by doing the following trick,

QString path = "http://www.google.com/s2/favicons?domain=" + url.host();

This though doesn't work with some websites, with packagist.org being such an example. For finding the favicon a typical web browser first checks the HTML code of the web page for one of the following tags,

<link rel="shortcut icon" href="http://example.com/myicon.ico">
<link rel="icon" type="image/vnd.microsoft.icon" href="http://example.com/image.ico">
<link rel="icon" type="image/x-icon" href="http://example.com/image.ico">
<link rel="icon" href="http://example.com/image.ico">
<link rel="icon" type="image/gif"  href="http://example.com/image.gif">
<link rel="icon" type="image/png" href="http://example.com/image.png">

If neither of those are being found, then the web browser checks if the file favicon.ico exists on the root of the website. So, to do it properly we first need to download the HTML code, parse it in order to find one or more of those tags, try to fetch the favicon based on them and if it is unsuccessful try to fetch the favicon.ico file from the root of the website.

If you agree with this I can take a look to see if I can implement this, so we can make the download of the favicon more robust and we won't have to rely on Google for something like that, which might actually stop working in the future and break that functionality of the application.
#30

CTRL-U (open URL) feature not working in Ubuntu 14.04 or 16.04 stock installs

Expected Behavior

Pressing CTRL-U should open a browser window with the currently highlighted entries URL

Current Behavior

Pressing CTRL-U has no visible effect / does not hing.
However, right clicking and using the drop-down menu option "Open URL" does work.

Your Environment

KeePassX 2.0.2
Ubuntu 16.04 LTS, w/ current updates
QT 5.5.1
libcrypt 1.6.5

Thanks!

Branch Strategy

Opening up a discussion on the branching strategy. My though is to maintain a git-flow-lite structure.

  • master -> always points to the last release published
  • develop -> points to the next planned release, tested and reviewed code
  • feature/[name] -> points to brand new feature in codebase
  • bugfix/[name] -> points to bugfix in the codebase

Brand new code will be vetted by the community, and also on several different platforms, prior to integration into the main baseline. At least one review from project maintainer is required to merge into develop.

PR merging rules:

  • If only one contributor, create a squash-merge commit from the PR
  • If multiple contributors, perform an interactive rebase to squash minor commits from the same author and perform one consolidated merge from develop to ensure consistency. Then perform a merge-commit.

Translation from Transifex

We need to make a new Transifex project for KeePassX Reboot, some new strings don't have translation right now.

Automatically Deploy Binaries from TravisCI to GitHub Release

Should be nice to have automatic build (for Linux/Mac) directly from TravisCI only when pushed to develop/master or only when a new tag is created

Expected Behavior

When committing a new tag, Travis will automatically build executables and push them on GitHub Release.

Current Behavior

Manual deployment

Possible Solution

Editing the .travis.yml file to deploy on Github Release
https://docs.travis-ci.com/user/deployment/releases/
With conditional deployment
https://docs.travis-ci.com/user/deployment#Conditional-Releases-with-on%3A

Support for single-window mode like KeePass

An option to force single window mode would be great. Currently, if keepass is opened while another instance is open there would be two instances. In single window mode it should just focus the currently open instance and not create another instance.

KeePassX v2.0.2 on Ubuntu 16.04 - no KeepassHTTP settings

I recently cloned the git repository, and ran through building the application on my computer. I can't seem to find the KeePassHTTP settings.

I don't think I made any errors in creating the application.

Revision: b654fde
KeePassX 2.0.2

If you require any more information, please let me know.

Database Merge

Should be nice to be able to automatically merge 2 or more password databases.

Use case: You have a KeePassX database on your PC and a database on your Phone, you "sync" them with Syncthing, Dropbox, whatever and you will lose changes on PC or Phone version so you need to keep both databases aside. With the Merge feature, you open both database on KeePassX and merge them so now you have all password in 1 file.

Feature: Add character-position numbered password view (monospace, rules)

A number of web sites -- e.g. banking, financial etc. -- don't outright request a password, but instead ask for a series of numbered characters from it.

It would be very useful to have a password view which allows this, e.g. using a monospaced font, ruler cells, and numbers for character positions. Then, at a glance, one can see what characters need to be entered to respond to the challenge.

Consistently name folders for testing stubs

Expected Behavior

All the application tests should be in the tests/ folder
Platform-dependent tests should be in test/ folder

Current Behavior

Some tests are not in the tests folder and behave feature-dependent and not platform-dependent
(like X11 Autotype)

Compile two separate binaries, one with http plugin and one without

For some people having networking capabilities extend the attack/vulnerability surface.

It would be nice if we can exclude networking code in the compiled executable
(also because keepasshttp don't have good support on Windows, See: https://groups.google.com/forum/#!topic/keepassx-reboot/yV__ujozMtI)
letting user (or disto-maintainer) decide if include keepasshttp or not in the executable

Note: by default keepasshttp is disabled at runtime

KeePassX compiled on macOS Sierra does not run due to missing platform plugin

The packages I build following these instructions seem to crash at startup.

I'm building with:

cmake .. -DWITH_TESTS=OFF -DCMAKE_PREFIX_PATH=/usr/local/Cellar/qt5/5.7.0/lib/cmake -DCMAKE_BUILD_TYPE=Release
make -j8
make package

Dependencies:

cmake-3.6.2
qt5-5.7.0
libgcrypt-1.7.3
libmicrohttpd-0.9.51

Crash log: https://gist.github.com/agunnerson-ibm/a5e22bbe773b1cc15431cf3850585ee9

Files included in KeePassX.app: https://gist.github.com/agunnerson-ibm/cff7af5c0a0cf7c11927b7e1b600668a

If I try to run /Applications/KeePassX.app/Contents/MacOS/KeePassX manually, I get the following:

This application failed to start because it could not find or load the Qt platform plugin "cocoa"
in "".

Reinstalling the application may fix this problem.
[1]    53014 abort      /Applications/KeePassX.app/Contents/MacOS/KeePassX

Hiding to systray on app-start shouldn't depend on app-exit

In the current state, the "Hide window to system tray on App start" option depends on enabling the "Hide window to system tray on App Exit" as mentioned in #57 (comment). As those are (in my understanding of them) completely unrelated actions, they should be made independent.

Expected Behavior

One should be allowed to enable the "Hide on App start" option even when the "Hide on App Exit" option is turned off.

Current Behavior

The "Hide on App Exit" option has to be turned on in order to enable the "Hide on App start" option.

Your Environment

  • KeePassXR version/commit used: develop branch
  • Qt version (e.g. Qt 5.3): 5.6.1
  • Operating System and version: GNU/Linux

Add {DELAY=n} functionality

The functionality in the below mentioned pull request from the original project is needed for many users as without delays many websites with JS hooks on input changes sometimes cause dropped characters.

This behaviour has been confirmed (see pull request thread).

#keepassx/keepassx#161

Note: I've also contacted the requester of this PR asking them to also do the PR here earlier today.

Binary or Installation Guide for MacOS Sierra

Hey!

I found this project today. I downloaded the sources and tried to compile a binary it with CMake but it didn't work (...I could pass QT5 to CMake but however not libgcrypt). Do you have a Step-by-Step Installation Guide or a binary for MacOS Sierra?

Thank you in advance.
andikade

Ask user before executing "cmd://" URLs

The option to override the URL for an entry is included in KeePass (Edit Entry > Properties > Override URL). An important use case for this feature is to ensure that bank websites are opened in a web browser that is used for banking only and has no extensions installed, which minimizes the attack surface.

Fix Travis-CI Build

The current build breaks due to libmicrohttpd being a very old version on ubuntu 14.04 (Travis-CI version). Currently investigating work arounds to this on travis-fixes branch.

Enhance interface by making search box always visible

Search box is NOT visible by default. Searching passwords is probably the most common task in keepassx. Why does it require an extra click to toggle the search? That is likely one of the most used interface features and it is hidden by default which creates unnecessary friction to use one of the most used aspects of the software.

Discussion: why not collaborate with KeePassX?

Is there some reason you were not able to collaborate with the original keepassx project? Forks typically have negative effects on a community (there are examples I can cite if asked).

Auto-lock is currently broken when in edit password screen

Currently auto-locking the database after X seconds does not work for the most common use-case. The reason is because when the database locks while a password entry is open a dialog will popup which prevents the actual locking.

To solve this there should only be a dialog box if there is an actual change to the database. And, in addition, there should be an option to auto-save the DB upon locking so that it can always lock correctly.

Unlocked tray icon

From: keepassx/keepassx#123

This PR brings back the feature from the old KeePassX release - database lock status indication via the system tray icon. Default application icon is used when all opened databases are unlocked, and special "locked" icon is used otherwise.

NOTE: The "locked" version of status icon was created only as a concept (I'm not a graphic designer what so ever). Also, I've not generated any PNG version of this icon

Create a new icon to represent KeePassX-Reboot

A new icon is needed to differentiate KeePassX from KeePassX-Reboot. Icon submissions are welcome, please post to this issue thread. Monochromatic / other styles are welcome for future theme-ing purposes.

Feature: Add support for basic references in autotype

In the source keypassx github, there is a pull request for adding some of the basic keepass references into autotype. Is it possible to get that PR merged into this fork?
keepassx/keepassx#184

Expected Behavior

On Amazon.ca, I should be able to autotype/fill from ChromeIPass the records from amazon.com, as the u/p combo is stored as {REF:U@I:AMAZON.COM_UUID} and {REF:P@I:AMAZON.COM_UUID}

Current Behavior

It sends the strings (ie: {REF:U@I:AMAZON.COM_UUID}) instead of the u/p specified in the amazon.com reference

Possible Solution

Copy the pull request from the keepassx github and merge it in

Context

Amazon.com and Amazon.ca both use the same credentials, but as they are using different URLs, they are seen as different sites to Keepass/KeepassX and ChromeIPass. Keepass on Windows manages this by allowing you to create 2+ separate entries, one containing the real values, the other containing a reference via UUID to the first one (http://keepass.info/help/base/fieldrefs.html).

Support for password generator profiles

In KeepPass you can create generator profiles which lets you define specific password features such as length, symbols, etc. When generating a password you can select the profile to automatically make a password like that. In KeePassX there is no generator profile so each password must be setup individually.

Enable configurable columns in the entries grid

There is no way to change the data shown in the password grid. I had view the last edited passwords and I had to download KeePass in order to view the last modified column and sort by it. It was impossible in KeepassX

Can't build from source in ubuntu 16 x64

hex@hex:/workbench/keepassx_http-2.0.2/src$ mkdir build
hex@hex:
/workbench/keepassx_http-2.0.2/src$ ls
autotype CMakeFiles core gui streams
build CMakeLists.txt crypto keys version.h.cmake
CMakeCache.txt config-keepassx.h.cmake format main.cpp
hex@hex:/workbench/keepassx_http-2.0.2/src$ cd build
hex@hex:
/workbench/keepassx_http-2.0.2/src/build$ cmake -DWITH_TESTS=OFF ..
qmake: could not exec '/usr/lib/x86_64-linux-gnu/qt4/bin/qmake': No such file or directory
CMake Error at /usr/share/cmake-3.5/Modules/FindQt4.cmake:1326 (message):
Found unsuitable Qt version "" from NOTFOUND, this code requires Qt 4.x
Call Stack (most recent call first):
CMakeLists.txt:151 (find_package)

-- Configuring incomplete, errors occurred!
See also "/home/hex/workbench/keepassx_http-2.0.2/src/CMakeFiles/CMakeOutput.log".

Feature Ideas from Long-Time Keepass user

These are issues with KeePassX that do not exist in KeePass. It would be wonderful if these issues were fixed in KeePass Rebooted. Most of them are probably fairly simple to fix:

  1. Auto-lock database is broken in KeePassX. There is the feature to lock database after X seconds, but it currently does not work. If you leave KeePassX open when inside of a password, then a dialog box will popup, which prevents the auto-close functionality. There is no reason for this dialog as long as there has been no changes to the DB which usually there is not.

  2. Single window mode. KeePass has a nice feature where if you try to open two instances it will just open your existing open instance for you.

  3. Search box is NOT visible by default. Searching passwords is probably the most common task in keepassx. Why does it require an extra click to toggle the search? That is likely one of the most used interface features and it is hidden!

  4. When searching and a group is clicked on it currently disables the search. It should instead follow normal user interface standards for about every web app and application which is to filter by the selected group. There is already a cancel search button.

  5. Configurable columns. There is no way to change the data shown in the password grid. I had view the last edited passwords and I had to download KeePass in order to view the last modified column and sort by it. It was impossible in Keepass

  6. Standalone password generator. In KeePass you can generate passwords without creating a new password entry by going to the generator and generating one. This is very useful.

Crash at startup on Mac OS 10.11.6

I've followed all instructions and got through the install process according to the wiki-page. Everything went well without any problems. When i try to open the App from /Applications by double clicking on the icon, an general-app-looking icon jumps on the dock, vanishes and then a window pops out telling me "KeePassXC closes unexpectedly"

Expected Behavior

The App to start

Current Behavior

Mac Error Dialog pops up

Error report

Gist crash report

Your Environment

  • KeePassXR version/commit used:
  • Qt version (e.g. Qt 5.3): 5.7.0
  • Compiler (e.g. Clang++3.6.0): clang-703.0.31
  • Operating System and version: Mac OS 10.11.6

Copy attribute to clipboard for user added attributes doesn't work on KDE Plasma 5

Copy attribute to clipboard function in the right click menu doesn't work for user added attributes, at least on KDE Plasma 5. The default attributes in the menu such as Title, Url and Notes, however, work fine without any problem

Expected Behavior

Data from user added attributes get copied to clipboard

Current Behavior

Nothing from user added attributes get copied to clipboard

Possible Solution

Steps to Reproduce (for bugs)

  1. Add a custom attribute to an entry via Advanced tab in the entry's property.
  2. Save the entry
  3. Right click on the entry and in Copy attribute to clipboard menu, select the name of custom attribute you added just now
  4. Observe that nothing is get copied to clipboard

Context

I use the attributes feature mainly for adding additional info that are related to the login details stored in an entry such as bank account, credit card number for the bank. Having them stored as attributes makes copying them much easier without many steps but this feature has been broken in the last few release of keepassx which then get carried over to keepassxreboot.

Your Environment

  • KeePassXR version/commit used: 3f80134 (Oct 29)
  • Qt version (e.g. Qt 5.3): 5.7
  • Compiler (e.g. Clang++3.6.0): cmake 3.6.2
  • Operating System and version: ArchLinux i686
  • Desktop Environment: KDE Plasma 5.8

Filter by group when selected in search mode

When searching and a group is clicked on it currently disables the search. It should instead follow normal user interface standards for about every web app and application which is to filter by the selected group. There is already a cancel search button.

[Feature Request] Support for cloud-based sync services

The excellent Keeweb project includes built-in support for syncing your password database file to various could-based sync services:

  • WebDAV
  • Dropbox
  • Google Drive
  • OneDrive

It would be awesome if similar functionality were built into KeepassX. It's nice not to have to run a sync service all the time when all you need to sync is your password database file.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.