Giter Site home page Giter Site logo

Comments (12)

droidmonkey avatar droidmonkey commented on September 23, 2024 1

agreed this needs to be improved

from keepassxc.

droidmonkey avatar droidmonkey commented on September 23, 2024

We decided not to do that. Instead, it must match both username and url of an existing passkey entry for the dialog to offer to update that entry. Otherwise, you choose the "register to existing" and choose the entry you want.

Perhaps that register to existing dialog could include a search box @varjolintu.

from keepassxc.

darkdragon-001 avatar darkdragon-001 commented on September 23, 2024

@droidmonkey I tried GitHub and Google and I had to manually choose the group and entry. The username and url fields in the entry are used successfully for password based login. So are you saying it should work but doesn't?

from keepassxc.

darkdragon-001 avatar darkdragon-001 commented on September 23, 2024

How is the URL compared? Does github.com (passkey relying party) match https://github.com/ (URL field)? Is only the primary URL field considered or are additional URLs also taken into account?

from keepassxc.

darkdragon-001 avatar darkdragon-001 commented on September 23, 2024

@droidmonkey @varjolintu could you please elaborate on how the URLs are compared? I have the impression that it doesn't match even though it should.

from keepassxc.

varjolintu avatar varjolintu commented on September 23, 2024

@darkdragon-001 URL field is used for checking access to the passkey entry, but the actual authentication happens against KPEX_PASSKEY_RELYING_PARTY attribute value.

from keepassxc.

darkdragon-001 avatar darkdragon-001 commented on September 23, 2024

@varjolintu This issue is about the "Add to existing" functionality, so before a passkey is stored. How is it determined if it suggests an existing entry? In my tests, it never did even though the URLs should match (at least they do for the old password paste).

from keepassxc.

varjolintu avatar varjolintu commented on September 23, 2024

@darkdragon-001 Suggesting an update to an existing entry directly happens only when identical KPEX_PASSKEY_USER_HANDLE is found from an entry.

from keepassxc.

darkdragon-001 avatar darkdragon-001 commented on September 23, 2024

@varjolintu So it never happens for an entry where no passkey is registered yet as there is no KPEX_PASSKEY_USER_HANDLE set?

Could we please have it? I have a huge database, so selecting the correct entry is currently quite difficult to navigate the group hierarchy until the correct entry.

from keepassxc.

darkdragon-001 avatar darkdragon-001 commented on September 23, 2024

I verified that even though existing "Username" matched future KPEX_PASSKEY_USERNAME and existing "URL" (https://github.com/) matched future KPEX_PASSKEY_RELYING_PARTY (github.com), it did not suggest to add the passkey to this existing entry.

from keepassxc.

varjolintu avatar varjolintu commented on September 23, 2024

I verified that even though existing "Username" matched future KPEX_PASSKEY_USERNAME and existing "URL" (https://github.com/) matched future KPEX_PASSKEY_RELYING_PARTY (github.com), it did not suggest to add the passkey to this existing entry.

As I saidKPEX_PASSKEY_USER_HANDLE is the relevant attribute here.

from keepassxc.

darkdragon-001 avatar darkdragon-001 commented on September 23, 2024

Thanks for confirming. Then this issue is a feature request to improve it. Would be great if you would find some time to make this great feature even better!

from keepassxc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.