Confirmation before closing password generator popup

[Jookia]

Confirmation before closing password generator popup

[Jookia]

Maybe it could be opt-out? It's a bit tough because you don't want to annoy the user. But the action of closing the window can't be undone and the password can't be recreated so it's a high risk operation.

[Jookia]

I'll have a go at implementing that when I get time, and maybe work on fixing the tab switch issue if I can.

I feel like the intended workflow here is to save before use, including saving the database. But the problem that people like me hit is sometimes the password needs tweaking after trying to enter it in to a service. So perhaps the correct solution is to save generations to a 'shadow password' in the database, and re-opening the password generator would show this password and allow you to continue generation or accepting.

[droidmonkey]

We could do this, might be annoying though. Generally when I apply a new or updated password I just generate one and accept it right away.

[droidmonkey]

High risk, but entirely in your control. There is a request open for a more formal password changing process.

[Jookia]

Where?

[droidmonkey]

#6323

[Jookia]

I can't comment on that issue. Looks like other people are hitting this issue: #7297 #8415 Would you accept a PR for adding a confirmation dialog on close? Perhaps a confirmation before the password changes if you click a tab too?

[droidmonkey]

Switching tabs should not re generate a new password, I agree that is an unexpected bug. I'd be open to a confirmation dialog if you click the top-right X to close the dialog but not if you press Cancel.