keitaoouchi/markdownview

Markdown View for iOS.

Hello, 👋

• 我叫大内慶太。Tokyo based software engineer focusing on web and mobile application.
• To make the world a more peaceful place and make you smile, I write massive legacy code every day, 本当にすいません 😙

markdownview's Issues

[Process] kill() returned unexpected error 1

The console will print a punch of [Process] kill() returned unexpected error 1 when the webview scrolled.

Does not support check boxes

I hope this can be implemented in MarkdownView, since it is rather common in most Markdown documents.

App got rejected because of keyword 'hotfix'

I have used this to render markdown content for a few projects and was able to launch without any problem before. But a recent new app submit got rejected and here's the response from Apple:

We notice that the app includes reference to hot fix in the MarkdownView framework. It would be appropriate to remove any reference to hot fix or the related functionality from the app. We look forward to reviewing your revised submission.

I found out that the 'hotfix' keyword is in the main.js file, and I'm not sure if it's entirely safe to remove it.

Add custom CSS support and Font customiztaion

Support Swift 4.2

Any plan for support swift 4.2?

Change background and text color

For my darkmode feature, I want to change background and text color of the markdown view.

How can I made that ?

I use MarkdownView 1.5.0with Swift 5

Carthage support

Can you give a KaTex support

How can I change text size

Hi, Please how can I change the text size in the viewer. I cant seem to find an option for that. Will it involve a code change?

iOS 13 (and 14?) view doesn't show well

iOS 13
Library v 1.9.1

1. MarkdownUI's height stays zero.
2. MarkdownUI.onRendered() callback doesn't receive anything.
3. Also, MarkdownView.onRendered() callback doesn't receive anything.

Workaround
In version 1.8.x callbacks works well. So it can be fixed by defining MarkdownUI (presented in 1.9) with frame(height:) bound with onRendered(height).

Note
It's really critical. As the library normally needed for iOS 13 and 14. While iOS 15 already has built-in markdown for Text views (though features are limited yet...).

Use of unresolved identifier 'height'

Use of unresolved identifier 'height' for xcode 4.1

No support empty line

if I input some string like below:

hello



world

what I expect is

hello

world

but the result from this library:

hello
world

I had try serval ways to resolve this, but all of that did not work.

Underline is not working

I would like to know to if (and how) it is possible to Underline the text.

How can I enable Zoom In/out in MarkdownView

I integrated this library into our project, but it does not allow me to zoom in/out. Our contents have some images and that should be able to zoom in so that users can see the details(table image)

Escape special characters

• \x

...

Objective-c support?

I installed MarkdownView with pod to my objective-c project. But I couldn't run it. Do you support objective-c projects?
Thanks..

Optional plugins

https://www.npmjs.com/browse/keyword/markdown-it-plugin

Too slow in rendering big string

Hi I am using this library which is full filling almost every condition but the rendering is too slow if the MD String is big. Any fixes ?

And also it loads everything at once, can we load images asyc?

markdownView.load not working due to webkit networking problem

when I was trying the example code for how to use and run it on my phone, nothing appeared.
And I got this message from console:
2017-09-14 01:42:41.275511+0800 tableview[2394:521302] Could not signal service com.apple.WebKit.WebContent: 113: Could not find specified service
2017-09-14 01:42:41.276706+0800 tableview[2394:521302] Could not signal service com.apple.WebKit.Networking: 113: Could not find specified service
plz Any help?

LateX support ?

Can't load Image on MarkdownView

Hey Guys,

I have a problem with load image.
In the screenshot, we can see that the MarkdownView does not load the image, but the image exists on the folder.

Has anyone had the same problem as me? Could someone help me solve this bug, please?

dark mode support

cocoapods MarkdownView (1.6.0) is not dark mode support, plase update, thanks~

ref：#47 (comment)

my pull requests：#57

Support for Dynamic Type

how best to modify the css to support dynamic type?

Superscript / subscript support?

Markdown-it supports superscripts and subscripts but it doesn't look like MarkdownView does - can we somehow get them working using this library or is it totally not supported?

Thanks!

Clear before rendering again

Any possible way to clear the view before rendering another markdown text?

Cannot load on GitHub files

Hi keitaoouchi,

I tried to replace a link for your README.md (https://github.com/keitaoouchi/MarkdownView/blob/master/README.md) and worked it. Most content was displayed, however, the GIF file was not loaded. Why?

import UIKit
import MarkdownView

class Example2ViewController: UIViewController {

  @IBOutlet weak var mdView: MarkdownView!

  override func viewDidLoad() {
    super.viewDidLoad()

    let session = URLSession(configuration: .default)
    let url = URL(string: "https://github.com/keitaoouchi/MarkdownView/blob/master/README.md")!
    let task = session.dataTask(with: url) { [weak self] data, _, _ in
      let str = String(data: data!, encoding: String.Encoding.utf8)
      DispatchQueue.main.async {
        self?.mdView.load(markdown: str)
      }
    }
    task.resume()
  }

}

Compiled error

Swift version 4.2.1

at the latest version 1.5.0

screenshot：

Support for SPM?

This is not an issue, but since a lot of developers are moving towards the Swift Package Manager, it can save lot of time.

table style

how to change table style, table for now only have top line, how to custom it to have full lines

How to reload new content in SwiftUI?

error: Pods/MarkdownView/webassets/dist/main.css: No such file or directory

The file could not be found in a test on buddybuild. All other pods have no problem, so I think you need to add some dependencies.

Look and Feel customizing

Error on master and SPM

Hi @keitaoouchi,

In ModuleSPM.swift htmlURL is defined as optional, but in MarkdownView it is used as non-optional. Project does not build

Best wishes,
Kristo

very very slow in rendering big string in uitableview cell

I am using this MarkdownView in uitableview cell. How can i loading like Asynchronous(Lazy loading). How can i fix this issue.

New release?

Hi @keitaoouchi,

I see some nice to have updates were published to master branch, is it possible to get those changes as a 1.7.2 release?
One could also use master branch for SPM, but would be nice to have a release for that.

Thank you for the great work!

onRendered callback height is before when before height is larger than new actual height.

When embed in tableViewCell, need update everytimes after load markdown, but onRendered callback height is before when before height is larger than new actual height, so I add the below method to get the actual height

public func webView(_ webView: WKWebView, didFinish navigation: WKNavigation!) {
        // 获取内容实际高度
        webView.evaluateJavaScript("document.body.scrollHeight") { [unowned self] (result, error) in
            DispatchQueue.main.async { [unowned self] in
                if let tempHeight: Double = result as? Double {
                    let height = CGFloat(tempHeight) + 10
                    debugPrint("height ==== \(height)")
                    self.onRendered?(height)
                }
            }
        }
    }

The onRendered return height is the same when I change the `markdownView.frame.width`.

class ViewController: UIViewController {
    override func viewDidLoad() {
        super.viewDidLoad()
        let markdownView = MarkdownView()
        markdownView.load(markdown: "....")
        self.view.addSubview(markdownView)
        markdownView.frame = CGRect(x: 0, y: 0, width: self.view.frame.width, height: 0)
        markdownView.onRendered = { [weak self] height in
            guard let `self` = self else {
                return
            }
            print("height is \(height)")
        }
    }
}

class ViewController: UIViewController {
    override func viewDidLoad() {
        super.viewDidLoad()
        let markdownView = MarkdownView()
        markdownView.load(markdown: "....")
        self.view.addSubview(markdownView)
        markdownView.frame = CGRect(x: 0, y: 0, width: self.view.frame.width * 0.5, height: 0)
        markdownView.onRendered = { [weak self] height in
            guard let `self` = self else {
                return
            }
            print("height is \(height)")
        }
    }
}

The height is the same.

how can support some image using not full path

Like:

can't load image

ellipsis...

ellipsis...

Running the Example app using Xcode 14 Beta 5 is not rendering the contents.

Running the Example app using Xcode 14 Beta 5 is not rendering the contents.

 image tag not work

import UIKit
import MarkdownView

class ViewControlle3: UIViewController {
  @IBOutlet weak var mdView: MarkdownView!
  
  override func viewDidLoad() {
    super.viewDidLoad()

    // not work
    mdView.load(markdown: "![](//dn-cnode.qbox.me/Fh2MIT1r4YStGl9ZEEzt7N4lEbqX)")
//    mdView.load(markdown: "![](//dn-cnode.qbox.me/Fh2MIT1r4YStGl9ZEEzt7N4lEbqX)", enableImage: true)
//    mdView.load(markdown: "![](http://dn-cnode.qbox.me/Fh2MIT1r4YStGl9ZEEzt7N4lEbqX)", enableImage: true)
  }
}

The code snippet supports line Numbers

For example, the code snippet supports line Numbers. Thank you very much.

how can I put markdownView in tableView cell

↑this is your code in example file
and

↑this is my code

What should I fix?