kenadia/circular-progress-indicator

AngularJS directive for a circular progress component

circular-progress-indicator's Issues

learn to use grunt

http://gruntjs.com/

You can use this to automate parts of your workflow:

• coffeelinting
• compiling coffee -> js
• taking css -> adding vendor prefixing
• watching deveopment files and auto-compiling when things change
• live-reloading your browser as you develop

testing the arcs

how would u test that the arcs drawn are visually correct? that the arc itself is at the 50% position or the 75% position or any other percent?

move styles into css if possible, use class names

make arc is taking in css hex

makeArc r * 0.82, r * 0.87, "#C7E596", scope.expected * 2 * Math.PI

it doesn't need to, style should be pushed into css, send class names instead so that designers can tweak the look and feel without knowing coffeescript

window resizer isn't good

this snippet of code is not production quality, why not bind to the window's resize event?
also, this should be debounced and you need to do proper cleanup.

    window.onresize = ->
      scope.$apply()
      return

likewise, this looks like a hack too

scope.$watch (->
      angular.element(window)[0].innerWidth
    ), scope.render