kencdk/kenc.acmelib

.net implementation of a client for the ACME protocol

Kenc.ACMELib

Free and open source software ACME protocol v2 implementation in C# .NET Core, allowing cross-platform automated interaction with certificate authorities like Let's Encrypt.

Contributing

• Read the Contributing document.

Getting Started

• Install NuGet package.
• Take a look at the examples.

Feedback

• Request a new feature using GitHub Issues.
• File a bug in GitHub Issues.
• Tweet with any other feedback.

Related Projects

License

Copyright Ⓒ Ken Christensen. All rights reserved.

Licensed under the MIT License.

kenc.acmelib's Issues

AccountId shouldn't be a parameter to the constructor

AccoutId shouldn't be passed in, instead rely on loading the account trough .GetAccount()

Ideally, throw an exception when calls to endpoints requiring an account are invoked without an account loaded.

awaited calls should use configureAwait(false)

To ensure callers don't issue blocking calls using async/await and .Result patterns, all awaited calls in library code should use .ConfigureAwait(false)

Using old versions of nuget packages

Describe the bug
Newer versions exists of both MSTest, moq and Newtonsoft.Json packages

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Network traces
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

DNS certificate validation uses wrong value

The format for DNS validation is different than the regular validation token.

AcmeLibCore is still referenced in project file

.net core 3.0 binaries

Is your feature request related to a problem? Please describe.
The current build output is made for .net core 2.0 and 2.1 - no support for .net core 3.0

Is the feature requested documented in the ACME protocol?
No

Describe the solution you'd like
Add binaries for .net core 3.0

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Subdomains aren't supported with Cloudflare integration

Describe the bug
Requesting certificates for subdomains (eg: local.domain.tld) throws "The following domains are not accesible in the cloudflare account."

To Reproduce
Steps to reproduce the behavior:

1. -d local.kenc.dk *.local.kenc.dk -u [email protected] -a apikey

Expected behavior
A certificate would have been created for local.kenc.dk and *.local.kenc.dk

Network traces
N/A

Additional context

Certificate revocation is sending a bad request

The certificate revocation call is using the incorrect data.
https://tools.ietf.org/html/draft-ietf-acme-acme-11#section-6.2