Custom radix

[kenkundert]

Custom radix

[KenKundert]

Oh my! That is quite a blunder. I'll get to work on fixing it.

[KenKundert]

Okay, I have fixed the version in github. New version is 2.8.3. I'll probably update pypi in the next few days.

Is it possible for you to check out the github version and try it out? You can let me know if you notice anything else I forgot.

[zjeff222]

Thanks for the fix.
The output is now working as expected, but the input is not.

from quantiphy import Quantity
Quantity.set_prefs(radix=',')
t= Quantity('3,123','m')
print(t.render())

yields 3,123 km

so we do have a comma in the output as wanted but since the quantity is now in km, it shows that the input comma was interpreted as a thousand seperator and not a radix. Maybe I was not clear in the last message - in comma radix systems, the comma is used exclusively as a radix. So 3,123 m should be equivalent to 3.123 m. Desired behavior: when radix is set to comma, reading a comma is the same as reading a point.

[KenKundert]

Actually, I had not implemented radix,comma support on the input; only on the output. However, I have updated it again and now the latest version should work. Please try the new version: 2.8.4. But you will need to set both radix and comma. By only setting radix, you still had ',' as the comma, and commas are stripped from the number.

[KenKundert]

I have updated again. It is now an error for radix and comma to be the same.

>>> from quantiphy import Quantity, QuantiPhyError                               
                                                                                 
>>> try:                                                                         
...     with Quantity.prefs(radix=','):                                          
...         q = Quantity('3,123','m')                                            
...         print(q.render())                                                    
... except QuantiPhyError as e:                                                  
...     print(e.render())                                                        
comma and radix must differ.                                                                   
                                                                                 
>>> try:                                                                         
...     with Quantity.prefs(radix=',', comma='.'):                               
...         q = Quantity('3,123','m')                                            
...         print(q.render())                                                    
... except QuantiPhyError as e:                                                  
...     print(e.render())                                                        
3,123 m                                                                          

Version is now 2.8.5.

[zjeff222]

Great. I did limited testing and now it works as expected for comma radix standard. Also, I noticed that when input is set with radix=',', comma=' ' (official/ISO standard in my region), the input with a dot will still work - and I think it is a good thing because not everyone uses the local standard.

thanks again

[KenKundert]

Thank you. I really appreciate you reporting these issues.
I have updated the documentation and the version, it is no 2.8.6. The additions to the documentation can be found here. I will try to update pypi to in the next few days.

[KenKundert]

I have released the fixed version (vers 2.9) on pypi.