kenshin9977/video-dl

A GUI for yt-dlp that aims to simplify its usage.

video-dl's Issues

the newly released macOS app for arm64 cant open on M1 Max Mac

the newly released macOS app for arm64 cant open on M1 Max Mac. It shows app icon on Dock, and then all is that, no any window or anything pop-up. It has to be forced quit.

Please add a switch to turn off automatic conversion of audio to mp3

Sometimes I need to download the original audio file of the video already getting it's audio bitrate. Forcing it to mp3 is not a good setting.
Thanks.

Is there any plan to upload project to PyPI?

Is there any plan to upload project to PyPI? If no, could I fork this project and upload it to PyPI? Just for the convenience of using this application, Thx

FFmpeg python package conflict

I was trying the latest release on an x64 MacBook running Catalina, and I got the following error every time I tried to download a video:

module 'ffmpeg' has no attribute 'probe'

After some digging running a clean python environment, I was able to narrow it down to the ffmpeg python package being imported instead of ffmpeg-python. Uninstalling the ffmpeg python package fixed the issue.

new GUI cant run on M1 Mac

run in virtual env 3.10.9 after installing all missing modules, it shows pop-up windows with error below

❯ python3 app.py
Unhandled error processing page session 85830c5c-ad7e-4e2f-bfa4-faa6d17df820: Traceback (most recent call last):
  File "/Users/usrname/.virtualenvs/33-video-dl-310-9-shared/lib/python3.10/site-packages/flet/flet.py", line 212, in on_session_created
    session_handler(page)
  File "/Users/usrname/Downloads/video-dl-master 2/gui_flet.py", line 764, in videodl_fletgui
    videodl_app = VideodlApp(page)
  File "/Users/usrname/Downloads/video-dl-master 2/gui_flet.py", line 50, in __init__
    self.media_link = ft.TextField(
TypeError: TextField.__init__() got an unexpected keyword argument 'dense'

btw maybe author can consider code gui with CustomTkinter
https://github.com/TomSchimansky/CustomTkinter

build successful on M1 Chip Macbook Pro, but cant open app (icon keep jumping on dock, no app windows shows up)

build successful on M1 Chip Macbook Pro, but cant open app (icon keep jumping on dock, no app windows shows up)

Everthing fine while building via sudo python3 MACOS-video-dl.py py2app but following warnings

Modules not found (conditional imports):
 * Crypto.Cipher (yt_dlp.extractor.bilibili, yt_dlp.extractor.ivi)
 * Crypto.Hash (yt_dlp.extractor.ivi)
 * Crypto.PublicKey (yt_dlp.extractor.bilibili)
 * MacOS (Cython.Plex.Timing)
 * Numeric (numpy.distutils.system_info)
 * OpenSSL.crypto (urllib3.contrib.pyopenssl)
 * Parser (Cython.Compiler.Main)
 * Queue (urllib3.util.queue)
 * StringIO (Cryptodome.Util.py3compat, urllib3.packages.six)
 * _dummy_thread (cffi.lock, future.backports.misc)
 * _manylinux (pkg_resources._vendor.packaging.tags)
 * _pytest (numpy.typing.tests.test_typing)
 * _ufunc (numpy._typing)
 * anydbm (future.moves.dbm)
 * array_interface_testing (numpy.core.tests.test_array_interface)
 * cPickle (pycparser.ply.yacc)
 * ccompiler_opt (numpy.distutils.tests.test_ccompiler_opt, numpy.distutils.tests.test_ccompiler_opt_conf)
 * checks (numpy.core.tests.test_cython)
 * com (pkg_resources._vendor.appdirs)
 * com.sun.jna (pkg_resources._vendor.appdirs)
 * com.sun.jna.platform (pkg_resources._vendor.appdirs)
 * cryptography (requests)
 * cryptography.x509.extensions (urllib3.contrib.pyopenssl)
 * dj_database_url (environs)
 * dj_email_url (environs)
 * django_cache_url (environs)
 * dl (setuptools.command.build_ext)
 * dumbdbm (future.moves.dbm.dumb)
 * dummy_thread (cffi.lock, future.backports.misc)
 * future_builtins (future.builtins.misc)
 * gdbm (future.moves.dbm.gnu)
 * graphviz (ffmpeg._view)
 * importlib_metadata (PyInstaller.compat, PyInstaller.utils.hooks.conda, click.decorators)
 * mem_policy (numpy.core.tests.test_mem_policy)
 * nose (numpy.testing._private.decorators, numpy.testing._private.utils, numpy.testing.tests.test_doctesting)
 * nose.plugins (numpy.testing._private.nosetester)
 * nose.plugins.builtin (numpy.testing._private.nosetester)
 * numarray (numpy.distutils.system_info)
 * numpy.testing.noseclasses ()
 * numpy_distutils (numpy.f2py.diagnose)
 * numpy_distutils.command.build_flib (numpy.f2py.diagnose)
 * numpy_distutils.command.cpuinfo (numpy.f2py.diagnose)
 * numpy_distutils.cpuinfo (numpy.f2py.diagnose)
 * numpy_distutils.fcompiler (numpy.f2py.diagnose)
 * pep517 (importlib.metadata)
 * psutil (numpy.testing._private.utils)
 * pycryptodome_test_vectors (Cryptodome.SelfTest.Hash.test_BLAKE2)
 * pygments (Cython.Compiler.Annotate)
 * pygments.formatters (Cython.Compiler.Annotate)
 * pygments.lexers (Cython.Compiler.Annotate)
 * pytest (numpy._pytesttester, numpy.testing._private.utils)
 * scipy (numpy.testing._private.nosetester)
 * simplejson (requests.compat)
 * thread (cffi.cparser, cffi.lock, future.backports.misc)
 * whichdb (future.moves.dbm)
 * win32com (pkg_resources._vendor.appdirs)
 * win32com.shell (pkg_resources._vendor.appdirs)
 * win32pdh (numpy.testing._private.utils)

Done!

Runtime error on macOS

Description

Attempting to run the program on macOS systematically returns the following error:

Traceback (most recent call last):
  File "video-dl/gui.py", line 357, in <module>
    Updater().update_app()
  File "video-dl/updater.py", line 28, in __init__
    self.app_bin_name = get_name_for_platform()
  File "video-dl/gen_new_version.py", line 169, in get_name_for_platform
    raise RuntimeError
RuntimeError

After some digging, two places would need some minor adjustments:

• in gen_new_version.py, in the get_name_for_platform function, adding a conditional for "Darwin" (macOS' platform name), the extension could be .dmg.
• in updater.py, in the _new_version_available method of the Updater class, testing if the platform is in the dictionary to avoid a KeyError. If it isn't, we can set self.latest_version to APP_VERSION to emulate being on the latest version.