kernitus/bukkitoldcombatmechanics

Spigot plugin to configure combat mechanics from 1.9 onwards

bukkitoldcombatmechanics's Issues

NoClassDefFoundError: net/gravitydevelopment/updater/Updater

OCM dev 43, generated new config. Errored as soon as I logged into my test server.

[06:56:26] [Craft Scheduler Thread - 7/WARN]: [OldCombatMechanics] Plugin OldCombatMechanics v1.1.2 generated an exception while executing task 131
java.lang.NoClassDefFoundError: net/gravitydevelopment/updater/Updater
	at gvlfm78.plugin.OldCombatMechanics.OCMUpdateChecker.getUpdateMessages(OCMUpdateChecker.java:36) ~[?:?]
	at gvlfm78.plugin.OldCombatMechanics.OCMUpdateChecker.sendUpdateMessages(OCMUpdateChecker.java:50) ~[?:?]
	at gvlfm78.plugin.OldCombatMechanics.OCMListener$1.run(OCMListener.java:35) ~[?:?]
	at org.bukkit.craftbukkit.v1_11_R1.scheduler.CraftTask.run(CraftTask.java:58) ~[patched_1.11.2.jar:git-Paper-1009]
	at org.bukkit.craftbukkit.v1_11_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52) [patched_1.11.2.jar:git-Paper-1009]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) [patched_1.11.2.jar:git-Paper-1009]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:1.8.0_112]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:1.8.0_112]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_112]
Caused by: java.lang.ClassNotFoundException: net.gravitydevelopment.updater.Updater
	at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_112]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:102) ~[patched_1.11.2.jar:git-Paper-1009]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:87) ~[patched_1.11.2.jar:git-Paper-1009]
	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_112]
	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_112]
	... 9 more

StackOverflowError generating new config.

http://paste.ubuntu.com/18763869/

OldCombatMechanics dev 49
Generated a new config at server start-up, this overflow error occurred. It occurs every time the server starts.

Caused by this version not being updated?
https://github.com/gvlfm78/BukkitOldCombatMechanics/blob/b6484c31ba3827a0ef3da0c0628e85f97b335da6/src/main/java/gvlfm78/plugin/OldCombatMechanics/utilities/Config.java#L16

ReAdd cooldowns

Hello,
I installed OCM on my server, but now i want to test some plugin without him (OCM) but I can't get back the cooldown of 1.9. I have removed in my plugin folder the .jar file and the folder.

I really need to get back the cooldown (true 1.9 cooldown).

Please, could you help me?

Players can't push any entities

Ok so i saw you had a fix for the players not being able to push ANY entities with the plugin. I have removed the plugin previously due to running into this issue. That fixed nothing they still couldnt push anything. Now i added the newest version prior to your fix and still cant push anything.... Any solutions to fixing this.
OCM.zip
Last OCM version we used. not sure which it is.

Players can not create strenght potion when old alchemy stand is enabled

Players can not create strenght potion when old alchemy stand is enabled.
It is because they can not put blaze powder to brewing slot (not fuel).

Bug.

Hello,

I have this error on Spigot 1.11 :
[11:15:48] [Server thread/ERROR]: Could not pass event BlockDispenseEvent to OldCombatMechanics v1.1.1
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.DispenseBehaviorItem.a(DispenseBehaviorItem.java:63) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.DispenseBehaviorItem.b(DispenseBehaviorItem.java:26) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.DispenseBehaviorItem.a(DispenseBehaviorItem.java:13) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.BlockDropper.dispense(BlockDropper.java:41) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.BlockDispenser.b(BlockDispenser.java:113) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.WorldServer.a(WorldServer.java:740) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.WorldServer.doTick(WorldServer.java:250) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.MinecraftServer.D(MinecraftServer.java:790) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.DedicatedServer.D(DedicatedServer.java:399) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.MinecraftServer.C(MinecraftServer.java:675) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at net.minecraft.server.v1_11_R1.MinecraftServer.run(MinecraftServer.java:574) [spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_72]
Caused by: java.lang.ClassCastException: org.bukkit.craftbukkit.v1_11_R1.block.CraftDropper cannot be cast to org.bukkit.block.Dispenser
at com.codingforcookies.armourequip.ArmourListener.dispenserFireEvent(ArmourListener.java:188) ~[?:?]
at sun.reflect.GeneratedMethodAccessor1241.invoke(Unknown Source) ~[?:?]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_72]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_72]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:302) ~[spigot-1.11.jar:git-Spigot-f950f8e-4d99fed]
... 15 more

Thanks to fix it. :D

Armour damage reduction seemingly not accurate to 1.8

are there any limitations to how much armor can be like it was in 1.9? I went on 1.8 single player, and it took 4 hits for a zombie to take a full heart in full diamond armor, and on 1.10.2 with oldcombatmechanics installed, i took 2 hits from the zombie in diamond armor and it dealt a full heart. ive cranked up the armor strength value but to no avail i still take the same damage. i know that in 1.8, it was 80% damage reduction.

Custom tool damage issues

Having some issues with this plugin, first off all configuring the tool damage is quite confusing, and sometime when I reload the plugin it breaks the config. Is there a way you can make it so the attack damages are on the tools too? Also, I have other hand disabled but people can still use their other hand. Please help.

Cannot Restore Cooldowns

My players decided they wanted the new combat mechanics so that right-clicking wouldn't interfere with McMMO.
After removing the .jar and the plugin folder, the cooldown animation has not restored to their screens (nor mine). I'm wondering what I did wrong?

MobArena Incompatible

the plugin is not mobarena compataible, if u join a arena u get sword which tell u they have 1000 attack speed but they just work as 1.9 combat (on a 1.10 server)

no errors, just the above

Could not pass event PrepareItemCraftEvent to OldCombatMechanics

OldCombatMechanics dev 17
Default config settings (new config generated).

[07:00:42] [Server thread/ERROR]: Could not pass event PrepareItemCraftEvent to OldCombatMechanics v1.1.0
org.bukkit.event.EventException
	at org.bukkit.plugin.EventExecutor$1.execute(EventExecutor.java:46) ~[patched_1.10.2.jar:git-Paper-910]
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:74) ~[patched_1.10.2.jar:git-Paper-910]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[patched_1.10.2.jar:git-Paper-910]
	at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:517) [patched_1.10.2.jar:git-Paper-910]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:502) [patched_1.10.2.jar:git-Paper-910]
	at org.bukkit.craftbukkit.v1_10_R1.event.CraftEventFactory.callPreCraftEvent(CraftEventFactory.java:773) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.CraftingManager.craft(CraftingManager.java:314) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.ContainerPlayer.a(ContainerPlayer.java:83) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.InventoryCrafting.setItem(InventoryCrafting.java:120) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.Slot.set(Slot.java:58) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.Container.a(Container.java:293) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.PlayerConnection.a(PlayerConnection.java:1917) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.PacketPlayInWindowClick.a(SourceFile:33) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.PacketPlayInWindowClick.a(SourceFile:10) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.PlayerConnectionUtils$1.run(SourceFile:13) [patched_1.10.2.jar:git-Paper-910]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_112]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_112]
	at net.minecraft.server.v1_10_R1.SystemUtils.a(SourceFile:45) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.MinecraftServer.D(MinecraftServer.java:808) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.DedicatedServer.D(DedicatedServer.java:404) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.MinecraftServer.C(MinecraftServer.java:740) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.MinecraftServer.run(MinecraftServer.java:639) [patched_1.10.2.jar:git-Paper-910]
	at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]
Caused by: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
	at java.util.ArrayList.rangeCheck(ArrayList.java:653) ~[?:1.8.0_112]
	at java.util.ArrayList.get(ArrayList.java:429) ~[?:1.8.0_112]
	at gvlfm78.plugin.OldCombatMechanics.module.ModuleShieldCrafting.onItemCraft(ModuleShieldCrafting.java:39) ~[?:?]
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor109.execute(Unknown Source) ~[?:?]
	at org.bukkit.plugin.EventExecutor$1.execute(EventExecutor.java:44) ~[patched_1.10.2.jar:git-Paper-910]
	... 22 more
[07:00:43] [Server thread/ERROR]: Could not pass event PrepareItemCraftEvent to OldCombatMechanics v1.1.0
org.bukkit.event.EventException
	at org.bukkit.plugin.EventExecutor$1.execute(EventExecutor.java:46) ~[patched_1.10.2.jar:git-Paper-910]
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:74) ~[patched_1.10.2.jar:git-Paper-910]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[patched_1.10.2.jar:git-Paper-910]
	at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:517) [patched_1.10.2.jar:git-Paper-910]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:502) [patched_1.10.2.jar:git-Paper-910]
	at org.bukkit.craftbukkit.v1_10_R1.event.CraftEventFactory.callPreCraftEvent(CraftEventFactory.java:773) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.CraftingManager.craft(CraftingManager.java:314) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.ContainerPlayer.a(ContainerPlayer.java:83) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.InventoryCrafting.splitStack(InventoryCrafting.java:112) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.SlotResult.a(SourceFile:97) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.ContainerPlayer.b(ContainerPlayer.java:169) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.Container.a(Container.java:263) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.PlayerConnection.a(PlayerConnection.java:1917) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.PacketPlayInWindowClick.a(SourceFile:33) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.PacketPlayInWindowClick.a(SourceFile:10) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.PlayerConnectionUtils$1.run(SourceFile:13) [patched_1.10.2.jar:git-Paper-910]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_112]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_112]
	at net.minecraft.server.v1_10_R1.SystemUtils.a(SourceFile:45) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.MinecraftServer.D(MinecraftServer.java:808) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.DedicatedServer.D(DedicatedServer.java:404) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.MinecraftServer.C(MinecraftServer.java:740) [patched_1.10.2.jar:git-Paper-910]
	at net.minecraft.server.v1_10_R1.MinecraftServer.run(MinecraftServer.java:639) [patched_1.10.2.jar:git-Paper-910]
	at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]
Caused by: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
	at java.util.ArrayList.rangeCheck(ArrayList.java:653) ~[?:1.8.0_112]
	at java.util.ArrayList.get(ArrayList.java:429) ~[?:1.8.0_112]
	at gvlfm78.plugin.OldCombatMechanics.module.ModuleShieldCrafting.onItemCraft(ModuleShieldCrafting.java:39) ~[?:?]
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor109.execute(Unknown Source) ~[?:?]
	at org.bukkit.plugin.EventExecutor$1.execute(EventExecutor.java:44) ~[patched_1.10.2.jar:git-Paper-910]
	... 23 more

Two offhand problems

Hi!

Two bugs with the off-hand in the plugin.

First, with a whitelist, I still cannot use the F (or key for equipping offhand) to equip the item even if the item is in the offhand.

Second, if I put an item in my offhand that is permitted with a whitelist, I can then put in one that isn't and it would stay there.

Server on 1.10.2, OCM version 1.1.2.

null lines on start-up.

Using dev build 20.

[19:47:39] [Server thread/INFO]: [OldCombatMechanics] Enabling OldCombatMechanics v0.9
[19:47:39] [Server thread/INFO]: [OldCombatMechanics] null
[19:47:39] [Server thread/INFO]: [OldCombatMechanics] null
[19:47:39] [Server thread/INFO]: [OldCombatMechanics] OldCombatMechanics v0.9 has been enabled correctly

Golden Apple bug

There seems to be a infinite gapple bug, whenever i eat an apple it doesnt dissapear and i can keep eating the same apple

Restoring Attack Speed

When plugin was removed, swords and weapons still crafted with high attack speed? How would I change it back to its 1.9 default?

Option to enable snowball knockback on player hit.

Apparently snowball/egg knockback was a longstanding bug in Spigot and wasn't suppose to be a thing.
https://www.spigotmc.org/threads/bug-or-feature-snowball-egg-knockback.214759/#post-2232519

Would it be possible to implement an OCM module to allow for snowball/egg player knockback and/or damage? As it was a prevalent thing in my PVP arena community. :(

Jenkins server is down.

Offhand module blocking access to all slot #40s

For some... odd reason.. I can't place items in the #41 slot in a chest.

I know that sounds like nonsense, but I've tried doing it without combat mechanics installed and it works fine. I tried downloading the latest dev version and that didn't fix it either.

Here's my config: https://hastebin.com/idozaqetuk.bash
The only error I'm getting: https://hastebin.com/gikawukuge.pl
Server version: Paper version git-Paper-916.2 (MC: 1.10.2) Implemetning API version 1.10.2-R0.1-SNAPSHOT)
Gif: https://gyazo.com/ebc68023b608cd886c1240a2120896ad

Per world system is broken

I have a world named 1.8 so I changed the config option for all the plugin features from
worlds: []
to
worlds: [1.8]
and now the plugin won't work in any worlds at all.

Tried using PerWorldPlugins as well but it seems it doesn't limit the combat change to certain worlds...

Will not regenerate health past 20 hearts

As the title says, if I /effect DankPotion_ minecraft:healthboost 60 5, it will not regenerate the empty hearts. It knocks people back down to 20 hearts if they do somehow regenerate past 20 hearts.

Here's a little video showing the bug. (Watch Please.)
https://youtu.be/XxgWWma29CY

Lore text displaying wrong damage values

Weapons and tools such as Swords, axes, shovels, etc are displaying the wrong damage values. For instance, the Iron Axe says it deals 9 Attack Damage, but the hits are dealing 5 damage.
Value
Damage

This bug has been tested on a fresh server with only the following mods installed:
CombatIndicator_2.0.14.jar
HolographicDisplays.jar
OldCombatMechanics.jar

Here's the config:
http://pastebin.com/M2kDGw6W

Finally, the server is running git-Spigot-283de8b-2ad21b8 (MC: 1.11.2) (Implementing API version 1.11.2-R0.1-SNAPSHOT)

Hand goes invisible when swapping between worlds.

When teleporting to a different world, your hand / tool goes invisible and you do no damage. Reloading OCM or relogging fixes the problem.

http://paste.ubuntu.com/18129754/

Tested with general-attack-speed: 16 and general-attack-speed: 1024.

Utility to scan and reset all player attributes to vanilla default.

@gvlfm78 Is it at all possible to create a small utility to scan the world folder and reset all player.dat file attributes to their vanilla default values? Somehow I have some players with a generic.attackDamage of base 7, while most others have generic.attackDamage of 1. This is causing those players to be extremely powerful in arenas. I have no idea how their attribute got set so high but I also am not familiar with how to reset everyone without wiping everyone's location / inventory, since I do not know who else is broken.

It may be related to these issues that were marked fixed, but those players were never fixed directly.
https://hub.spigotmc.org/jira/browse/SPIGOT-2077
https://hub.spigotmc.org/jira/browse/SPIGOT-704
https://hub.spigotmc.org/jira/browse/SPIGOT-1409

Custom messages.

Hello,

Could you add custom messages when we kill a mob, etc ?

Thanks ! :D

Shields turning into books

Hello!

Having a bit of a weird issue here. We use OldCombatMechanics to bring up a shield whenever people right click with their sword, but if they crouch and left click their shield will turn into a book and quill for some reason.

We have not been able to observe this behavior on a server without OldCombatMechanics on it.

Plugin version: 1.1.2
Spigot version: Paper 1062

Weird messages on console when i login

It seems when i login the plugin always prints the following to console:

Oy vey
rglkieruigr: null null

Maybe it is some debug code you forgot?

Configurable attack frequency.

Would it be possible to allow for a configurable increased attack frequency between hits for better hit detection / no damage ticks / no attack delay with a click-per-second limit to simulate faster combat similar to 1.8 in 1.10+?

Something like SmashHit (Async hit detection, but contains quite a few issues) https://aquifermc.org/resources/smashhit-async-hit-detection.15/ or MassiveCombat (has configurable damage ticks) https://www.spigotmc.org/threads/massivecombat-paid.151457/page-7#post-1924696

Error When Joining

This error appears in the console when a player joins the server but to my testing has no affect on gameplay

[21:55:22 WARN]: [OldCombatMechanics] Plugin OldCombatMechanics v1.1.2 generated an exception while executing task 369
java.lang.NoClassDefFoundError: net/gravitydevelopment/updater/Updater
at gvlfm78.plugin.OldCombatMechanics.OCMUpdateChecker.getUpdateMessages(OCMUpdateChecker.java:36) ~[?:?]
at gvlfm78.plugin.OldCombatMechanics.OCMUpdateChecker.sendUpdateMessages(OCMUpdateChecker.java:50) ~[?:?]
at gvlfm78.plugin.OldCombatMechanics.OCMListener$1.run(OCMListener.java:35) ~[?:?]
at org.bukkit.craftbukkit.v1_11_R1.scheduler.CraftTask.run(CraftTask.java:58) ~[patched_1.11.2.jar:git-Paper-1059]
at org.bukkit.craftbukkit.v1_11_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52) [patched_1.11.2.jar:git-Paper-1059]
at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) [patched_1.11.2.jar:git-Paper-1059]
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:1.8.0_111]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:1.8.0_111]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_111]

Per-world function does not work anymore

When you first enable "disable-attack-cooldown:" to have standing in the world and ale than functional: it only has to work then you have yet another world in a particular world. Rejoin does not work and the server restart does also not work.

I personally think that the "worlds" feature is dead because when I turn "generic-attack speed: 4" to set in all worlds and then "generic-attack speed: 128" do a particular world than all worlds again at the rate of 128...

Sorry for my bad English... I use Google Translate 😋

Console errors for ModuleGoldenApple.onPrepareItemCraft

nullPointerException
.onPrepareItemCraft(ModuleGoldenApple.java:39)

I am developing a custom items crafting plugin and I am receiving this error from OldCombatMechanics when I include the following code in my plugin. I can perceive no reason why this should happen!

public void onPrepare(PrepareItemCraftEvent e) {
.....Some code which filters to accept only 'my' custom recipes....
if (!this.getConfig().getBoolean(new StringBuilder("EnabledWorlds.").append(w).toString())) {
logger.info("A player tried to craft in an unregistered world called " + w);
e.getInventory().setResult(new ItemStack(Material.AIR, 1));
return;
}
.....Other code to manage recognition of my custom recipes...
None of the rest of my code causes any issue, and I am not crafting anything with Gold or Apples!

Additional configurable PVP options.

I was wondering if a few additional pvp tweaking options could be implemented in OCM. Primarily to avoid having to use multiple separate plugins to modify, tweak, and handle combat in 1.9+. Similarly to my last suggestion with having a configurable attack frequency / async hit detection (#19), these additional suggestions would be coming from a plugin called PrimoCombat.

https://github.com/PrimoMC/PrimoCombat

• Having the option to disable random projectile trajectories.
• Having an option to disable bow boosting.
• Having an option to prevent using a bow in your offhand.

16 is not the minimum for no cooldown?

I noticed the default was changed here.
756ea43#diff-ee97532d2d40af21fc87a8fc24cd37c3R29

From my testing with OCM dev 29 on Spigot 1.11, with the attack indicator enabled on the crosshair, 16 attack speed still shows an attack indicator when switching weapons and click attacking. Although it is fast, a minimum of 23 is needed for there to be absolutely no indicator, 24 for safe measures I'd say.

Health always at 19/20

So, when at "full health" there's always a half heart missing, even when eating a golden apple or when respawning, the health will always be at 19/20. I don't know what causes this, I didn't find anything in the config about it, running spigot 1.11.2

Armor Bug when wearing the items

After wearing any piece of armor using the RightClick feature from the hotbar, the armor gets glitched.
Just a text glitch from my testing, but may add lots of confusion to players.

Glitch: (Have F3+H enabled to see item values such as Armor and Toughness)

Any Chestplate, for example a diamond one, has +2 Armor Toughness and +8 Armor.
The second you wear the diamond chestplate, it will turn its stats into +9999 Armor Toughness and +8 Armor. This happens to any piece of armor that is worn via RightClicking from the hotbar.

PlayerJoinEvent Lag

Any way to optimize PlayerJoinEvent lag caused by OCM? What requires listening for the join event? The 'Better Combat' plugin isn't even a fraction of the performance cost. :s

NoClassDefFoundError: net/gravitydevelopment/updater/Updater

OCM dev 63

[03:45:54] [Craft Scheduler Thread - 4/WARN]: [OldCombatMechanics] Plugin OldCombatMechanics v1.2.0 generated an exception while executing task 124
java.lang.NoClassDefFoundError: net/gravitydevelopment/updater/Updater
	at gvlfm78.plugin.OldCombatMechanics.OCMUpdateChecker.getUpdateMessages(OCMUpdateChecker.java:36) ~[?:?]
	at gvlfm78.plugin.OldCombatMechanics.OCMUpdateChecker.sendUpdateMessages(OCMUpdateChecker.java:50) ~[?:?]
	at gvlfm78.plugin.OldCombatMechanics.OCMListener$1.run(OCMListener.java:35) ~[?:?]
	at org.bukkit.craftbukkit.v1_11_R1.scheduler.CraftTask.run(CraftTask.java:58) ~[patched_1.11.2.jar:git-Paper-1062]
	at org.bukkit.craftbukkit.v1_11_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:52) [patched_1.11.2.jar:git-Paper-1062]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) [patched_1.11.2.jar:git-Paper-1062]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:1.8.0_121]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:1.8.0_121]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_121]
Caused by: java.lang.ClassNotFoundException: net.gravitydevelopment.updater.Updater
	at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_121]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:102) ~[patched_1.11.2.jar:git-Paper-1062]
	at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:87) ~[patched_1.11.2.jar:git-Paper-1062]
	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_121]
	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_121]
	... 9 more

Outdated server version

http://pastebin.com/5PZmK27R This is the link for the error. Ive also tried another plugin and it did the same error. Im sure this is a dumb mistake so please help me

Disable-OffHand number keys

I found a bug with 'disable-offhand'
When we put a locked item on the hotbar and hover the mouse over the slot from this hand, we can put it there.

My Configuration:
disable-offhand: enabled: true worlds: [] whitelist: false items: [diamond_sword]

Jenkins is not building plugin with plugin.yml or config.yml.

Missing resource folder to include files in compile?

Does this work in 1.11.2

The armor/tools don't seem to be the old ways.

NPE when exiting brewing stand with no fuel

[17:06:23] [Server thread/ERROR]: Could not pass event InventoryClickEvent to OldCombatMechanics v1.1.2
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at net.minecraft.server.v1_11_R1.PlayerConnection.a(PlayerConnection.java:1844) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at net.minecraft.server.v1_11_R1.PacketPlayInWindowClick.a(SourceFile:33) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at net.minecraft.server.v1_11_R1.PacketPlayInWindowClick.a(SourceFile:10) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at net.minecraft.server.v1_11_R1.PlayerConnectionUtils$1.run(SourceFile:13) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_72]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_72]
at net.minecraft.server.v1_11_R1.SystemUtils.a(SourceFile:46) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at net.minecraft.server.v1_11_R1.MinecraftServer.D(MinecraftServer.java:739) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at net.minecraft.server.v1_11_R1.DedicatedServer.D(DedicatedServer.java:399) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at net.minecraft.server.v1_11_R1.MinecraftServer.C(MinecraftServer.java:675) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at net.minecraft.server.v1_11_R1.MinecraftServer.run(MinecraftServer.java:574) [spigot-1.11.2.jar:git-Spigot-7d78b81-e232e15]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_72]
Caused by: java.lang.NullPointerException

Fix the bow damage.

Fix the bow damage.

Most plugins don't handle this. You should make the bow damage back to 1.8 modifiers.

Add a nametag at the bottom of tools that says 1.8 Damage Values.

Some servers that are 1.11 have a thing at the bottom of every tool that says 1.8 Damage Values. To let players know i was wondering if this is possible to add to the plugin.

Fishing Rods

The fishing rod knockback is not working in 1.11.2.

OCM Could not check for updates error: The reference to entity "render" must end with the ';' delimiter.null

OCM dev 34

[02:22:21] [Craft Scheduler Thread - 7/WARN]: [Fatal Error] :58:86: The reference to entity "render" must end with the ';' delimiter.

[02:22:21] [Craft Scheduler Thread - 7/ERROR]: OCM Could not check for updates error: The reference to entity "render" must end with the ';' delimiter.null

Old potion effects

Hello,

Will you add something to get the old strength potion system ? Currently, we can't really offer our players a combat experience like the one we had pre-1.9, since the strength potions (a key component in PvP) are now worthless compared to what they were before !

Thanks.

Fishing rod in WG region not counted as PvP

Players can still hit each other with fishing rod in WG protected regions even if in the region PvP is set to false.

Renamed GApple bug

Players on my server started duping golden apples and enchanted golden apples.

It only happens with gapples with custom display name without lore, and it works like shown in the video: http://download.serb-craft.com/applebug.mp4

Can you please fix this?

Request...?

Can you an option to disable it in some worlds?
Example:
In World its disable,
In CPvPMap_1 is not disabled.

Issue #11 2.0

Hello.

How can i set every's players attack speed armour etc, statz to default? (The way how 1.8 and higher worked)