kevchu3/azure-buildagent-container

Build a containerized Azure agent

azure-buildagent-container's Issues

making SA privileged

This is the error I get when I run the command from the README:

oc adm policy add-scc-to-user -z azure-build-sa privileged                                    [ruby-2.6.8p205]
Error from server (Forbidden): clusterrolebindings.rbac.authorization.k8s.io "system:openshift:scc:privileged" is forbidden: User "cluster-admin" cannot get resource "clusterrolebindings" in API group "rbac.authorization.k8s.io" at the cluster scope

Parameterize the proxy credentials

Proxy credentials are stuffed into start.sh. We should parameterize them, and if they're not all defined, we should pass a ./config.sh command without those parameters.

Build Config never ran

Error reported in diagnostic logs. Please examine the log for more details.

• /opt/app-root/app/_diag/Agent_20220730-163828-utc.log
  VS30063: You are not authorized to access https://dev.azure.com.

README should tell user to clone repo

It may seem straight forward, but I think you should tell the user to clone/fork the repo and make changes in their copy.

Run multiple pod replicas of agent

Need to figure out a way to pass a unique --agent for each replica from the built agent image:

/opt/app-root/app/config.sh --unattended --url https://dev.azure.com/myOrg --auth pat --token myToken --pool default --agent myOCPAgent --acceptTeeEula

Version agnostic agent download location

Consider replacing this with version agnostic URL:
https://vstsagentpackage.azureedge.net/agent/2.206.1/vsts-agent-linux-x64-2.206.1.tar.gz

Also want to expose this package as a configurable environment variable in the BuildConfig

imagePullBackoff when applying the deployment

When I create the deployment I get imagePullBackoff on the image stream.

Installation #2

Configure the Azure build agent to use an unattended config...

You never actually say where they are supposed to make this change. The instructions should say in the Dockerfile on line 7...

Change start-sh from ConfigMap to Secret

Since we can potentially store sensitive proxy information, we would want to use a Secret instead of ConfigMap for the start.sh script. Also would want to parameterize the proxy info if we can.