kevinsnydercodes/eventemitter-ts

Typed EventEmitter classes for use with TypeScript

eventemitter-ts's Issues

Publish to npm

So ts-eventemitter is already a package on npm...

Pick a different package name, then try publishing again.

• Update GitHub repo name
• In files, change all ts-eventemitter to eventemitter-ts
• Publish!

Passing undefined params to base EventEmitter class methods causes undesired results

Take TypedEventEmitter#removeAllListeners as an example:

removeAllListeners<K extends keyof T>(event?: K): this {
    return super.removeAllListeners(event);
}

This call:

typedEventEmitter.removeAllListeners();

Translates to:

eventEmitter.removeAllListeners(undefined);

In EventEmitter#removeAllListeners, the code looks like:

EventEmitter.prototype.removeAllListeners =
    function removeAllListeners(type) {
      var listeners, events, i;

      events = this._events;
      if (events === undefined)
        return this;

      // not listening for removeListener, no need to emit
      if (events.removeListener === undefined) {
        if (arguments.length === 0) {
          this._events = Object.create(null);
          this._eventsCount = 0;
        } else if (events[type] !== undefined) {
          if (--this._eventsCount === 0)
            this._events = Object.create(null);
          else
            delete events[type];
        }
        return this;
      }
    // ...
    };

When type = undefined, arguments.length === -0 evaluates to false, which in turn does not cause all the event listeners to be removed.

Basically the base EventEmitter class is treating an undefined parameter as a parameter nonetheless, instead using arguments.length to determine if a parameter was provided or not.

This is true for EventEmitter#removeAllListeners, and possibly other functions as well. Investigate and make changes where appropriate.

In this case, the fix to TypedEventEmitter would be:

removeAllListeners<K extends keyof T>(event?: K): this {
    if (event === undefined) {
        return super.removeAllListeners();
    } else {
        return super.removeAllListeners(event);
    }
}