kevinsnydercodes / eventemitter-ts Goto Github PK
View Code? Open in Web Editor NEWTyped EventEmitter classes for use with TypeScript
Typed EventEmitter classes for use with TypeScript
So ts-eventemitter
is already a package on npm...
Pick a different package name, then try publishing again.
ts-eventemitter
to eventemitter-ts
Take TypedEventEmitter#removeAllListeners
as an example:
removeAllListeners<K extends keyof T>(event?: K): this {
return super.removeAllListeners(event);
}
This call:
typedEventEmitter.removeAllListeners();
Translates to:
eventEmitter.removeAllListeners(undefined);
In EventEmitter#removeAllListeners
, the code looks like:
EventEmitter.prototype.removeAllListeners =
function removeAllListeners(type) {
var listeners, events, i;
events = this._events;
if (events === undefined)
return this;
// not listening for removeListener, no need to emit
if (events.removeListener === undefined) {
if (arguments.length === 0) {
this._events = Object.create(null);
this._eventsCount = 0;
} else if (events[type] !== undefined) {
if (--this._eventsCount === 0)
this._events = Object.create(null);
else
delete events[type];
}
return this;
}
// ...
};
When type = undefined
, arguments.length === -0
evaluates to false
, which in turn does not cause all the event listeners to be removed.
Basically the base EventEmitter
class is treating an undefined
parameter as a parameter nonetheless, instead using arguments.length
to determine if a parameter was provided or not.
This is true for EventEmitter#removeAllListeners
, and possibly other functions as well. Investigate and make changes where appropriate.
In this case, the fix to TypedEventEmitter
would be:
removeAllListeners<K extends keyof T>(event?: K): this {
if (event === undefined) {
return super.removeAllListeners();
} else {
return super.removeAllListeners(event);
}
}
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.