kffl/fastify-amqp-async

:zap::rabbit: Fastify AMQP plugin with modern Promise-based API based on amqplib-as-promised

fastify-amqp-async's Issues

confirmChannel typing issues

When accessing amqp.confirmChannel, IDE type hints are not working properly (all of its methods are assumed to be of type any). After installing @types/amqplib, it turns out that confirmChannel is of native amqplib's type ConfirmChannel and not that of amqplib-as-promised (which wraps the native ConfirmChannel in order to expose promise-based API). This problem doesn't break anything at runtime, since Connection.createChannel() returns an object with the desired prototype (despite wrong type info).

That behavior is caused by amqplib-as-promised exporting the native ConfirmChannel instead of the wrapped one.

Introduce an option to opt-out of the default onClose behavior

As of now, the plugin provides a basic onClose handler which closes the AMQP connection when the Fastify instance closes. It might be beneficial to allow the user to opt-out of such behavior and provide custom logic in onClose (i.e. waiting for in-flight messages to be delivered before terminating the AMQP connection).

Add logging

Logging via a FastifyInstance's child logger could be added for easier debugging. Logs could be printed when the following events occur:

• connection is opened
• channel is created
• connection is closed

Security vulnerabilities of transitive dependencies (amqplib, url-parse)

As of now, there is a known vulnerability in url-parse used by amqplib, which is a dependency of amqplib-as-promised. Since amqplib-as-promised uses a rather old version 0.5.5 of amqplib there are two less severe vulnerabilities as well. These can be temporarily fixed using npm-force-resolutions until the top-level dependencies update their sub-dependencies as needed.

Release v1 to indicate stable API

Version 1 could be released in order to allow for updates within a major version when a dependency is declared with a caret symbol.