khronosgroup/gltf-compressor

To store the source code for the glTF-Compressor project

gltf-compressor's Issues

Incorrect thumbnail gamma with KTX

1. Download a GLB which contains KTX2 assets inside it, for example https://github.com/KhronosGroup/3D-Formats-Guidelines/blob/main/samples/StainedGlassLamp/StainedGlassLamp-KTX-BasisU-Volume-ETC1S.glb
2. Go to https://phasmatic3d.github.io/glTF-Sample-Viewer-KTX-demo/
3. Drag and drop the GLB into the 3d view.
4. Go to the Texture Compressor tab.
5. Open a new Chrome window, and repeat the above except using a GLB with PNG/JPG textures, for example https://github.com/KhronosGroup/3D-Formats-Guidelines/blob/main/samples/StainedGlassLamp/StainedGlassLamp-JPG-PNG-Volume.glb
6. Compare the two windows side-by-side.

Result: some thumbnails are displayed with incorrect gamma.

• Normal/occlusion/rough/metal textures are overbright (they should be displayed in linear colorspace).
• Basecolor and emissive seem to be OK.
• KTX2 with alpha channel seems to be displayed with black, compared to gray for a PNG with alpha.

Screenshots comparing glTF with KTX vs glTF with PNG/JPG:

File already Exists Copressed GLTF export

zip-writer.js:142 Uncaught (in promise) Error: File already exists
at ZipWriter.add (zip-writer.js:142:11)
at main.js:758:34
at Array.map ()
at SafeSubscriber._next (main.js:756:50)
at SafeSubscriber.__tryOrUnsub (Subscriber.js:192:16)
at SafeSubscriber.next (Subscriber.js:130:22)
at Subscriber._next (Subscriber.js:76:26)
at Subscriber.next (Subscriber.js:53:18)
at MapSubscriber._next (map.js:41:26)
at Subscriber.next (Subscriber.js:53:18)

Texture with custom ICC profile are not accurately compressed

Tested with the TextureEncodingTest sample asset.

Slow to run in Chrome?

Feeding this back from myself and the 3D team at my work, we all find that the compressor runs very slow on the web, is there any plan to do a Windows/Mac/Linux build of this that runs local?

The wait times for compression can feel very long and Chrome on Windows 10/11 can often freeze for a few minutes running it as the only open tab.

I have used similar compressors such as gltfpack: https://github.com/zeux/meshoptimizer/releases and Needle Tools which run much faster natively https://needle.tools/

We are testing with models from the GLTF samples repo such as DamagedHelmet and BarramundiFish so these aren't big test models.

Just wondering if running on the web is what is causing the performance bottlenecks?

Anisotropy support

glTF-Compressor seems to be using an outdated version of glTF Sample Viewer, because anisotropy is not supported here.

1. Download a GLB which uses KHR_materials_anisotropy, for example https://github.com/KhronosGroup/glTF-Sample-Assets/blob/main/Models/AnisotropyStrengthTest/glTF-Binary/AnisotropyStrengthTest.glb
2. Go to https://phasmatic3d.github.io/glTF-Sample-Viewer-KTX-demo/
3. Drag and drop the GLB into the 3d view.

Result: Anisotropy is not being rendered. Also in the Advanced Controls tab KHR_materials_anisotropy is not shown under Disable Extensions.

2D compare display issue

Three issues with the 2d comparison view of a compressed texture:

1. Large 2D view is vertically flipped compared to the texture thumbnail.
2. Large 2D view is much darker than the texture thumbnail. This seems to apply to BaseColor but not to Normal nor to ORM.
3. Large 2D view has incorrect aspect ratio for displaying the texture.

Thanks!

Option to compress standalone textures?

The tool is fantastic!

However, is it possible to enable the ability to upload textures not attached to a GTLF model and compress them via the tool?

Error uploading a gltf file

Hello,

Based on this ticket : KhronosGroup/glTF-Blender-IO#1979

Seems that having multiple texture data linked to the same image data index causes the error (glTF file is valid anyway, tested on glTF validator)

https://drive.google.com/file/d/1_CYZ8Qh4znf5o4m2jYcBInGJHd5lIM9X/view?usp=sharing

Uncaught TypeError: Cannot read properties of null (reading 'checked')

Having an issue running any kind of texture compression on this glb. Any time i press the 'Compress Textures' button the following error toast is shown and the following error is logged to the console. This error also occurs when I select an options from the 'Select by Type' dropdown menu.

Error toast:

Console error:

glb:
human_heart_3d_model_fbx_gltf.glb.zip

Supporting Mipmaps?

Hi!

I noticed that support for embedding mipmaps is currently missing from glTF Compressor. Clients cannot typically generate mipmaps for compressed textures at runtime, so I think that would be an important addition when possible.

Possibly this depends on KhronosGroup/KTX-Software#464?

Suggestion: "revert compression" button

It would be helpful to have a "Revert Compressions" button which would discard new compressions on all selected textures, reverting them to their original formats.

Perhaps this could be added underneath the "Compress Textures" button.

Mockup:

Loading a glTF that already contains KTX assets

1. Download the glTF and BIN and KTX2 from https://github.com/KhronosGroup/3D-Formats-Guidelines/tree/main/samples/Duck/glTF-KTX-ETC1S/
2. Go to https://phasmatic3d.github.io/glTF-Sample-Viewer-KTX-demo/
3. Drag and drop the files into the 3d view.
   Result: an error message appears, and the "after" display is blackened (even though no compression has been initiated).
   

This bug might be related to
KhronosGroup/glTF-Sample-Viewer#473

Suggestion: larger hotspot for before/after slider

The hotspot for dragging the before/after vertical bar is 2 pixels wide, which makes it difficult to "grab".

Could we widen the hotspot to maybe 10 pixels wide, while keeping the vertical bar the same 2-pixel width?

Incorrect thumbnail aspect ratios with KTX

Hi, I noticed a small problem with KTX thumbnails.

Non-square KTX textures should render their thumbnails with non-square aspect ratios, but they do not.

1. Download a GLB which contains KTX2 assets inside it, for example https://github.com/KhronosGroup/3D-Formats-Guidelines/blob/main/samples/StainedGlassLamp/StainedGlassLamp-KTX-BasisU-Volume-ETC1S.glb
2. Go to https://phasmatic3d.github.io/glTF-Sample-Viewer-KTX-demo/
3. Drag and drop the GLB into the 3d view.
4. Go to the Texture Compressor tab.
5. Scroll to the end of the Texture Details list.
6. Open a new browser window (I'm using Chrome on Windows), and repeat the above except using a GLB with PNG/JPG textures, for example https://github.com/KhronosGroup/3D-Formats-Guidelines/blob/main/samples/StainedGlassLamp/StainedGlassLamp-JPG-PNG-Volume.glb
7. Compare the two windows side-by-side.

Result: non-square JPG/PNG thumbnails are shown with the correct aspect ratio, while the KTX thumbnails are always square. Non-square KTX textures should render their thumbnails with non-square aspect ratios.

Thank you!

Anisotropy compression error?

The anisotropyDirection texture seems to be malformed after compression.

Tested with the AnisotropyBarnLamp sample asset:
https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/AnisotropyBarnLamp/glTF-Binary

Compression settings:

Before/after:

Thanks.