Giter Site home page Giter Site logo

Comments (7)

jengelh avatar jengelh commented on August 16, 2024 1

Nah, rpmlint is a more of a distro matter. Thanks everyone here and for #337.

from vulkan-headers.

oddhack avatar oddhack commented on August 16, 2024

I don't know who is constructing the package you're installing, but in both the Vulkan-Docs repo and Vulkan-Headers, genvk.py has the exec bit set, so it sounds like something is being lost - I suggest reporting to to whomever provides vulkan-headers.noarch. The other scripts are all imported and would not even potentially be invoked directly. N.b. genvk.py can be invoked directly in arcane debugging circumstances, but normally is just called as 'python3 genvk.py' from makefiles and build scripts.

If that answers the question, please close. I don't think there's anything we can do in this repo.

from vulkan-headers.

oddhack avatar oddhack commented on August 16, 2024

(I should perhaps add, genvk.py has the exec bit set in my clone of Vulkan-Headers - I can't quite tell from the github UI whether that's true in the upstream but I don't know why it wouldn't be.)

from vulkan-headers.

MarijnS95 avatar MarijnS95 commented on August 16, 2024
$ git ls-files -s registry/genvk.py
100755 4cd362f02e343694c465f62f354d6e4773851a1c 0	registry/genvk.py

+x is set for ugo.

from vulkan-headers.

jengelh avatar jengelh commented on August 16, 2024

though genvk.py has the +x bit, cmake install does not transfer the bit over.

install(DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/registry" DESTINATION ${CMAKE_INSTALL_DATADIR}/vulkan)

I'm not versed in cmake, but systems like automake for example make a distinction between "data" and "scripts" (one gets installed -x, but other +x), and perhaps cmake has something similar you need to use.

apiconventions.py is -x in git (but still has #! line). This is where the question was aimed. The #! looks to serve just as a syntax hint, so me (as the packager) added an ignore directive.

from vulkan-headers.

juan-lunarg avatar juan-lunarg commented on August 16, 2024

I made a PR partially address this issue.
#337

Note this only fixes the problem for genvk.py. The other python files will need to be updated to not have the shebang. Since it looks like they aren't meant to be standalone python scripts (they look more like python modules).

Those files would need to be updated in the Vulkan-Docs repository:
https://github.com/KhronosGroup/Vulkan-Docs

from vulkan-headers.

juan-lunarg avatar juan-lunarg commented on August 16, 2024

Closing this issue since there is nothing more that can be done in this repository now that CMake preserves the file permissions as of #337

To fix the remaining rpmlint issues, that will need to addressed in https://github.com/KhronosGroup/Vulkan-Docs

from vulkan-headers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.