Giter Site home page Giter Site logo

Comments (7)

oddhack avatar oddhack commented on August 16, 2024 1

I should also clarify what the repository is actually for. There's a bunch of stuff in here which is a snapshot of generated files from published spec updates. The actual C/C++ header files are probably all that should be packaged by a downstream distro. The other stuff is not provided for developers using Vulkan in their apps, but for people doing downstream ecosystem components like CTS, validation layers, language bindings, and so on. That isn't made clear today.

from vulkan-headers.

oddhack avatar oddhack commented on August 16, 2024 1

@incertia please check if #408 helps clarify the repository contents / purpose.

from vulkan-headers.

oddhack avatar oddhack commented on August 16, 2024

Which modules?

from vulkan-headers.

incertia avatar incertia commented on August 16, 2024

It appears as if registry/genvk.py will attempt to import from

  • json_parser
  • schema_generator
  • json_generator
  • json_h_generator
  • json_c_generator
  • docgenerator
  • extensionmetadocgenerator
  • interfacedocgenerator
  • spirvcapgenerator
  • hostsyncgenerator
  • formatsgenerator
  • syncgenerator
  • jsgenerator
  • pygenerator
  • rubygenerator
  • reflib
  • validitygenerator

but they do not exist in the Vulkan-Headers registry.

It appears as if these imports have been around for a lot longer so either the missing generators should be added to Vulkan-Headers or genvk.py should be removed, but the latter does not seem correct as genvk.py still generates all of the C headers we want.

from vulkan-headers.

oddhack avatar oddhack commented on August 16, 2024

TBH I'm not sure why genvk.py is here, other than that some downstream repos use a similar script to build their targets using their own generators and want to be able to keep in sync with changes in genvk.py. It would take a very long time to check with every downstream consumer and find out if or how they're using this file, so I don't want to remove it. But there's no intention that people actually run the script in this repository for any of the targets it supports - you should be using Vulkan-Docs for that. I can add a note to that effect in the README if that would help.

(Edit: oh, I see this happened with some VulkanSC stuff was brought across to keep the repos more closely synced. I don't know what SC is using this for, if anything, but the point above remains.)

from vulkan-headers.

incertia avatar incertia commented on August 16, 2024

It would probably make sense to add a note in the README. This issue mostly arised because I saw genvk.py within archlinux's vulkan-headers package (based on this repository) but it didn't seem to work. The Vulkan-Docs based package only installs the HTML docs but that is a packaging issue.

from vulkan-headers.

incertia avatar incertia commented on August 16, 2024

LGTM

from vulkan-headers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.