kif-framework/lela

Lela iOS Perceptual Difference Testing Framework

lela's Issues

pod trunk push Lela.podspec

@phatmann Aimed at you.

Update pod spec to point to kif-framework repo.

Support KIF 3.3.0

Currently Lela doesn't support KIF 3.3.0 as the XCTest and OCTest sub-specs have been removed.

Rename LELA to KIF.Visual

@bnickel, I would like to rename LELA to KIF.Visual to make it clear that it is part of the KIF ecosystem and what its purpose is. Is this change okay with you?

Location of expected images is where?

Hello, I'm simply stumped on where to put the expected images in order to pass the test. The documentation states, "copy the images into your test bundle" ... but I'm too noob to know where/how to do that.

Expected Image cannot be found

I added the Expected in the acceptance tests folder and made sure that test bundle also had the image, but when I run the tests i get error saying that "Could not find expected image for Login Screen."

Code Snipet

#import "ImageDiffTests.h"
#import "KIF.h"
#import "KIFUITestActor+Lela.h"
#import "Lela.h"


@implementation ImageDiffTests
- (void)setUp
{
    [super setUp];
}
- (void)tearDown
{

    [super tearDown];
}
- (void)testLoginImage
{
    [tester expectScreenToMatchImageNamed:@"Login Screen"];
}

Login Screen.png-768x1024@1x~ipad,iOS7.1.png is the file with the bundle

What am I missing here?

Lela + use_frameworks!

For some reason (I have Swift only framework in tests) I use use_frameworks! in cocoapods, so Lela is getting compiled to its own .framework
So this function

+ (NSString *)directoryForExpectedImages
{
    return [[NSBundle bundleForClass:self] resourcePath];
} 

returns path for Lela.framework, not the testing target
but I have no means to override this from my test

imageWithContentsOfFile can't find the filepath error - expectScreenToMatchImageNamed

Hello. For some reason [imageWithContentsOfFile:] doesn't find the path file image, but using NSData it works, is anyone else having this problem? is anyone using Lela? :)

+ (UIImage *)expectedImageWithName:(NSString *)name
{
    NSString *fileName = [[self imageNameForScreenNamed:name] stringByAppendingPathExtension:@"png"];
    NSString *filePath = [[self directoryForExpectedImages] stringByAppendingPathComponent:fileName];
    NSData *data = [NSData dataWithContentsOfFile:filePath]; //I changed these next 2 lines
    return [UIImage imageWithData:data];
}

can you change it? I'm using cocoapods!

note: using iOS 8.3 with ipad 2 simulator

TIA!

Is Lela friendly with iOS9 and Xcode7?

Just curious, because we ported our app to Xcode7 and I'm having some interesting referential/dependency errors.

ld: warning: directory not found for option '-L/Users/klucas/Documents/Gannett/GIT/akira-ios/build/Debug-iphoneos'
"OBJC_CLASS$_KIFTestCase", referenced from:
OBJC_CLASS$_Lela_Visual_Tests in Lela_Visual_Tests.o
"OBJC_CLASS$_KIFUITestActor", referenced from:
objc-class-ref in Lela_Visual_Tests.o
"OBJC_METACLASS$_KIFTestCase", referenced from:
OBJC_METACLASS$_Lela_Visual_Tests in Lela_Visual_Tests.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

iOS 8 issues in simulator

The same test run on the ios7.0 simulator works but on the ios8 simulator fails to find the reference image. The following call seems to return nil on Lela.mm line 68:

    return [UIImage imageWithContentsOfFile:filePath];

I suspect it's related to this issue: http://stackoverflow.com/questions/25884382/ios-8-bundle-path-changes

Update dependency from KIF-next to KIF

KIF-next is marked as deprecated now that KIF 2 has been released. Lela should switch dependencies to the official version.

No adjustment of Pixel Threshold

Currently there is no ability to adjust the pixel threshold for image comparison.

Ideally this would be exposed as an option as demonstrated in this commit (on @Oleg-Ivanov 's fork) here 10485a9 .