kilgoretrout1985/django_infopush

Django reusable app, what allows to send web push.

django_infopush's Issues

india timezone

Hey, if i want to push notification at 11 am IST, what time I should put in admin

Drop Python 2 compatibilty

Django 1.11 will soon not be supported. Exactly end of April 2020. This is the last version to support Python 2.7. Support for Python 2.7 will end in little more than a month.

Currently it does not make much sense to write the code in a way that will support both Python 2 and Python 3. I'm writing here mainly because you don't state versions of Python that you plan to support nor versions of Django. But from the code itself I can see that you use decorators that enable both versions to work. I consider those redundant for the future and worth removing from this project.

DRY

Please, keep only one instance of documentation if you fail to maintain several ones.

I opened an issue recently. About the documentation.
Ok. You fixed it. But what about https://pypi.org/project/django-infopush/?

Maybe you'd better not to keep it at all? One doc at github is enough.

Groups of users

You can send push notifications to the whole site at once. Do you consider it worth it to have groups of users that can be managed independently? So you would have a group of people that want to have notifications about the weather in certain area and they would receive a notification about that but no one else? I need that kind of functionality but this library does not support that. If you consider it worthy I would like to implement it. But I first want to hear your opinion if I start to work on something like that.

Cookies: request for clarification in documentation

The app uses cookies. Cookies are not cached.

For example, we have a perfectly static page. And we use django_infopush.
If I'm not mistaken, two cookies are set: push_hash and csrftoken.

Could you clarify in the documentation everything about cookies. This is very important for many reasons main of which are:

1. Legal ones. A cookie is a tracking means connected with the personality of a user according to law of many countries.
2. Caching by means of Varnish, nginx etc.

Could you stipulate:

1. Which cookies does this app really uses (the name of each cookie and what is it necessary for).
2. To what third parties are these cookies been sent if they are. And for what purpose.
3. Recommendations on caching. Cookies are not cached. And they defeat cache. If these cookies are for third parties only, please announce that at the server we can easily cut them off for caching purpose (by Varnish or something ). If the cookies are for the the application, please give us some recommendations about how to cache pages. I mean that if caching by Varnish, nginx or the like is executed, not every request goes to Django at all. So, it would be really better to understand when the cookie is really necessary and when we can just discard it and return the cached page without touching Django at all.

Humanize

Django 3.0.8
django-infopush==1.7.9

I had to add

"django.contrib.humanize", # DJANGO_APP.

to INSTALLED_APPS for django-infopush to work properly.

The doc keeps silence on this. If this is necessary, please, add it to the doc.

I fail to receive push notifications in Firefox

Ubuntu 18.04.4 LTS

Firefox 78.0.2 (64 bits)

The problem: Firefox doesn't receive push notifications.

Video: https://yadi.sk/d/LiUKppY0QUXC5A

Screenshot of Ubuntu settings: https://b.radikal.ru/b06/2007/e9/867678db569d.png

In other words: Chrome receives push notifications.

And if I install django-webpush (https://github.com/safwanrahman/django-webpush) Firefox receives push notifications.

But with django-infopush, it doesn't. Threre is a possibilit tha I fail myself somewhere. But could you tell me if such a problem really exist or it is my fault with settings or something?