kinematics/gearswap-jobs

Repository for GearSwap lua files for various jobs

gearswap-jobs's Issues

COR.lua - Luzaf issues - Attempt to concatenate a boolean value

Hey folks,

I've been playing around with COR .lua's and Kinematics' has been a great one to reference, but it's kicking up an odd error for me when I use it:

Gearswap has detected an error in the user function self_command:
...)Windower4/addons/GearSwap/data/Kinematics_Cor.lua:342: attempt to concatenate a boolean value

In the script, line 342 reads:

msg = msg .. ', Roll Size: ' .. (state.LuzafRing.value and 'Large') or 'Small'

After some time looking through it, I'm unable to determine the problem or what a possible fix might be - any suggestions?
Interestingly, this error only occurs when the Luzaf ring variable (gs c toggle LuzafRing) is set to "off". While active, the script appears to run just fine.

Any help or fixes are greatly appreciated!

COR roll values

Puppet Roll and Drachen Roll are showing the wrong lucky/unlucky numbers.

Puppet should be lucky 3, unlucky 7, while Drachen should be lucky 4, unlucky 8.

SMN.lua

1. Line 58: Ramuh's Astral Flow is spelled "Judgement Bolt" which is incorrect, causing no gearswap to occur. The proper spelling is "Judgment Bolt."

2. Mana Cede and Elemental Siphon sets do not function. They must be added as midcasts. This is one example of how it's done to better understand this (added in job_midcast, preferably moved over to proper midcast system):

if (spell.english=='Mana Cede') then
        equip(sets.precast.JA['Mana Cede'])
    elseif (spell.english=='Elemental Siphon')  then
        equip(sets.precast.JA['Elemental Siphon'])
end

3. The "siphon system" is not working properly. As an example of a bad scenario, In the event of 2 dark weathers on a lightsday, a light spirit is used, which offers greatly reduced MP compared to a dark spirit.

Blue Mage, Not sure why a castingmode isn't working.

My Bluemage Sidecar: http://pastebin.com/7BCfem7X

Not quite sure why:

sets.midcast['Blue Magic'].Physical.Resistant
sets.midcast['Blue Magic'].Magical.Resistant

And sets like

sets.midcast['Blue Magic'].PhysicalStr.Resistant

Aren't working, I've tried looking at Blm.Lua and the Mode-Includes, but not sure why these won't work but sets like this do:

sets.midcast['Elemental Magic'].Resistant

SMN not equipping perp gear

Noticed that I'm not equipping perp gear after casting spells or doing abilities, still wearing Fast Cast set after refreshing myself. Only recently started doing this. Haven't changed anything in my gear swap sets so not sure why this is happening.

Lua Unknown

new issue getting it when i try to load all of my luas:
Lua error (unknown: 1) - path unexpected symbol '.'

A few more spell.skill instances using CamelCase

SCH.lua, on lines 448, 454
BLM.lua, on lines 272, 284
WHM.lua on line 262
RDM.lua on lines 230, 232

After merging in your latest commit fixing spell.skill, I noticed high tier nukes weren't switching sets in BLM.lua. Changing the above lines resolved the issue. (also noted other files with similar issue)

Thanks

lack of understanding

Hello sir.
I was wondering if you could help me at all. I once wrote a very simple XML for my dance and id like to know if there is a way to convert it to LUA. I lack the required knowledge to understand LUA for some reason (yet i understand XML). DO you know of a place that has some info for what i need or perhaps if you know what i need could you drop me a message please. Sorry to bother you with such trivia. Thank you kindly in advance.

Andias

BLM.lua custom spell map commit broke midcast for nukes

job_midcast is ignoring the new spellMap functionality you built in.
i.e. sets.midcast.FastRecast is being used unconditionally.

Thanks!

Set selecting is complicated in JP client

When called set_language('japanese'), i have to name sets in English and Japanese like this:

1. If i want to select gear for specific spells, i have to write that name in English. sets.precast["Provoke"]
2. If i want to select gear for specific maps, i have to write that name in English. sets.precast.Cure
3. If i want to select gear for specific types, i have to write that name in English. sets.precast.WhiteMagic
4. If i want to select gear for specific skills, i have to write that name in Japanese. sets.midcast["強化魔法"]
5. If i want to set custome class depends on buff, i have to write that name in Japanese because buff argument in job_buff_change() is Japanese.

I'm tired to check languages one by one. Is it impossible that put all logics in English?
Or please tell me the variables affected by set_language().
I want to write only gear names in Japanese.

BRD not changing instruments when casting 3rd song

it switches occasionally but most of the time it doesnt. i've tried switching between dummy and full length.

BRD.lua

Having an issue where auto-pianissimo feature gets stuck spamming pianissimo

Rev2 Paladin Quirks-

In comments Extra Defense sets say they apply over Defense & Melee sets, they don't seem to apply over Melee sets to me, even though when I use //gs c showtp it places a tag as if it should.
Also, should they perhaps be changed to apply over idle sets as well? Would be nice for Reraise&Knockback at least, but I could see a case for not doing so and just make more idle sets.

SCH.lua (330) attempt to call global update_gear_sets nil value

update_gear_sets(player.status)

That function doesn't appear to be set in SCH.lua.

Wanting to discuss certain gear admissions/omissions

I noticed in the Mote-Utility.lua that Twilight Cape and Zodiac Ring are given names for gear.ElementalRing.name and gear.ElementalCape.name, but I don't see those being used in any of the job files. I was wondering where these are being used and whether I should still bother carrying them around.

I noticed also the omission of certain "useful" items and was wondering why this was the case. For example:

*Pentalagus Charm offers +2 steal but isn't included in the steal set
*Haven Hose, Earthcry Earring and Stone Gorget enhance stoneskin effect but aren't included in midcast stoneskin set
*Carapacho Cuffs speeds up stoneskin casting but there is either no precast set for stoneskin or they aren't included
*Summoning Torque and Vox Grip offer small amounts of summoning skill but aren't being used for buff pacts (there is no default grip in the buff pact set)
*Estoqueur's Earring enhances fast cast but isn't included in precast fast cast sets

sets.self_healing Problem.

(Using Live, not dev Luas)

Not sure why but sets.self_healing only seems to work properly for Blu,combining with sets.midcast['Blue Magic'].Healing when targetting myself.

On Pld or Rdm though it does not properly combine when I cure myself, it simply uses sets.midcast.Cure regardless of target.

Perhaps I have to use a different set for combining with non-Blu cures? Or perhaps it's not implemented yet for healing magic?

SMN error

I'm getting a "Gearswap has detected an error in the user function self_command....attempt to concatenate field 'name' (a nil value)" error on the following line:

    add_to_chat(122,pet.name..' does not have a pact of type ['..pact..'].')

Brd dummy songs

I have /console gs c set ExtraSongMode Dummy set in macro but when I play the song the ranged Daurdabla does not equip. I do see it say changed to dummy mode in FFXI but it continues to only let me put up two songs. I didnt have this issue before i updated but now the dummy songs are now working. I could use some ideas as to what i might be doing wrong or if its possible since it just got updated its just not working.

SMN - attempt to index avatars fails

Using the raw SMN.lua from this repository, with the latest Mote-include and associated files, I summon Garuda (or any smn pet) and get this set of errors multiple times:

GearSwap: Lua error (runtime) - ...gram Files (x86)/Windower4//addons/gearswap/flow.lua:257
GearSwap has detected an error in the user function pet_change:
... Files (x86)Windower4/addons/gearswap/data/SMN.lua:397: attempt to index global 'avatars' (a nil value)

I appreciate your help with this whenever you have the time. Thanks!

cancel spells

couldnt speak to you on irc so i thaught id raise an issue here so you would be able to find it.

in mote-utility.lua you have:

function cancel_conflicting_buffs(spell, action, spellMap, eventArgs)
if cancel_spells_to_check:contains(spell.english) or cancel_types_to_check:contains(spell.type) then
if spell.action_type == 'Ability' then
local abil_recasts = windower.ffxi.get_ability_recasts()
if abil_recasts[spell.index] > 0 then
add_to_chat(123,'Cancel abort: Ability waiting on recast.')
eventArgs.cancel = true
return
end
elseif spell.action_type == 'Magic' then
local spell_recasts = windower.ffxi.get_spell_recasts()
if spell_recasts[spell.index] > 0 then
add_to_chat(123,'Cancel abort: Spell waiting on recast.')
eventArgs.cancel = true
return
end

end

and it just wasnt working propally for me. the add_to_chat wasnt fireing ect.
Anyway through alot of testing ect, i found that spell.index is off by 1.
If you use ""if spell_recasts[spell.index + 1] > 0 then"" it works flawlessly.
noticed you dont have the function utilised in your gearswap job files and figured it may be cos it doesnt work, anyway this fixes it for me. hope this helps.

Scholar Desert boots

I've tried numerous things, but I'm just unable to have my Desert boots equipped when sandstorm buff is on my scholar. I'm not sure why it's not working.

SCH Perpetuance + Regen equips

Initially I thought this was an issue on my end and my customizations, but after testing this out on a completely unaltered sch lua, it still persists.

The issue only happens when you use perpetuance and follow up with a regen spell (Regen V in this case). What happens is that it will equip precast and then midcast. However, it will immediately equip aftercast as well, thus not applying any gear potency/duration bonus.

The chances this happens seems completely random. Sometimes it does this, sometimes it doesn't.
Mostly when you cast regen V quickly after using perpetuance, but it sometimes also happens when there's a pause in between.

Again, this is an empty sch lua that just has the gear adjusted. Any ideas?

Sch.lua

I have included this file and have noticed that the pedagogy loafers do not load when you use ja then i tried other items and it seems to be the case for all gear for job ability. I downloaded the Brd.lua and the ja gear changes with no problem. Thanks for the help Im new to this program so my be user error.

File too large for GS?

I'm having a little issue and I was wondering if it's possible because of file size. Is there a limit in size that GS can handle without hickups? Sometimes after a WS, my gear won't swap back to engaged gear, and other times it will. Likewise, I created a regen counter for my SCH that is accurate. Most of the time it will work perfectly, but sometimes it will be inaccurate. Meaning it was not able to identify a piece of equipment at the time of timer creation.

The way I've done all my alterations is to put all of them in pretty much 1 file. My own include. It will have all the functions of all my jobs and characters that are different from mote's job lua file. It's always worked fine, but now it's having these issues. This file is now 651 lines long. Is this simply too long? If it is, I can split up the codes by character, which isn't an issue, but would like to keep it like this if possible.

Sneak spell not replacing sneak buff

When casting Sneak or Spectral Jig it does not replace the sneak buff if it's already active. I've added these lines in to remove the sneak buff before casting just before the End at the first If/End in the job_midcast function:

Jobs using WHM/SCH/RDM:

elseif spell.english == 'Sneak' and buffactive.sneak and spell.target.type == 'SELF' then
    send_command('cancel 71')
    cast_delay(0.3)

Jobs using DNC:

elseif spell.english == 'Spectral Jig' and buffactive.Sneak then
    send_command('cancel 71')

SMN wearing wrong idle set with avatar active

I noticed after the recent changes to the job files that when idle with an avatar I'm wearing the set for idle status, not idle.Avatar status. It's also affecting using bloodpacts so I'm regularly getting "No avatar currently present" reports in my chat log, which makes me believe that the file isn't recognising whether an avatar is present. I tried reverting back to an untouched SMN.lua file straight from the repository and it's doing exactly the same so it's not to do with any changes I've made to it.

Updates for newest FFXI builds?

Unfortunately I had to clear one of my drives with all the data which meant my personal stuff is gone which included swapping in/out Mecistopins Mantle in Adoulin areas as well as many other things which I feel should already be included (eg. new Empyrean reforged conditions for BRD, new avatar bloodpacts, use of multi-element obis/torques etc.) Will we be seeing new updates for the libs and job files that already include these?

Wondering also when we'll see examples for DRG, DRK and WAR.

Mote-Utility.lua:14 Attempt to Call global 'error' (a nil value)

I got the following error
Mote-Utility.lua:14: attempt to call global 'error' (a nil value)

I also updated that file to the one that was updated 5 minutes ago in attempt to fix it, shows same problem on reload.