kislayverma/rulette

A pragmatic business rule management system

• Rulette homepage
• Documentation
• Support Rulette
• The server version - REST API and UI server

rulette's Issues

Separate rulette-rest into an independent project

Add a better way of determining if a rule input is "Any'

The only way to do this right now is to check for NULL or "". This leaks out implementation detail of what constitutes 'Any', in addition to making the calling code ugly and fragile.

We should build a better interface to this info (maybe via a 'isAny()' method on rule input class)

rule_id should be treated as String

A rule_id (rule primary key) can be anything, and so should be treated as String

Determination of best fitting rule for is broken for range inputs

Add APIs for creating/updating/deleting rule systems

Add support for SQLite

Move SimpleMysqlUse from examples to mysql provider module as an integration test

Too many connections issue

The rule engine open a lot of connections pool to the database without closing them which cause the [Too many connections] exception

Add support for unbounded range in range inputs

We should be able to specify ranges going till infinity

Publish the maven site on Github pages

Value of the output is assumed to be a number

Using non-numbers (string, date etc) results in NumberFormatException

Put lower and upper bounds of ranges in 2 different column

The current way of defining ranges by saying "0-500", "a-z" is ugly. It would be a lot better to store the upper and lower bounds in 2 different columns of the rule table.

[feature] multi tenancy shared database type

Great tool and very usefull , thank you

i think it will be better if the tool also provider the shared database multi tenancy modal, it's more performance than the multiple database schema

Generate Sphinx documentation and publish to readthedocs

Read the doc location - http://rulette.readthedocs.io/en/latest/

Revisit signatures throwing "Exception" and use specific exceptions as needed

Adding conflicting rules does not fail rule engine instantiation

Found this issue by #59

Provide a better way of accessing lower and upper bounds of range inputs

The only way to do this right now is to getRawValue() and split on '-' which is just clumsy. We need to devise a way which is cleaner than this and still consistent across both value and range inputs.

Separate gaia classes into a testing-commons modules

These classes should only be used for testing, so we should move them to separate testing only module so that all modules can use them.

Add support for executable rule inputs

Instead of rule inputs being fixed values, we should allow them to be arbitrarily executable pieces of code. This will allow definition of custom logic instead of static values.

A few things to consider here.

1. Performance may be impacted if the logic is intensive.
2. What data be passed to these inputs and how.
3. Does this mean a new rule input type (e.g. 'EVAL') and how does that play with the data type construct.

This is also a significant deviation from the current simple approach of Rulette towards rule inputs, viz that of treating them as stored "values". With this, we shift more towards Drools style rule "execution", although we may be able to support both modes.

Remove joda-time and use the Java 8 date time APIs instead

This will further reduce the dependency footprint and artifact size

null sent for evaluation to a range input creates NPE

It should be read as 'Any'

IDataProvider implementation should be mandatory to create a rule system

Since rule system data is now provided via an injected IDataProvider implementation, rulette-core should be independent of how this data is stored and retrieved.

This means that the injected implementation is mandatory, not optional as it is currently.

Provide support for NoSQL databases.

@kislayverma Do we have a plan/vision to extend to NoSQL DB ? We can start from MongoDB.

Add API to add/delete rule input

Add support for a boolean data type

We should have first class support for boolean rule inputs instead of having to interpret "1","0", "true" etc as boolean representations

Improper query built for update of range columns by MySQL provider

The update query built by the MySQL provider does not use the underlying upper-lower range bound columns of a range input. It tries to update it like a single column. Hence the update API is broken for any rule system containing range inputs.

Design a logo

Update example SQL scripts

The setup and example SQL scripts under the. mysql provider are the latest ones. All other modules have outdated setup files as examples.

Improve lookup of matching values in Range inputs

The current lookup complexity of valid range input lookup in rule evaluation is O(n) as the engine iterates over all ranges to find matches. Evaluate using alternate data structure to improve this.

Add a full case study of Rulette use

Upgrade mysql connector to version 8.0.14

Take unit test coverage on rulette-core to 20%

Add support for postgres

API to get all known rule systems under a provider

This will help in the discovering all rule system when used under rulette-server

Raw value of null range input should be returned as blank, not "-"

Travis integration is broken

Builds are getting triggered on Travis, but completion status is not updated on the PR

Identical rules in sample-rulesystem-setup.sql

Steps to reproduce:

1. Create a sample rule-system using the sample-rulesystem-setup.sql script.
2. Run SimpleMysqlUse class.
3. Prints the following error:

[main] INFO com.github.kislayverma.rulette.example.mysql.SimpleMysqlUse - ==========Update a rule==========
Exception in thread "main" java.lang.Exception: The rule to be deleted and the rule found are not the same.Something went horribly wrong
	at com.github.kislayverma.rulette.engine.impl.trie.TrieBasedEvaluationEngine.deleteRule(TrieBasedEvaluationEngine.java:157)
	at com.github.kislayverma.rulette.RuleSystem.updateRule(RuleSystem.java:240)
	at com.github.kislayverma.rulette.example.mysql.SimpleMysqlUse.updateRule(SimpleMysqlUse.java:129)
	at com.github.kislayverma.rulette.example.mysql.SimpleMysqlUse.runSamples(SimpleMysqlUse.java:110)
	at com.github.kislayverma.rulette.example.mysql.SimpleMysqlUse.run(SimpleMysqlUse.java:46)
	at com.github.kislayverma.rulette.example.mysql.SimpleMysqlUse.main(SimpleMysqlUse.java:35)

From my debugging, I believe the cause of this to be these identical rules in sample-rulesystem-setup.sql script:
(192,'WES',3,NULL,NULL,NULL,'4'),(196,'WES',3,NULL,NULL,NULL,'4')

Proposed fix: Use NULL as the source_state for ruleId 196.

Use HikariCP instead of c3p0 as mysql provider's connection pool