kiwikern/shassi-nest

Shassi

Description

Shassi is a shopping assistant helping you to keep track of products you are interested in and notifying you when price or availability change.

Installation

$ npm install

Create a development.env file. You can use the development.env.sample file.

Running the app

# development
$ npm run start

# watch mode
$ npm run start:dev

# incremental rebuild (webpack)
$ npm run webpack
$ npm run start:hmr

# production mode
$ npm run start:prod

Test

# unit tests
$ npm run test

# e2e tests
$ npm run test:e2e

# test coverage
$ npm run test:cov

# linkt
$ npm run lint

shassi-nest's Issues

Edit product added messages on size chosen

When a product is added and the user is asked to choose a size, edit the original bot message instead of sending a new one. (Might be better to place an error in a new message instead.)

Add deployment script on tag change

Reformat on commit with prettier

see also https://github.com/prettier/tslint-config-prettier

Telegram controller should use correct tag for swagger

shassi-nest/src/telegram/telegram.controller.ts

Line 12 in bce1365

@ApiUseTags('products')

swagger param data type

The string params are transformed to other datatypes by @Pipe(), e.g. to ObjectId.
The UI then does not accept a string param, because it expects ObjectId instead of string:

Weekday/Cos Bot fails on production

It works on dev but fails on production. Adding more log output might help to debug.

add crawler for and other stories

/help command for telegram bot

Implement a /help button (shows up in bots profile)

https://core.telegram.org/bots#commands

Delete older products

If a product is unavailable for more than 3 (?) months, then set it as inactive.

Should handle mobile pages

e.g. https://m2.hm.com/m/de_de/productpage.0648348004.html

Actions on reply to message

When replying to a bot message show some actions like /delete /history /favorite /unfavorite as buttons. When replying with a command / keyword, then immediately run action.

Handle URLs with query params

https://www.cosstores.com/en_eur/men/menswear/coats-jackets/product.wool-blend-bomber-jacket-green.0699030001.html?utm_source=newsletter&utm_medium=email&utm_campaign=2019_SUN_W07_EU&utm_content=re_actives returns invalid URL. The query params should be ignored.

Travis: unit test job does not fail

Because the coverage results are piped to coverall, the job never fails.

Add more than 3 telegram button rows

For example https://www2.hm.com/de_de/productpage.0748354001.html has more than 24 sizes. 8 buttons in one row are often not readable. Make sure not more than 6 (?) buttons per row

Migrate run / build scripts

https://trilon.io/blog/announcing-nestjs-monorepos-and-new-commands

Integrate telegram seamless auth

?id=123456&
first_name=Afdad&
last_name=Adass&
username=username&
photo_url=https%3A%2F%2Ft.me%2Fi%2Fuserpic%2F100%2Fusername.jpg&
auth_date=1559403541&
hash=d0e...197

add rate limits

see

• https://www.npmjs.com/package/express-rate-limit
• https://www.npmjs.com/package/express-slow-down

Add the nest swagger plugin

https://trilon.io/blog/nestjs-swagger-4-whats-new

Refactor: use cos/weekday base class for h&m

The APIs are very similar. Should use the same base class.

Create telegram endpoint for connection status per user

should return { hasToken: boolean }

React on 410 Gone response

A product request to snipes fails with 410 when the product is not available anymore. This response should set isInCatalog to false.

Health Check

• Make sure that Telegram connection is still established. Restart automatically when it's down.
• Check for crawler connection.

Use German time zone instead of server time

Server time one heroku is GMT, German is GMT+1 or +2 (daylight saving time). Set it in the node-cron constructor: 'Europe/Berlin'

Use tsc-watch instead of ts-node in development

Only relevant for debug as for development webpack hotreloading is used.

Handle H&M products availability without size

Product with ONESIZE is sold out but isActive=true
https://www.hm.com/de/de/product/16712?article=16712-A

Publish releasenotes via Telegram

Should be possible to increase engament by publishing fixes or newly supported stores via Telegram. Maybe sending custom messages via an additional admin module.

Add security headers

see https://scotthelme.co.uk/a-new-security-header-feature-policy/

Add concurrency control

Not all product updates should be started concurrently. Add a backstop.

ConfigService refactoring

Should be getter for consistency

shassi-nest/src/config/config.service.ts

Line 17 in 14faab7

this.isProduction = process.env.NODE_ENV === 'production';

Add new values to .env

shassi-nest/development.env.sample

Line 11 in 14faab7

PORT=

Create ObjectId pipe

Instead of creating ObjectIDs from url params, create a pipe for the transformation. If the given ObjectID is invalid, throw a BadRequestException.

Update to typeorm 2.1.17 breaks indices

There have been a couple of changes to mongodb indices. This update breaks the indices:

2019-05-14T23:31:39.268+0200 E INDEX [TTLMonitor] ttl indexes require the expireAfterSeconds field to be numeric but received a type of null, sk
ipping ttl job for: { v: 2, unique: true, key: { userId: 1 }, name: "IDX_ca94189f5dcaefdae0d98de623", ns: "shassi_test.telegram-user-ids", sparse:
false, background: false, expireAfterSeconds: null }

https://github.com/typeorm/typeorm/blob/master/CHANGELOG.md#0217-2019-05-01