Content-Type sometimes incorrectly set in HTTP responses

[julianharty]

Content-Type sometimes incorrectly set in HTTP responses

[julianharty]

Thanks to ferreting around, reading up, and some experimentation I think I've found a fix - to allocate memory from the relevant Apache memory pool and copy the contentType to it.

A very useful clue was found in https://lists.gt.net/apache/users/375588
I've extracted the following text below:

"We developed an Apache module. In the module, when we sent HTTP
response, Apache always changed the "Content-Type", sometimes this field
is correct, sometime it is truncated, sometimes with an invalid value.
We sent response back with the following function, and the response
header was always set properly.

int our_module_handler(request_rec *r)
{
// process requests
// prepare response
ap_set_content_type(r, "application/user-config+xml");
ap_send_http_header(r);
ap_rwrite(..);
return OK;
} 

We added some logs before and after the above calls, and found the
content-type is always right. However, sometimes (not always), in the
response sent by Apache server, Content-Type will be changed to
something like "application/user-config" or
"application/user-config+xm", or some other values."

Followed by Eric's response which unlocked the clue for me:
"I suspect its your modules own misuse of r->pool. Completely gut all
of your actual logic from your module and see if it still truncates
the header.

Or start with a new module that just sets the content type and prints
a canned response.

--
Eric Covener
[email protected]"

[kelson42]

@julianharty Please check the ZIM file is not basically wrong (with zimdump) before assuming something is wrong in your code or in the code of the kiwix lib.

[julianharty]

My initial test is contained in the following commit 766838e This seems to do the trick I next want to review the overall code of the module and start tidying it up since it's starting to get too messy and insufficiently modular.

[mossroy]

I confirm it solves the content-type issue for me : good work!