kjhjason/cultured-downloader-cli

Command-line version of the original Cultured Downloader Python program

I'm Jason from Singapore.

I mainly write code in Golang, Rust, and Python.

Go check out my website at kjhjason.com for more information about me like my experiences, skills, etc.

Anilist - Favourites & Watching

Spotify - Recently Listened

Reach Me At

cultured-downloader-cli's Issues

panic: runtime error: invalid memory address or nil pointer dereference

Which Operating System are you running the program on?

Windows

Program Version

latest

Steps to reproduce the bug

Randomly started having this issue

Warning: reCAPTCHA detected for the current Fantia session...
▐⠂ ▌ Solving reCAPTCHA for Fantia...panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x18 pc=0x1504bcb]

goroutine 1 [running]:
github.com/KJHJason/Cultured-Downloader-CLI/api/fantia.autoSolveCaptcha(0xc00031f9e0)
E:/Codes/Github Projects/Cultured-Downloader-CLI/src/api/fantia/api.go:139 +0x6cb
github.com/KJHJason/Cultured-Downloader-CLI/api/fantia.SolveCaptcha(0xc00031f9e0, 0xe0?)
E:/Codes/Github Projects/Cultured-Downloader-CLI/src/api/fantia/api.go:201 +0xb5
github.com/KJHJason/Cultured-Downloader-CLI/api/fantia.dlFantiaPost(0x1, 0x9d, {0xc00000bb17, 0x7}, 0xc00031f9e0)
E:/Codes/Github Projects/Cultured-Downloader-CLI/src/api/fantia/api.go:250 +0x33b
github.com/KJHJason/Cultured-Downloader-CLI/api/fantia.(*FantiaDl).dlFantiaPosts(0xc000310550?, 0xc00031f9e0)
E:/Codes/Github Projects/Cultured-Downloader-CLI/src/api/fantia/api.go:287 +0xc5
github.com/KJHJason/Cultured-Downloader-CLI/api/fantia.FantiaDownloadProcess(0xc000310550?, 0xc00031f9e0?)
E:/Codes/Github Projects/Cultured-Downloader-CLI/src/api/fantia/fantia.go:21 +0x5a
github.com/KJHJason/Cultured-Downloader-CLI/cmds.init.func1(0xc0006de000?, {0x179454b?, 0x4?, 0x179454f?})
E:/Codes/Github Projects/Cultured-Downloader-CLI/src/cmds/fantia.go:105 +0x42d
github.com/spf13/cobra.(*Command).execute(0x21a83c0, {0xc0006fa820, 0xa, 0xa})
C:/Users/Admin/go/pkg/mod/github.com/spf13/[email protected]/command.go:987 +0xab1
github.com/spf13/cobra.(*Command).ExecuteC(0x21a8f40)
C:/Users/Admin/go/pkg/mod/github.com/spf13/[email protected]/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(0x60?)
C:/Users/Admin/go/pkg/mod/github.com/spf13/[email protected]/command.go:1039 +0x13
main.main()
E:/Codes/Github Projects/Cultured-Downloader-CLI/src/cultured_downloader.go:19 +0x55

Expected behaviour

Captcha should be resolved

What error code did you receive? (If any)

N/A

Relevant log output (If any)

No response

Screenshots (Optional)

No response

Fantia Error 422 when trying to download posts

Hello, I tried downloading a fantia author's posts using the following command:

cultured-downloader-cli.exe fantia --cookie_file="C:\Users\dbx\Downloads\fantia.jp_cookies.txt" --fanclub_id 314832

And I got these errors for every posts in the log:

Cultured Downloader CLI V1.2.1 [ERROR]: 2023/08/13 18:15:18 fantia error 422: failed to get post details for https://fantia.jp/api/v1/posts/2167948

I also tried using the command with the session id while removing the cookie_file arg and I got the same error.

[Bug]: Downloading from Kemono always fails with 400 Bad Request

Which Operating System are you running the program on?

Windows

Program Version

1.2.4

Steps to reproduce the bug

1. Try downloading anything from Kemono by specifying --creator_url and -s
2. The log will say Cultured Downloader CLI V1.2.4 [ERROR]: 2024/04/15 17:38:27 the request to ... failed after 4 retries, status code => 400 Bad Request

Expected behaviour

The download not failing.

What error code did you receive? (If any)

N/A

Relevant log output (If any)

Cultured Downloader CLI V1.2.4 [ERROR]: 2024/04/15 17:38:27 the request to https://kemono.su/api/v1/fantia/user/19235 failed after 4 retries, status code => 400 Bad Request

Screenshots (Optional)

No response

parse generated JSON cookies instead of just netscape cookies

Since Get-cookies.txt-LOCALLY has added an option to generate a JSON format of the exported cookies, can consider adding an option for a JSON cookie file as well.

Pixiv Fanbox cookie is invalid

I am trying to run .\Cultured-Downloader-CLI.exe -fanbox_session -fanbox_post through cmd but I am getting an error: "Pixiv Fanbox cookie is invalid"

I've tried closing and opening chrome but I got the same error. I am using the FANBOXSESSID option in <id>. How can I fix this?

Concurrent download

Could you add support for concurrent download for multiple files at the same time to speed up the download?

Golang isn't required

No matter if python or golang it won't affect the download speed, the matter is the startup time which could be slightly different, i don't which one further than the other, since i don't know what stuff golang loads.

About the concurrency, python have many ways to do concurrency, asyncio, threading etc.

Python is better in terms that it does not require compiling, then is less work to the user, specially if he don't have golang installed

Add support for Get cookies.txt files

add page num support for other download modes

Currently, only Pixiv tag search has page number support.

[Bug]: Dots in post title causing a bug

Which Operating System are you running the program on?

Windows

Program Version

Cultured Downloader CLI V1.2.2

Steps to reproduce the bug

. \ . \ src >cultured-downloader-cli pixiv --refresh_token="[my token]" --artwork_id 109920652

Expected behaviour

instead of getting folder, i got this file with smaller file size and with no extension name,
i tested this with only just this " --artwork_id 109920652 "
it happened not only with this id but some other id too like " --artwork_id 100885659 "

some id work fine and got folder and image
but some got this file.

• apologize for my poor grammer and spelling *

What error code did you receive? (If any)

N/A

Relevant log output (If any)

no error ,everything is find,

Screenshots (Optional)

[Bug]: "error opening log file" after formatting pc

Which Operating System are you running the program on?

Windows

Program Version

1.2.2

Steps to reproduce the bug

1. launch CMD in folder containing the .exe
2. Insert command:
   cultured-downloader-cli fantia --cookie_file="X:\folder1\folder2\cultured-downloader\cookies.txt" --fanclub_id 123456 --page_num "" --gdrive_api_key (myapikey) --auto_solve_recaptcha=false
3. receive "error opening log file" as response

Expected behaviour

Program works as intended and asks for recaptcha then begins downloading

What error code did you receive? (If any)

N/A

Relevant log output (If any)

2024/02/20 00:49:36 error opening log file: open C:\Users\user\AppData\Roaming\Cultured-Downloader\logs\cultured_downloader-cli_v1.2.2_2024-02-20.log: The system cannot find the path specified.
log file path: C:\Users\user\AppData\Roaming\Cultured-Downloader\logs\cultured_downloader-cli_v1.2.2_2024-02-20.log

Screenshots (Optional)

No response

Add support for text file of URL(s) to download

Upload to Cloud Storage Solutions

Could consider backing up the downloaded files to Cloud Solutions like GCP and AWS in the event of hardware failures or when running out of storage on local drives.

Rework CLI with the reworked Cultured Downloader Logic repo