kjleitz/adornable

Use decorators on Ruby methods!

adornable's Issues

Merge the syntax for :memoize and :memoize_for_arguments

Is there a technical reason to separate syntax to memoize methods with or without arguments? If method accepts any arguments it doesn't make much sense to memoize the same result for different arguments. I used to use the Memoist gem. The syntax there is the same regardless if the method accepts arguments. Arguments passed to the methods are always used as a part of the cache key.

I am not sure if this qualifies as the issue per se. I guess this is a suggestion to just use one syntax for both variants. :-)

decorators inside singleton classes

Why can't I add decortors inside singleton classes? I get that the error is saying name isn't defined for the singleton class, but why do we need it?

require 'adornable'

class Decorators
  def self.time(context, stat:, &block)
    start_time = Time.now.utc
    begin
      return yield
    ensure
      end_time = Time.now.utc
      duration = (end_time - start_time) * 1000.0
      puts "#{stat} #{duration}ms"
    end
  end
end

class Dog
  class << self
    extend Adornable

    decorate :time, from: Decorators, stat: 'bark'
    def bark
      sleep 1.3
    end
  end
end

Dog.bark

Traceback (most recent call last):
        3: from adornable.rb:16:in `<main>'
        2: from adornable.rb:17:in `<class:Dog>'
        1: from adornable.rb:20:in `singleton class'
/Users/jaredw/.rbenv/versions/2.7.6/lib/ruby/gems/2.7.0/gems/adornable-1.2.0/lib/adornable.rb:18:in `decorate': Decorator name must be provided. (Adornable::Error::InvalidDecoratorArguments)

  def decorate(decorator_name, from: nil, defer_validation: false, **decorator_options)
    if Adornable::Utils.blank?(name)
      raise Adornable::Error::InvalidDecoratorArguments, "Decorator name must be provided."
    end