Giter Site home page Giter Site logo

Comments (7)

kkomelin avatar kkomelin commented on June 2, 2024

Thanks for reporting it @lucamerighi !

Can you provide the full code sample with DOMPurify.sanitize() parameters?

Did you try 2.7.0 ?

Because isomorphic-dompurify is just a wrapper around dompurify, it also makes sense to report the issue to the dompurify issue queue.

from isomorphic-dompurify.

lucamerighi avatar lucamerighi commented on June 2, 2024

Sure, here's the complete snippet

DOMPurify.sanitize(
  `
<html lang="en">
<head>
    <title>Sample HTML5 Page</title>
</head>
<body>
    <p>Hello</p>
    <br>
</body>
</html>`,
  {
    PARSER_MEDIA_TYPE: "application/xhtml+xml",
  }
);

Tried with 2.7.0 and same empty output. Removing the <br> gives the expected output

from isomorphic-dompurify.

kkomelin avatar kkomelin commented on June 2, 2024

@lucamerighi Thanks. For XHTML, can you use self-closing tags like this <br/>?

from isomorphic-dompurify.

lucamerighi avatar lucamerighi commented on June 2, 2024

Yes, in XHTML you can use self closing tags. In fact, you have to convert all void elements to their self-closing variant for it to be valid

from isomorphic-dompurify.

kkomelin avatar kkomelin commented on June 2, 2024

@lucamerighi Well, it's definitely a question/issue for dompurify developers. I'm afraid I'm not very familiar with internal stuff, so I can't help here.

And I should not suggest switching to the default PARSER_MEDIA_TYPE because you're probably using it for a reason.

from isomorphic-dompurify.

lucamerighi avatar lucamerighi commented on June 2, 2024

Opened the issue there 🤞 Ye I need it for this reason exactly, parsing HTML into valid XML which between other means means fixing this kind of stuff

from isomorphic-dompurify.

kkomelin avatar kkomelin commented on June 2, 2024

According to the dompurify maintainer, the behavior is by design cure53/DOMPurify#938 (comment) , so I'm closing this issue too.

from isomorphic-dompurify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.