klaytn/klaytn-contracts-old

klaytn-contracts-old's Issues

contract code solidity version 관련 문의

안녕하세요.

혹시 현재 klaytn-contracts 내에 있는 contract code들의 solidity version update 계획이 있으신지 문의드립니다.

https://medium.com/klaytn-kr/klaytn-ide-%EC%97%85%EB%8D%B0%EC%9D%B4%ED%8A%B8-9655eb2b6087

상기 링크에서 Klaytn IDE가 solidity 0.8.11까지 지원되도록 업데이트되었다고 나와있는데 Contract Code는 아직 0.5.0 버전으로 작성되어 있는 것 같아서 문의드립니다.

혹시 계획이 없으시다면, 해당 contract code의 compiler 버전을 임의로 올려서 돌리려고 하면 문제가 발생하게 될까요?

감사합니다.

Solc 0.6.6

Would you mind consider to release a newer npm package for solc >= 0.6.6, Thanks!

Fails to run Local Klaytn Network

When I run following command after pulling master branch, installing required packages, and running ganache without any configuration changes, it prints out an error.

➜  klaytn-contracts git:(master) ✗ npm run run:klaytn            

> [email protected] run:klaytn /Users/kakao/work/klaytn-contracts
> ./test/prepare.sh

~/work/klaytn-contracts/test ~/work/klaytn-contracts
~/work/klaytn-contracts ~/work/klaytn-contracts/test
./init_accounts.sh: line 7: jq: command not found
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (7) Failed to connect to localhost port 8551: Connection refused
FUND_ADDR = 
curl: (7) Failed to connect to localhost port 8551: Connection refused
(node:56739) UnhandledPromiseRejectionWarning: TypeError: Cannot read property '0' of undefined
    at /Users/kakao/work/klaytn-contracts/test/init_accounts.js:9:26
    at Object._fireError (/Users/kakao/work/klaytn-contracts/node_modules/caver-js/packages/caver-utils/src/index.js:63:9)
    at /Users/kakao/work/klaytn-contracts/node_modules/caver-js/packages/caver-core-method/src/index.js:255:22
    at /Users/kakao/work/klaytn-contracts/node_modules/caver-js/packages/caver-core-requestmanager/src/index.js:151:28
    at XMLHttpRequest.request.onreadystatechange (/Users/kakao/work/klaytn-contracts/node_modules/caver-js/packages/caver-core-requestmanager/caver-providers-http/src/index.js:122:13)
    at XMLHttpRequestEventTarget.dispatchEvent (/Users/kakao/work/klaytn-contracts/node_modules/xhr2-cookies/dist/xml-http-request-event-target.js:34:22)
    at XMLHttpRequest._setReadyState (/Users/kakao/work/klaytn-contracts/node_modules/xhr2-cookies/dist/xml-http-request.js:208:14)
    at XMLHttpRequest._onHttpRequestError (/Users/kakao/work/klaytn-contracts/node_modules/xhr2-cookies/dist/xml-http-request.js:349:14)
    at ClientRequest.<anonymous> (/Users/kakao/work/klaytn-contracts/node_modules/xhr2-cookies/dist/xml-http-request.js:252:61)
    at ClientRequest.emit (events.js:400:28)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:56739) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:56739) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
~/work/klaytn-contracts/test
~/work/klaytn-contracts

But, all tests just work well with $ npm run test:ganache.

Prerequisites에 추가 부탁드립니다

안녕하세요!
test/init_accounts.sh에 jq가 기본 프로그램이 아니라서, 오류가 계속 발생하고 있었습니다,
번거롭지 않다면 prerequisites에 포함시켜 주시면 좋을거 같습니다 🙏

MACOS사용자라면 아래를 참고 부탁드립니다

brew install jq

test/ 내 코드에 두가지 목적의 소스코드가 혼재되어 있어, 사용성이 떨어졌습니다. *.sh로 이루어진 코드들은 로컬 클레이튼 서버를 띄우기 위해 구성된 소스코드이고, 그외 코드는 테스트 대상 코드라고 비추어져서, 로컬 클레이튼 서버를 띄우기 위한 코드가 분리되는 게 어떨까 합니다.

그래서 로컬 노드를 배포하는 로직을 별도로 나누어, 아래와 같이 리파짓토리로 구성하였습니다.

• klaytn-local-node

클레이튼 개발 화이팅입니다!

KIP7Metadata.sol

I think it should inherit KIP7 not IKIP7

Update npm package

Deployed npm package is not latest.

Will you update it?