kleros/escrow-contracts

Escrow Smart Contracts

Escrow Contracts

Deployed Addresses

• Kovan: <none>
• Mainnet: <none>

Contributing

Install Dependencies

yarn install

Run Tests

yarn test

Compile the Contracts

yarn build

Run Linter on Files

yarn lint

Fix Linter Issues on Files

yarn fix

escrow-contracts's Issues

Pre-Review MultipleArbitrableTransactionWithAppeals.sol

https://docs.google.com/document/d/1BSWCDNEVySCy0UQYMKsdlNLkhr4xxQ8aqTQXUUXSOVA/edit?usp=sharing

Review by @nix1g

Review @ 4a682e0

Major

MultipleArbitrableTokenTransactionWithAppeals.sol

Reentrency

L262 does not prevent reentrency: the variable is only modified in memory and this change is not stored before the call to transfer.

Minor

ETH	Token	Issue
L56	L64	ruling should be of type enum Party.
L412	L437	Condition can be simplified to _side != Party.None.
L427	L451	Expression can be simplified to block.timestamp < (appealPeriodEnd + appealPeriodStart) / 2.
L18, L411-L461	L25, L436-L487	This is the only place where CappedMath is used, and with controlled (i.e. trusted) values. I would remove it altogether.
L419	L444	Variable scoping is not necessary.

Consistency issues and linting

• Both files are very similar, they should be easily diff-able (aim to reduce discrepencies like the use of uint vs uint256, trailing spaces, comments wording...).
• To use solhint efficiently, you should explicitely state the warnings you want to ignore in the code using solhint-disable and solhint-disable-next-line.