ORMB login should work with docker token

[mishraprafful]

ORMB login should work with docker token

[gaocegege]

SGTM, it should work. But I am not sure if it is safe to read the docker auth config.

[mishraprafful]

I might be short-sighted here, but could you point me to why do you think it might not be safe.

The use-case is that I have containers that are authenticated to push and pull to my docker registry using docker tokens and config. I wish to authenticate for ORMB as well using the same, rather than having to use a USERNAME and PASSWORD using a robot account.
Let me know your thoughts.

[gaocegege]

Docker config may have more than one user/pwd. If you are an administrator and you logged in many registries locally, I am not sure if you want to share the information with ormb client. But we can add a command or argument to support such case. I think.

Maybe a command ormb auth-from-docker or something else.

[mishraprafful]

Thanks, I understand the concern now. Do you think it is possible for me to contribute to this, but I would need some help to understand a few things.

[gaocegege]

Thanks!

Your contribution is welcome!
🎉 👍

[gaocegege]

As you know, we are using path.Join(client.rootPath, "config.json")

ormb/pkg/oras/client.go

Line 58 in c3a53c0

credentialsFile := path.Join(client.rootPath, credentialsFileBasename)

to store the credentials. The file config.json is similar to docker config.json. What we should do is to copy the credentials from docker config.json to ormb config.json. Maybe we can just get all credentials and call ormbclient.Login for every one. This func call writes the info to the config.json.

[mishraprafful]

Thanks for pointing it out, I think I can start from here soon. Will ping back if I have any more questions 🙂

[gaocegege]

Sure, thanks.