Comments (9)
SGTM
from ormb.
SGTM. Will do it soon.
from ormb.
Seems like the ormb-publish
run failed, no binaries assets where published.
from ormb.
Yeah it is caused by the wrong go version I think. I will try to fix it.
from ormb.
Tested the new release, works like a charm! Thank you @gaocegege, would it be possible to also make a new release of the python sdk to pypi too?
from ormb.
On my side, I re-implemented the ormb.api.py
module to use subprocess.run
instead of subprocess.Popen
so that we can propagate shell's stderr to python. I also added exceptions handling with custom exceptions. This is what it looks like for the login command:
class ORMBLoginError(Exception):
def __init__(self, registry_name: str, username: str, stderr: str) -> None:
msg = f"Login to {registry_name} as '{username}' failed with stderr:\n{stderr}"
super().__init__(msg)
def login(
hostname: str,
username: str,
password: str,
registry_name: str,
) -> subprocess.CompletedProcess:
"""
Logs in an image registry by running ORMB CLI `login` command in a subprocess.
Args:
hostname: Remote registry to authenticate to.
username: Username to authenticate with.
password: Password to authenticate with.
registry_name: Name of the registry for error logs.
Returns:
The completed process.
Raises:
ORMBLoginError: ORMB login command process exited with a non-zero exit code.
"""
args = [
BIN_PATHNAME,
"login",
hostname,
"--username",
username,
"--password-stdin",
"--insecure",
"False",
]
try:
return subprocess.run(
args=args,
capture_output=True,
check=True,
input=password,
text=True,
)
except subprocess.CalledProcessError as e:
raise _cli_api_exceptions.ORMBLoginError(
registry_name=registry_name,
username=username,
stderr=e.stderr,
)
If you want I could create a PR this weekend to enhance the api.py
module before you make the release.
from ormb.
If you want I could create a PR this weekend to enhance the api.py module before you make the release.
I think it works for me! Thanks for the PR!
from ormb.
https://pypi.org/project/ormb/0.1.0/
from ormb.
Thx @gaocegege! Tested locally 🚀
from ormb.
Related Issues (20)
- 您好,在部署“使用 Seldon Core 启动模型服务”是遇到问题
- Push failed for Harbor v1.10.1 HOT 3
- Support other stateful ML artifacts like transformers HOT 4
- Ease packaging and publishing process in python HOT 3
- Python SDK installs Linux pre-compiled binaries on Mac OS HOT 3
- [feature] Add support for `pickle` format
- 您好,在部署“使用 Seldon Core 启动模型服务”是遇到问题 HOT 7
- Export command destination parameter not used without its `-d` flag HOT 4
- ORMB login should work with docker token HOT 8
- SeldonDeployment 的pod没有ready HOT 1
- ORMB python sdk setup.py imports requests before installing it
- Refactor with oras-go
- [feature] Use DockerHub remote registry - Cannot Push HOT 3
- Long term vision between ORMB and ORAS HOT 3
- directoryStructure set to <artifact_name> and not prepended by model/ dir HOT 4
- Broken python sdk PyPI release
- BUG REPORT: urgent HOT 1
- [Bug] Save/Tag interpret numeric tags as port numbers
- ormb save/ ormb push 看不到进度,模型资源大时以为死掉了
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ormb.