kmiksa/jammming

React web application allows users to search the Spotify library, create a custom playlist, then save it to their Spotify account.

jammming's Issues

Feature Request Summary

Grade: Meets expectations

Summary:

I thought this font was hard to read. You should stick to Arial or Times New Roman for professional documents. I changed the font on my copy in order to review it.

You should correct typos as they occur. In a real situation, it would be seen as professional. Google docs and Word apps make suggestions as they occur. You should review what it is suggesting when you see a red underline. Consider installing the Grammarly plugin for your browser. It will help with spelling everywhere you type, not only document applications.

You lay out a rock solid plan for implementing a feature that definitely improves the user’s Jammming experience. The idea itself is a natural suggestion, as most users would likely assume the Enter key would serve that purpose and therefore would find it inconvenient that the app doesn’t do that. Your implementation is also the easiest way to accomplish the goal.

I thought the technical design and caveats were well thought out. Nice work!

Duplicate Tracks

avoid adding adding duplicate tracks by testing if it already exists.

  addTrack(track) {
    let tracks = this.state.playlistTracks;
    if (!tracks.includes(track)) {
      tracks.push(track);
      this.setState({playlistTracks: tracks});
    }
  }

handleKeyPress

The enter key feature was done nicely.

Summary

The project came out very well. very nicely formatted code.